From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79493C433FF for ; Thu, 1 Aug 2019 14:14:25 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5641F20B7C for ; Thu, 1 Aug 2019 14:14:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5641F20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E5D6D2742; Thu, 1 Aug 2019 14:10:29 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3C9D0EBD for ; Thu, 1 Aug 2019 14:09:17 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C7CBF8A3 for ; Thu, 1 Aug 2019 14:09:16 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id EEECA68AFE; Thu, 1 Aug 2019 16:09:13 +0200 (CEST) Date: Thu, 1 Aug 2019 16:09:13 +0200 From: Christoph Hellwig To: Lu Baolu Subject: Re: [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper Message-ID: <20190801140913.GD23435@lst.de> References: <20190801060156.8564-1-baolu.lu@linux.intel.com> <20190801060156.8564-2-baolu.lu@linux.intel.com> <20190801061021.GA14955@lst.de> <40f3a736-0a96-0491-61ad-0ddf03612d91@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <40f3a736-0a96-0491-61ad-0ddf03612d91@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: kevin.tian@intel.com, ashok.raj@intel.com, Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jacob.jun.pan@intel.com, David Woodhouse , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Thu, Aug 01, 2019 at 02:20:07PM +0800, Lu Baolu wrote: > Hi Christoph, > > On 8/1/19 2:10 PM, Christoph Hellwig wrote: >> On Thu, Aug 01, 2019 at 02:01:54PM +0800, Lu Baolu wrote: >>> + /* No lock here, assumes no domain exit in normal case */ >> >> s/exit/exists/ ? > > This comment is just moved from one place to another in this patch. > > "no domain exit" means "the domain isn't freed". (my understand) Maybe we'll get that refconfirmed and can fix up the comment? > >> >>> + info = dev->archdata.iommu; >>> + if (likely(info)) >>> + return info->domain; >> >> But then again the likely would be odd. >> > > Normally there's a domain for a device (default domain or isolation > domain for assignment cases). Makes sense, I just mean to say that the likely was contrary to my understanding of the above comment. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300BAC433FF for ; Thu, 1 Aug 2019 14:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DAAA20679 for ; Thu, 1 Aug 2019 14:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731785AbfHAOJQ (ORCPT ); Thu, 1 Aug 2019 10:09:16 -0400 Received: from verein.lst.de ([213.95.11.211]:43803 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731377AbfHAOJQ (ORCPT ); Thu, 1 Aug 2019 10:09:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id EEECA68AFE; Thu, 1 Aug 2019 16:09:13 +0200 (CEST) Date: Thu, 1 Aug 2019 16:09:13 +0200 From: Christoph Hellwig To: Lu Baolu Cc: Christoph Hellwig , David Woodhouse , Joerg Roedel , ashok.raj@intel.com, jacob.jun.pan@intel.com, kevin.tian@intel.com, Robin Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan Subject: Re: [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper Message-ID: <20190801140913.GD23435@lst.de> References: <20190801060156.8564-1-baolu.lu@linux.intel.com> <20190801060156.8564-2-baolu.lu@linux.intel.com> <20190801061021.GA14955@lst.de> <40f3a736-0a96-0491-61ad-0ddf03612d91@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40f3a736-0a96-0491-61ad-0ddf03612d91@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 02:20:07PM +0800, Lu Baolu wrote: > Hi Christoph, > > On 8/1/19 2:10 PM, Christoph Hellwig wrote: >> On Thu, Aug 01, 2019 at 02:01:54PM +0800, Lu Baolu wrote: >>> + /* No lock here, assumes no domain exit in normal case */ >> >> s/exit/exists/ ? > > This comment is just moved from one place to another in this patch. > > "no domain exit" means "the domain isn't freed". (my understand) Maybe we'll get that refconfirmed and can fix up the comment? > >> >>> + info = dev->archdata.iommu; >>> + if (likely(info)) >>> + return info->domain; >> >> But then again the likely would be odd. >> > > Normally there's a domain for a device (default domain or isolation > domain for assignment cases). Makes sense, I just mean to say that the likely was contrary to my understanding of the above comment.