From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BD3C433FF for ; Thu, 1 Aug 2019 20:26:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CBFA206A2 for ; Thu, 1 Aug 2019 20:26:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eG3aV5Wq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uIMkE6Bk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CBFA206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kdETCZjLLrdeB48KhCvLi6OtCkg4ihoLBlza/AiNs34=; b=eG3aV5WqfV0i3p 5vj9rpM8Rp/LZu9ytXQFubxawRXHq5uP2xixZz9EKjpLhy/OdKi8IfE+iCOwot4YyHERUkmn++CXM nt3t1WRIFeubw9ohMSdXCH3lkqtWjyMCf+16juKiCttaDLV8kqfHcHp/wADPaLgnI5rcveQW7zJyo GyqQ0DIvqDPF/jq1VnflXrC1ckeQzmpMj2rGrT93zoNShpcRqSQcm6xmuaihgnrNknZe7f6DAnzWK 4i465Lbx90LxHeSOvMK4Fj0OtNFOZakj20tSC1J2G9pIhJErxa7wFZio+GuEukbvVREL3o1xLL8UL 31h5exo9O33UCt50W8RQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htHf2-0001wY-NQ; Thu, 01 Aug 2019 20:26:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htHez-0001wB-UP for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2019 20:26:51 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF401206A2; Thu, 1 Aug 2019 20:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564691209; bh=3kiBq6E034Z6N48eibdLMScZtbrZXviKsYJcFJJR76s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uIMkE6Bk0ixbVPKTsDKLp3pFj9NEvlcuDoWx8L8sEmuNAIBeQEIFbZ3PTQEtFI37Y wt+1jcd635CXrMs/kSqA1DgMSehVrCd5gNdjd275kU+nMCi5xVR1EqJpRa/8aESXVN ZUgQ3UTjJGp8CdFxcS7g5RHmDJOtRH/wbWxn1lXQ= Date: Thu, 1 Aug 2019 22:26:46 +0200 From: Greg KH To: Mathieu Poirier Subject: Re: [PATCH 1/1] coresight: Fix DEBUG_LOCKS_WARN_ON for uninitialized attribute Message-ID: <20190801202646.GA4654@kroah.com> References: <20190801172323.18359-1-mathieu.poirier@linaro.org> <20190801172323.18359-2-mathieu.poirier@linaro.org> <20190801185045.GA31197@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190801_132649_998395_83899739 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel , "Suzuki K. Poulose" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 01, 2019 at 02:20:39PM -0600, Mathieu Poirier wrote: > On Thu, 1 Aug 2019 at 12:50, Greg KH wrote: > > > > On Thu, Aug 01, 2019 at 11:23:23AM -0600, Mathieu Poirier wrote: > > > From: Suzuki K Poulose > > > > > > While running the linux-next with CONFIG_DEBUG_LOCKS_ALLOC enabled, > > > I get the following splat. > > > > > > BUG: key ffffcb5636929298 has not been registered! > > > ------------[ cut here ]------------ > > > DEBUG_LOCKS_WARN_ON(1) > > > WARNING: CPU: 1 PID: 53 at kernel/locking/lockdep.c:3669 lockdep_init_map+0x164/0x1f0 > > > CPU: 1 PID: 53 Comm: kworker/1:1 Tainted: G W 5.2.0-next-20190712-00015-g00ad4634222e-dirty #603 > > > Workqueue: events amba_deferred_retry_func > > > pstate: 60c00005 (nZCv daif +PAN +UAO) > > > pc : lockdep_init_map+0x164/0x1f0 > > > lr : lockdep_init_map+0x164/0x1f0 > > > > > > [ trimmed ] > > > > > > Call trace: > > > lockdep_init_map+0x164/0x1f0 > > > __kernfs_create_file+0x9c/0x158 > > > sysfs_add_file_mode_ns+0xa8/0x1d0 > > > sysfs_add_file_to_group+0x88/0xd8 > > > etm_perf_add_symlink_sink+0xcc/0x138 > > > coresight_register+0x110/0x280 > > > tmc_probe+0x160/0x420 > > > > > > [ trimmed ] > > > > > > ---[ end trace ab4cc669615ba1b0 ]--- > > > > > > Fix this by initialising the dynamically allocated attribute properly. > > > > > > Cc: Mathieu Poirier > > > Fixes: bb8e370bdc141ddf ("coresight: perf: Add "sinks" group to PMU directory") > > > > That should be: > > Fixes: bb8e370bdc14 ("coresight: perf: Add "sinks" group to PMU directory") > > Apologies - I will catch those from hereon. > > > > > I can go fix it up... > > Or I can, depending on if you're going to pick the patch as a fix for > 5.3 or you'll wait for the 5.4 cycle. It's already queued up for my next round of patches to Linus to be during the 5.3-rc cycle. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel