From: Wei Yang <richardw.yang@linux.intel.com>
To: Ivan Ren <renyime@gmail.com>
Cc: quintela@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 for new migration
Date: Fri, 2 Aug 2019 08:50:40 +0800 [thread overview]
Message-ID: <20190802005040.GB20638@richard> (raw)
In-Reply-To: <CA+6E1=nmUtP9B4veF-wwSObuu_vM8byB=ub9E77h3Y5xwca6Hw@mail.gmail.com>
On Thu, Aug 01, 2019 at 03:58:54PM +0800, Ivan Ren wrote:
>>>- * Here we didn't set RAMBlock.bmap simply because it is
>already
>>>- * set in ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] in
>>>- * ram_block_add, and that's where we'll sync the dirty
>bitmaps.
>>>- * Here setting RAMBlock.bmap would be fine too but not
>necessary.
>>>+ * Here we set RAMBlock.bmap all to 1 because when rebegin a
>>>+ * new migration after a failed migration, ram_list.
>>
>>It is after failure or cancel?
>
>Here we can treat cancel as a special fail.
>
Well, I am not sure this is officially documented. Would this lead to
confusion?
>Thanks.
>
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-08-02 0:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 14:51 [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 for new migration Ivan Ren
2019-07-15 1:47 ` Peter Xu
2019-07-15 9:50 ` Dr. David Alan Gilbert
2019-07-15 9:40 ` Dr. David Alan Gilbert
2019-08-01 2:55 ` Wei Yang
2019-08-01 7:58 ` Ivan Ren
2019-08-02 0:50 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802005040.GB20638@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=renyime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.