From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Harald Freudenberger <freude@linux.ibm.com>,
Patrick Steuer <steuer@linux.ibm.com>
Subject: Re: linux-next: Tree for Jul 31 - s390 crypto build breakage
Date: Fri, 2 Aug 2019 08:46:05 +0200 [thread overview]
Message-ID: <20190802064605.GA4158@osiris> (raw)
In-Reply-To: <CAKv+Gu_1HP2NapMk5O_-XpJdga5zyFJDkVudTRT6CWm+tqPndA@mail.gmail.com>
On Thu, Aug 01, 2019 at 08:28:56PM +0300, Ard Biesheuvel wrote:
> On Thu, 1 Aug 2019 at 15:28, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > Still not... with linux-next as of today I get this (s390 defconfig):
> >
> > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined!
> > ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined!
> > ERROR: "crypto_aegis128_encrypt_chunk_simd" [crypto/aegis128.ko] undefined!
> > scripts/Makefile.modpost:105: recipe for target 'modules-modpost' failed
> >
>
> Hello Heiko,
>
> Apologies for the breakage. The first two fixes addressed obvious
> shortcomings in my code, but with this issue, I'm a bit puzzled tbh.
> The calls to these missing functions should be optimized away, since
> have_simd never gets assigned if CONFIG_CRYPTO_AEGIS128_SIMD is not
> defined, but for some reason, this isn't working. Which version of GCC
> are you using?
Plain vanilla gcc 9.1.0.
> Also, could you please try whether the patch below fixes the problem? Thanks
> https://lore.kernel.org/linux-crypto/20190729074434.21064-1-ard.biesheuvel@linaro.org/
Yes, with that patch applied the code compiles.
next prev parent reply other threads:[~2019-08-02 6:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 6:39 linux-next: Tree for Jul 31 Stephen Rothwell
2019-07-31 8:58 ` linux-next: Tree for Jul 31 - s390 crypto build breakage Heiko Carstens
2019-07-31 11:08 ` Herbert Xu
2019-07-31 11:15 ` Heiko Carstens
2019-07-31 11:32 ` Herbert Xu
2019-07-31 11:44 ` Heiko Carstens
2019-08-01 12:28 ` Heiko Carstens
2019-08-01 17:28 ` Ard Biesheuvel
2019-08-02 0:20 ` Stephen Rothwell
2019-08-02 3:14 ` Herbert Xu
2019-08-02 4:48 ` Stephen Rothwell
2019-08-02 6:49 ` Heiko Carstens
2019-08-02 6:44 ` Ard Biesheuvel
2019-08-02 6:50 ` Herbert Xu
2019-08-02 6:47 ` Ard Biesheuvel
2019-08-02 6:46 ` Heiko Carstens [this message]
2019-08-02 6:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802064605.GA4158@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=freude@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=steuer@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.