From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB53C433FF for ; Fri, 2 Aug 2019 13:29:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFFD2217D6 for ; Fri, 2 Aug 2019 13:29:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564752552; bh=pBQUkxFJxk0OsLuie9+dxe9BHL+6lSjWk+WWwDrTOAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d7v/KD0nH8ILMQsVHbLKlW6w+rdmTduiisF2TPoJ2SPVovACU2J6sVzMoyeYPQqrB Uk4MejlubM66WLh8B+BIuBHjytjC/RD2UXVHXqpPioUqd6hpUilNYmRp1t9TB9yc9e fdgOy+gKKCfd5c7YPRxPRN6H2E22vrM++62Ww2EI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394335AbfHBNZN (ORCPT ); Fri, 2 Aug 2019 09:25:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:35972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391228AbfHBNZM (ORCPT ); Fri, 2 Aug 2019 09:25:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E63AE217D4; Fri, 2 Aug 2019 13:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564752312; bh=pBQUkxFJxk0OsLuie9+dxe9BHL+6lSjWk+WWwDrTOAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HBC3DMk0khvNpjoMbTAdMzyNnGkq9MMZmpB47WsEL4+FGs1SVIGASbeUbcaoZwyLU E9GyGLF4xyp2qMWlNCDWaanMnK+/HbkYaTBOk6R2kA34n4Bkf2/dlffmQD2PK7JGEF FNT1LPlebRIJPaDU6dtKrJ9vz7Zk9lfkoptn769s= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lorenzo Pieralisi , Hanjun Guo , Dan Carpenter , Will Deacon , Sudeep Holla , Catalin Marinas , Robin Murphy , Sasha Levin , linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 22/30] ACPI/IORT: Fix off-by-one check in iort_dev_find_its_id() Date: Fri, 2 Aug 2019 09:24:14 -0400 Message-Id: <20190802132422.13963-22-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190802132422.13963-1-sashal@kernel.org> References: <20190802132422.13963-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Lorenzo Pieralisi [ Upstream commit 5a46d3f71d5e5a9f82eabc682f996f1281705ac7 ] Static analysis identified that index comparison against ITS entries in iort_dev_find_its_id() is off by one. Update the comparison condition and clarify the resulting error message. Fixes: 4bf2efd26d76 ("ACPI: Add new IORT functions to support MSI domain handling") Link: https://lore.kernel.org/linux-arm-kernel/20190613065410.GB16334@mwanda/ Reviewed-by: Hanjun Guo Reported-by: Dan Carpenter Signed-off-by: Lorenzo Pieralisi Cc: Dan Carpenter Cc: Will Deacon Cc: Hanjun Guo Cc: Sudeep Holla Cc: Catalin Marinas Cc: Robin Murphy Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/acpi/arm64/iort.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index ca414910710ea..b0a7afd4e7d35 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c @@ -506,8 +506,8 @@ static int iort_dev_find_its_id(struct device *dev, u32 req_id, /* Move to ITS specific data */ its = (struct acpi_iort_its_group *)node->node_data; - if (idx > its->its_count) { - dev_err(dev, "requested ITS ID index [%d] is greater than available [%d]\n", + if (idx >= its->its_count) { + dev_err(dev, "requested ITS ID index [%d] overruns ITS entries [%d]\n", idx, its->its_count); return -ENXIO; } -- 2.20.1