From: Adrian Reber <areber@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: Oleg Nesterov <oleg@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
Pavel Emelianov <xemul@virtuozzo.com>,
Jann Horn <jannh@google.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
linux-kernel@vger.kernel.org, Andrei Vagin <avagin@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Radostin Stoyanov <rstoyanov1@gmail.com>
Subject: Re: [PATCH v2 1/2] fork: extend clone3() to support CLONE_SET_TID
Date: Fri, 2 Aug 2019 18:50:44 +0200 [thread overview]
Message-ID: <20190802165044.GF18263@dcbz.redhat.com> (raw)
In-Reply-To: <20190802135248.gbtkh5sgjzmbup5h@brauner.io>
On Fri, Aug 02, 2019 at 03:52:49PM +0200, Christian Brauner wrote:
> On Fri, Aug 02, 2019 at 03:46:11PM +0200, Oleg Nesterov wrote:
> > On 08/02, Oleg Nesterov wrote:
> > >
> > > So Adrian, sorry for confusion, I think your patch is fine.
Good to know.
> > Yes... but do we really need the new CLONE_SET_TID ?
> >
> > set_tid == 0 has no effect, can't we simply check kargs->set_tid != 0
> > before ns_capable() ?
>
> Yeah, I agree that sounds much better and aligns with exit_signal.
Let me remove CLONE_SET_TID from the patch and I will try out
idr_is_empty().
I will also address Dmitry's comment about accessing smaller parameter
structs.
Adrian
next prev parent reply other threads:[~2019-08-02 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:12 [PATCH v2 1/2] fork: extend clone3() to support CLONE_SET_TID Adrian Reber
2019-07-31 16:12 ` [PATCH v2 2/2] selftests: add test for clone3() with set_tid Adrian Reber
2019-07-31 16:49 ` [PATCH v2 1/2] fork: extend clone3() to support CLONE_SET_TID Dmitry Safonov
2019-07-31 16:56 ` Dmitry Safonov
2019-07-31 17:41 ` Oleg Nesterov
2019-08-02 7:25 ` Adrian Reber
2019-08-02 12:47 ` Oleg Nesterov
2019-08-02 13:02 ` Christian Brauner
2019-08-02 13:24 ` Oleg Nesterov
2019-08-02 13:46 ` Oleg Nesterov
2019-08-02 13:52 ` Christian Brauner
2019-08-02 16:50 ` Adrian Reber [this message]
2019-08-02 13:19 ` Christian Brauner
2019-08-02 13:30 ` Oleg Nesterov
2019-08-02 13:50 ` Christian Brauner
2019-08-02 15:10 ` Adrian Reber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802165044.GF18263@dcbz.redhat.com \
--to=areber@redhat.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@gmail.com \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=rstoyanov1@gmail.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.