From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Sat, 03 Aug 2019 02:12:22 +0000 Subject: Re: [PATCH] video: fbdev: omapfb_main: Mark expected switch fall-throughs Message-Id: <201908021912.0D14906FF9@keescook> List-Id: References: <20190802191542.GA32751@embeddedor> In-Reply-To: <20190802191542.GA32751@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz On Fri, Aug 02, 2019 at 02:15:42PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: omap1_defconfig arm): > > drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -Kees > --- > drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c > index 90eca64e3144..702cca59bda1 100644 > --- a/drivers/video/fbdev/omap/omapfb_main.c > +++ b/drivers/video/fbdev/omap/omapfb_main.c > @@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane, > return 0; > case 12: > var->bits_per_pixel = 16; > + /* fall through */ > case 16: > if (plane->fbdev->panel->bpp = 12) > plane->color_mode = OMAPFB_COLOR_RGB444; > @@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state) > case OMAPFB_ACTIVE: > for (i = 0; i < fbdev->mem_desc.region_cnt; i++) > unregister_framebuffer(fbdev->fb_info[i]); > + /* fall through */ > case 7: > omapfb_unregister_sysfs(fbdev); > + /* fall through */ > case 6: > if (fbdev->panel->disable) > fbdev->panel->disable(fbdev->panel); > + /* fall through */ > case 5: > omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED); > + /* fall through */ > case 4: > planes_cleanup(fbdev); > + /* fall through */ > case 3: > ctrl_cleanup(fbdev); > + /* fall through */ > case 2: > if (fbdev->panel->cleanup) > fbdev->panel->cleanup(fbdev->panel); > + /* fall through */ > case 1: > dev_set_drvdata(fbdev->dev, NULL); > kfree(fbdev); > -- > 2.22.0 > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH] video: fbdev: omapfb_main: Mark expected switch fall-throughs Date: Fri, 2 Aug 2019 19:12:22 -0700 Message-ID: <201908021912.0D14906FF9@keescook> References: <20190802191542.GA32751@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190802191542.GA32751@embeddedor> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz List-Id: linux-omap@vger.kernel.org T24gRnJpLCBBdWcgMDIsIDIwMTkgYXQgMDI6MTU6NDJQTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBNYXJrIHN3aXRjaCBjYXNlcyB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5nIHRv IGZhbGwgdGhyb3VnaC4KPiAKPiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2Fybmlu ZyAoQnVpbGRpbmc6IG9tYXAxX2RlZmNvbmZpZyBhcm0pOgo+IAo+IGRyaXZlcnMvdmlkZW8vZmJk ZXYvb21hcC9vbWFwZmJfbWFpbi5jOjQ0OToyMzogd2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5 IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCj4gZHJpdmVycy92aWRlby9m YmRldi9vbWFwL29tYXBmYl9tYWluLmM6MTU0OTo2OiB3YXJuaW5nOiB0aGlzIHN0YXRlbWVudCBt YXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJvdWdoPV0KPiBkcml2ZXJzL3ZpZGVv L2ZiZGV2L29tYXAvb21hcGZiX21haW4uYzoxNTQ3OjM6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50 IG1heSBmYWxsIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+IGRyaXZlcnMvdmlk ZW8vZmJkZXYvb21hcC9vbWFwZmJfbWFpbi5jOjE1NDU6Mzogd2FybmluZzogdGhpcyBzdGF0ZW1l bnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCj4gZHJpdmVycy92 aWRlby9mYmRldi9vbWFwL29tYXBmYl9tYWluLmM6MTU0MzozOiB3YXJuaW5nOiB0aGlzIHN0YXRl bWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJvdWdoPV0KPiBkcml2ZXJz L3ZpZGVvL2ZiZGV2L29tYXAvb21hcGZiX21haW4uYzoxNTQwOjY6IHdhcm5pbmc6IHRoaXMgc3Rh dGVtZW50IG1heSBmYWxsIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+IGRyaXZl cnMvdmlkZW8vZmJkZXYvb21hcC9vbWFwZmJfbWFpbi5jOjE1Mzg6Mzogd2FybmluZzogdGhpcyBz dGF0ZW1lbnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCj4gZHJp dmVycy92aWRlby9mYmRldi9vbWFwL29tYXBmYl9tYWluLmM6MTUzNTozOiB3YXJuaW5nOiB0aGlz IHN0YXRlbWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJvdWdoPV0KPiAK PiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3Iu Y29tPgoKUmV2aWV3ZWQtYnk6IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPgoKLUtl ZXMKCj4gLS0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcC9vbWFwZmJfbWFpbi5jIHwgOCAr KysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcC9vbWFwZmJfbWFpbi5jIGIvZHJpdmVycy92aWRl by9mYmRldi9vbWFwL29tYXBmYl9tYWluLmMKPiBpbmRleCA5MGVjYTY0ZTMxNDQuLjcwMmNjYTU5 YmRhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAvb21hcGZiX21haW4u Ywo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcC9vbWFwZmJfbWFpbi5jCj4gQEAgLTQ0 Nyw2ICs0NDcsNyBAQCBzdGF0aWMgaW50IHNldF9jb2xvcl9tb2RlKHN0cnVjdCBvbWFwZmJfcGxh bmVfc3RydWN0ICpwbGFuZSwKPiAgCQlyZXR1cm4gMDsKPiAgCWNhc2UgMTI6Cj4gIAkJdmFyLT5i aXRzX3Blcl9waXhlbCA9IDE2Owo+ICsJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ICAJY2FzZSAxNjoK PiAgCQlpZiAocGxhbmUtPmZiZGV2LT5wYW5lbC0+YnBwID09IDEyKQo+ICAJCQlwbGFuZS0+Y29s b3JfbW9kZSA9IE9NQVBGQl9DT0xPUl9SR0I0NDQ7Cj4gQEAgLTE1MzQsMjAgKzE1MzUsMjcgQEAg c3RhdGljIHZvaWQgb21hcGZiX2ZyZWVfcmVzb3VyY2VzKHN0cnVjdCBvbWFwZmJfZGV2aWNlICpm YmRldiwgaW50IHN0YXRlKQo+ICAJY2FzZSBPTUFQRkJfQUNUSVZFOgo+ICAJCWZvciAoaSA9IDA7 IGkgPCBmYmRldi0+bWVtX2Rlc2MucmVnaW9uX2NudDsgaSsrKQo+ICAJCQl1bnJlZ2lzdGVyX2Zy YW1lYnVmZmVyKGZiZGV2LT5mYl9pbmZvW2ldKTsKPiArCQkvKiBmYWxsIHRocm91Z2ggKi8KPiAg CWNhc2UgNzoKPiAgCQlvbWFwZmJfdW5yZWdpc3Rlcl9zeXNmcyhmYmRldik7Cj4gKwkJLyogZmFs bCB0aHJvdWdoICovCj4gIAljYXNlIDY6Cj4gIAkJaWYgKGZiZGV2LT5wYW5lbC0+ZGlzYWJsZSkK PiAgCQkJZmJkZXYtPnBhbmVsLT5kaXNhYmxlKGZiZGV2LT5wYW5lbCk7Cj4gKwkJLyogZmFsbCB0 aHJvdWdoICovCj4gIAljYXNlIDU6Cj4gIAkJb21hcGZiX3NldF91cGRhdGVfbW9kZShmYmRldiwg T01BUEZCX1VQREFURV9ESVNBQkxFRCk7Cj4gKwkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNl IDQ6Cj4gIAkJcGxhbmVzX2NsZWFudXAoZmJkZXYpOwo+ICsJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ ICAJY2FzZSAzOgo+ICAJCWN0cmxfY2xlYW51cChmYmRldik7Cj4gKwkJLyogZmFsbCB0aHJvdWdo ICovCj4gIAljYXNlIDI6Cj4gIAkJaWYgKGZiZGV2LT5wYW5lbC0+Y2xlYW51cCkKPiAgCQkJZmJk ZXYtPnBhbmVsLT5jbGVhbnVwKGZiZGV2LT5wYW5lbCk7Cj4gKwkJLyogZmFsbCB0aHJvdWdoICov Cj4gIAljYXNlIDE6Cj4gIAkJZGV2X3NldF9kcnZkYXRhKGZiZGV2LT5kZXYsIE5VTEwpOwo+ICAJ CWtmcmVlKGZiZGV2KTsKPiAtLSAKPiAyLjIyLjAKPiAKCi0tIApLZWVzIENvb2sKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43820C0650F for ; Sat, 3 Aug 2019 02:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FB672087E for ; Sat, 3 Aug 2019 02:12:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W1XDyd/e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393019AbfHCCMZ (ORCPT ); Fri, 2 Aug 2019 22:12:25 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45826 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390851AbfHCCMY (ORCPT ); Fri, 2 Aug 2019 22:12:24 -0400 Received: by mail-pf1-f193.google.com with SMTP id r1so36868088pfq.12 for ; Fri, 02 Aug 2019 19:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0+Bh9KmnXViBMy75SYIrHK8KzqIb8xEh1Les/yPtYIU=; b=W1XDyd/eLmCYsL4iRwwQNmX8884q9VUr17ETlif8/CAA5qV8yN8Yxp8/uLiUKbEPNp vu2syS8+zGaNUypp+NYuHXzYTym6ux5nVs5SJnxyww8VukcpW0nBNSaaLSWxf7I1Dme+ 5a2tj/09h2LSKXtJKOVr6H1wa6ZWVaxHdDFgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0+Bh9KmnXViBMy75SYIrHK8KzqIb8xEh1Les/yPtYIU=; b=qHOWegnbbJM4bDVz8cgqMDTwCjSCyyxNt1vJqo8/g/zf9U7GKXOvjFAOvvwOAJfaI8 6POQ9qROW8VvYfPJH47m317uvBHGrzsscPisFcXOeRGKENgnYwzl/aKUxDfaPrHKuJg7 DXOlslKQIAVwp2F0QZCJnjJZV1PEfoP22jdOiQoEgR5JnRr5Tc0lEI1VS8I7J0x1ace/ vvNnYLemo9NUf6j3/0SHarBWC8WqM3fvVayvJTaGP3UJmcdAQHr3Dz10YR0Uh0fSuS4I 7ckPkMRbT1FWgnqyqQRHt/2ZwVhAUSCanoLuKm4cplxLtz2WaMCR3FQfsKayD4IUiRrG lvMw== X-Gm-Message-State: APjAAAV2MrtDUEuLATogY0GsLjKyc53WvlXWsLvWBELZgde+20H0lcWR SfVS5/VY1m8+/ybnINFfhNX/wA== X-Google-Smtp-Source: APXvYqxFE10Abv2h+d0F63SfhCFmdx6AtEvxbdzGAwl9Ed1nqm194Q37CBphEcFBXWnGM1oKOcN5ww== X-Received: by 2002:a62:1616:: with SMTP id 22mr63711224pfw.120.1564798343773; Fri, 02 Aug 2019 19:12:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g4sm91419764pfo.93.2019.08.02.19.12.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Aug 2019 19:12:23 -0700 (PDT) Date: Fri, 2 Aug 2019 19:12:22 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: omapfb_main: Mark expected switch fall-throughs Message-ID: <201908021912.0D14906FF9@keescook> References: <20190802191542.GA32751@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802191542.GA32751@embeddedor> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 02, 2019 at 02:15:42PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: omap1_defconfig arm): > > drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -Kees > --- > drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c > index 90eca64e3144..702cca59bda1 100644 > --- a/drivers/video/fbdev/omap/omapfb_main.c > +++ b/drivers/video/fbdev/omap/omapfb_main.c > @@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane, > return 0; > case 12: > var->bits_per_pixel = 16; > + /* fall through */ > case 16: > if (plane->fbdev->panel->bpp == 12) > plane->color_mode = OMAPFB_COLOR_RGB444; > @@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state) > case OMAPFB_ACTIVE: > for (i = 0; i < fbdev->mem_desc.region_cnt; i++) > unregister_framebuffer(fbdev->fb_info[i]); > + /* fall through */ > case 7: > omapfb_unregister_sysfs(fbdev); > + /* fall through */ > case 6: > if (fbdev->panel->disable) > fbdev->panel->disable(fbdev->panel); > + /* fall through */ > case 5: > omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED); > + /* fall through */ > case 4: > planes_cleanup(fbdev); > + /* fall through */ > case 3: > ctrl_cleanup(fbdev); > + /* fall through */ > case 2: > if (fbdev->panel->cleanup) > fbdev->panel->cleanup(fbdev->panel); > + /* fall through */ > case 1: > dev_set_drvdata(fbdev->dev, NULL); > kfree(fbdev); > -- > 2.22.0 > -- Kees Cook