From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814BAC433FF for ; Sat, 3 Aug 2019 22:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C020214AE for ; Sat, 3 Aug 2019 22:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="rt3fI8Lv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729208AbfHCWW7 (ORCPT ); Sat, 3 Aug 2019 18:22:59 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:58922 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729195AbfHCWW6 (ORCPT ); Sat, 3 Aug 2019 18:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wXhy7Y9XBu632+EH0hMzaNos8wsO8EH/iThD5p4gReA=; b=rt3fI8LvIp209fSWlTo8mkurYe SUbtcbFZOrH8rYUu7Gj1NZdhWe5ANcKN8BLuZkyVv2qzxQN3IBZ3x5HK9e1wUXyCkQNYk+3/6qiRw Mg90VgE9qY+2gpyZ+2dWYzR4TWZgp5dBCHRaJljC2S1WgZcIAr13puJ1bF6AqfnlKfa4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hu2QP-000806-1C; Sun, 04 Aug 2019 00:22:53 +0200 Date: Sun, 4 Aug 2019 00:22:53 +0200 From: Andrew Lunn To: Arnaud Patard Cc: netdev@vger.kernel.org Subject: Re: [patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case Message-ID: <20190803222253.GA29685@lunn.ch> References: <20190802083310.772136040@rtp-net.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802083310.772136040@rtp-net.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Aug 02, 2019 at 10:32:40AM +0200, Arnaud Patard wrote: > Orion5.x systems are still using machine files and not device-tree. > Commit 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be > specified for orion-mdio") has replaced devm_clk_get() with of_clk_get(), > leading to a oops at boot and not working network, as reported in > https://lists.debian.org/debian-arm/2019/07/msg00088.html and possibly in > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908712. > > Link: https://lists.debian.org/debian-arm/2019/07/msg00088.html > Fixes: 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") > Signed-off-by: Arnaud Patard Reviewed-by: Andrew Lunn Andrew