From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>, Tao Ren <taoren@fb.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Arun Parameswaran <arun.parameswaran@broadcom.com>,
Justin Chen <justinpopo6@gmail.com>,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S
Date: Sun, 4 Aug 2019 18:22:15 +0200 [thread overview]
Message-ID: <20190804162215.GE6800@lunn.ch> (raw)
In-Reply-To: <f8de2514-081a-0e6e-fbe2-bcafcd459646@gmail.com>
> > Even if that were the case (patching phy_attach_direct to apply a
> > logical-or to dev_flags), it sounds fishy to me that the genphy code
> > is unable to determine that this PHY is running in 1000Base-X mode.
> >
> > In my opinion it all boils down to this warning:
> >
> > "PHY advertising (0,00000200,000062c0) more modes than genphy
> > supports, some modes not advertised".
> >
> The genphy code deals with Clause 22 + Gigabit BaseT only.
> Question is whether you want aneg at all in 1000Base-X mode and
> what you want the config_aneg callback to do.
> There may be some inspiration in the Marvel PHY drivers.
As far as i know, you cannot actually advertise 1000Base-X. So we
probably should not be setting the bit in advertise, only having it in
supported?
Andrew
next prev parent reply other threads:[~2019-08-04 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 21:54 [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S Tao Ren
2019-08-03 13:49 ` Vladimir Oltean
2019-08-04 4:48 ` Tao Ren
2019-08-04 14:51 ` Andrew Lunn
2019-08-04 15:59 ` Vladimir Oltean
2019-08-04 16:06 ` Heiner Kallweit
2019-08-04 16:22 ` Andrew Lunn [this message]
2019-08-04 19:22 ` Vladimir Oltean
2019-08-05 20:45 ` Heiner Kallweit
2019-08-06 0:11 ` Tao Ren
2019-08-05 6:38 ` Tao Ren
2019-08-05 13:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190804162215.GE6800@lunn.ch \
--to=andrew@lunn.ch \
--cc=arun.parameswaran@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.