From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: [PATCH v1 12/16] drm/panel: use inline comments in drm_panel.h Date: Sun, 4 Aug 2019 22:16:33 +0200 Message-ID: <20190804201637.1240-13-sam@ravnborg.org> References: <20190804201637.1240-1-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190804201637.1240-1-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, Thierry Reding Cc: Neil Armstrong , David Airlie , Laurent Pinchart , Marek Vasut , Laurent Pinchart , Sam Ravnborg , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , Allison Randal , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Alison Wang , Gwan-gyeong Mun , Alexios Zavras , linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , linux-arm-kernel@lists.infradead.org, Jernej Skrabec List-Id: linux-samsung-soc@vger.kernel.org SW5saW5lIGNvbW1lbnRzIHByb3ZpZGUgYmV0dGVyIHNwYWNlIGZvciBhZGRpdGlvbmFsIGNvbW1l bnRzLgpDb21tZW50cyB3YXMgc2xpZ2h0bHkgZWRpdGVkIHRvIGZvbGxvdyB0aGUgbm9ybWFsIHN0 eWxlLApidXQgbm8gY2hhbmdlIHRvIGFjdHVhbCBjb250ZW50LgpVc2VkIHRoZSBvcHBvcnR1bml5 IHRvIGNoYW5nZSB0aGUgb3JkZXIgaW4gZHJtX3BhbmVsX2Z1bmNzCnRvIGZvbGxvdyB0aGUgb3Jk ZXIgdGhleSB3aWxsIGJlIHVzZWQgYnkgYSBwYW5lbC4KClNpZ25lZC1vZmYtYnk6IFNhbSBSYXZu Ym9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+CkNjOiBNYXhpbWUgUmlwYXJkIDxtYXhpbWUucmlwYXJk QGJvb3RsaW4uY29tPgpDYzogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+CkNjOiBUaGllcnJ5 IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgpDYzogU2FtIFJhdm5ib3JnIDxzYW1A cmF2bmJvcmcub3JnPgpDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgpDYzogRGFu aWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgotLS0KIGluY2x1ZGUvZHJtL2RybV9wYW5lbC5o IHwgODIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9p bmNsdWRlL2RybS9kcm1fcGFuZWwuaCBiL2luY2x1ZGUvZHJtL2RybV9wYW5lbC5oCmluZGV4IDA1 M2Q2MTE2NTZiOS4uNWU2MmRlZWE0OWJhIDEwMDY0NAotLS0gYS9pbmNsdWRlL2RybS9kcm1fcGFu ZWwuaAorKysgYi9pbmNsdWRlL2RybS9kcm1fcGFuZWwuaApAQCAtMzYsMTQgKzM2LDYgQEAgc3Ry dWN0IGRpc3BsYXlfdGltaW5nOwogCiAvKioKICAqIHN0cnVjdCBkcm1fcGFuZWxfZnVuY3MgLSBw ZXJmb3JtIG9wZXJhdGlvbnMgb24gYSBnaXZlbiBwYW5lbAotICogQGRpc2FibGU6IGRpc2FibGUg cGFuZWwgKHR1cm4gb2ZmIGJhY2sgbGlnaHQsIGV0Yy4pCi0gKiBAdW5wcmVwYXJlOiB0dXJuIG9m ZiBwYW5lbAotICogQHByZXBhcmU6IHR1cm4gb24gcGFuZWwgYW5kIHBlcmZvcm0gc2V0IHVwCi0g KiBAZW5hYmxlOiBlbmFibGUgcGFuZWwgKHR1cm4gb24gYmFjayBsaWdodCwgZXRjLikKLSAqIEBn ZXRfbW9kZXM6IGFkZCBtb2RlcyB0byB0aGUgY29ubmVjdG9yIHRoYXQgdGhlIHBhbmVsIGlzIGF0 dGFjaGVkIHRvIGFuZAotICogcmV0dXJuIHRoZSBudW1iZXIgb2YgbW9kZXMgYWRkZWQKLSAqIEBn ZXRfdGltaW5nczogY29weSBkaXNwbGF5IHRpbWluZ3MgaW50byB0aGUgcHJvdmlkZWQgYXJyYXkg YW5kIHJldHVybgotICogdGhlIG51bWJlciBvZiBkaXNwbGF5IHRpbWluZ3MgYXZhaWxhYmxlCiAg KgogICogVGhlIC5wcmVwYXJlKCkgZnVuY3Rpb24gaXMgdHlwaWNhbGx5IGNhbGxlZCBiZWZvcmUg dGhlIGRpc3BsYXkgY29udHJvbGxlcgogICogc3RhcnRzIHRvIHRyYW5zbWl0IHZpZGVvIGRhdGEu IFBhbmVsIGRyaXZlcnMgY2FuIHVzZSB0aGlzIHRvIHR1cm4gdGhlIHBhbmVsCkBAIC02OSwzMSAr NjEsODkgQEAgc3RydWN0IGRpc3BsYXlfdGltaW5nOwogICogdGhlIHBhbmVsLiBUaGlzIGlzIHRo ZSBqb2Igb2YgdGhlIC51bnByZXBhcmUoKSBmdW5jdGlvbi4KICAqLwogc3RydWN0IGRybV9wYW5l bF9mdW5jcyB7Ci0JaW50ICgqZGlzYWJsZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpOwotCWlu dCAoKnVucHJlcGFyZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpOworCS8qKgorCSAqIEBwcmVw YXJlOgorCSAqCisJICogVHVybiBvbiBwYW5lbCBhbmQgcGVyZm9ybSBzZXQgdXAuCisJICovCiAJ aW50ICgqcHJlcGFyZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpOworCisJLyoqCisJICogQGVu YWJsZToKKwkgKgorCSAqIEVuYWJsZSBwYW5lbCAodHVybiBvbiBiYWNrIGxpZ2h0LCBldGMuKS4K KwkgKi8KIAlpbnQgKCplbmFibGUpKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKTsKKworCS8qKgor CSAqIEBkaXNhYmxlOgorCSAqCisJICogRGlzYWJsZSBwYW5lbCAodHVybiBvZmYgYmFjayBsaWdo dCwgZXRjLikuCisJICovCisJaW50ICgqZGlzYWJsZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwp OworCisJLyoqCisJICogQHVucHJlcGFyZToKKwkgKgorCSAqIFR1cm4gb2ZmIHBhbmVsLgorCSAq LworCWludCAoKnVucHJlcGFyZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpOworCisJLyoqCisJ ICogQGdldF9tb2RlczoKKwkgKgorCSAqIEFkZCBtb2RlcyB0byB0aGUgY29ubmVjdG9yIHRoYXQg dGhlIHBhbmVsIGlzIGF0dGFjaGVkIHRvIGFuZAorCSAqIHJldHVybiB0aGUgbnVtYmVyIG9mIG1v ZGVzIGFkZGVkLgorCSAqLwogCWludCAoKmdldF9tb2Rlcykoc3RydWN0IGRybV9wYW5lbCAqcGFu ZWwpOworCisJLyoqCisJICogQGdldF90aW1pbmdzOgorCSAqCisJICogQ29weSBkaXNwbGF5IHRp bWluZ3MgaW50byB0aGUgcHJvdmlkZWQgYXJyYXkgYW5kIHJldHVybgorCSAqIHRoZSBudW1iZXIg b2YgZGlzcGxheSB0aW1pbmdzIGF2YWlsYWJsZS4KKwkgKi8KIAlpbnQgKCpnZXRfdGltaW5ncyko c3RydWN0IGRybV9wYW5lbCAqcGFuZWwsIHVuc2lnbmVkIGludCBudW1fdGltaW5ncywKIAkJCSAg IHN0cnVjdCBkaXNwbGF5X3RpbWluZyAqdGltaW5ncyk7CiB9OwogCiAvKioKICAqIHN0cnVjdCBk cm1fcGFuZWwgLSBEUk0gcGFuZWwgb2JqZWN0Ci0gKiBAZHJtOiBEUk0gZGV2aWNlIG93bmluZyB0 aGUgcGFuZWwKLSAqIEBjb25uZWN0b3I6IERSTSBjb25uZWN0b3IgdGhhdCB0aGUgcGFuZWwgaXMg YXR0YWNoZWQgdG8KLSAqIEBkZXY6IHBhcmVudCBkZXZpY2Ugb2YgdGhlIHBhbmVsCi0gKiBAbGlu azogbGluayBmcm9tIHBhbmVsIGRldmljZSAoc3VwcGxpZXIpIHRvIERSTSBkZXZpY2UgKGNvbnN1 bWVyKQotICogQGZ1bmNzOiBvcGVyYXRpb25zIHRoYXQgY2FuIGJlIHBlcmZvcm1lZCBvbiB0aGUg cGFuZWwKLSAqIEBsaXN0OiBwYW5lbCBlbnRyeSBpbiByZWdpc3RyeQogICovCiBzdHJ1Y3QgZHJt X3BhbmVsIHsKKwkvKioKKwkgKiBAZHJtOgorCSAqCisJICogRFJNIGRldmljZSBvd25pbmcgdGhl IHBhbmVsLgorCSAqLwogCXN0cnVjdCBkcm1fZGV2aWNlICpkcm07CisKKwkvKioKKwkgKiBAY29u bmVjdG9yOgorCSAqCisJICogRFJNIGNvbm5lY3RvciB0aGF0IHRoZSBwYW5lbCBpcyBhdHRhY2hl ZCB0by4KKwkgKi8KIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOworCisJLyoqCisJ ICogQGRldjoKKwkgKgorCSAqIFBhcmVudCBkZXZpY2Ugb2YgdGhlIHBhbmVsLgorCSAqLwogCXN0 cnVjdCBkZXZpY2UgKmRldjsKIAorCS8qKgorCSAqIEBmdW5jczoKKwkgKgorCSAqIE9wZXJhdGlv bnMgdGhhdCBjYW4gYmUgcGVyZm9ybWVkIG9uIHRoZSBwYW5lbC4KKwkgKi8KIAljb25zdCBzdHJ1 Y3QgZHJtX3BhbmVsX2Z1bmNzICpmdW5jczsKIAorCS8qKgorCSAqIEBsaXN0OgorCSAqCisJICog UGFuZWwgZW50cnkgaW4gcmVnaXN0cnkuCisJICovCiAJc3RydWN0IGxpc3RfaGVhZCBsaXN0Owog fTsKIAotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896E1C19759 for ; Sun, 4 Aug 2019 20:19:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C8C420882 for ; Sun, 4 Aug 2019 20:19:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N7P2s0Er"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rwd7igj5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C8C420882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tOCEbCKLA3pA6TMVMRifLTIrP93Pc2eM4rNTRNXKgwQ=; b=N7P2s0ErqAdzha vLxkLKgT6/fV52lQIm74m3r/qeMTj9yWv5L3K69tfJUcFQ1bwRTJLMuu5skIHNOaAPhdlnioVKV25 OdpVW0QMVT0OJoZ5W4tH0Ih4hb+RFDm0bgEgM11HAXE9EKbVL2Gz1x0Ifriyfc5osgcC0L5REDXY0 2Kws1TU+DxBLEOEZ9yW5Zag7kyOQkTrCKEiXN91POjt0Ywc5wiAAPiGiqdNx2LxSbzWLLXro04/D/ V9hU/Ho5i6avKRSyZjG46Ck5R+eiSAsO8TLxluWmmSIgOF5SFJP6zxsstM3Kmeo0g4ktxhcegqOSr 4efnjFqiouA5G8LsmrMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huMyJ-0002h0-0K; Sun, 04 Aug 2019 20:19:15 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huMwi-0000Su-G6 for linux-arm-kernel@lists.infradead.org; Sun, 04 Aug 2019 20:17:38 +0000 Received: by mail-lj1-x243.google.com with SMTP id h10so5976226ljg.0 for ; Sun, 04 Aug 2019 13:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TFw8aj8TVKqYV1qdWp7H7PSv0EjnAL5XrV9yT7wyYzI=; b=rwd7igj5BUr8/KxH5fDWHXDr9Bb3jwowv9EXwDKoBAF6i6RKSOD2641bxv40d1HHKN 90PRk5+MErpunsqUa+ibcmpfyC1UfMifTvwajUbZ8ZqHuCMYFJKBBAjwFBo2W68OzUai G53Jvo1D5DDJzo+gKXvmakpxb/DH5/PhMw8aEahnixPu/po32d3aI+NDSSadM47kTbM/ lqjP4OcW0y9Bk1NfPNwspN6J3RHQ7WY7F72jJQW2++3tGl6ZnUz3D5o0HtacBnaewCu6 3kXeiK7YR5BoUUssAQyLfTo21VXL0dOrPgDks3dsZ86AAQ5AoD6rN4Cu2hcIz7NKG/Ie NLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TFw8aj8TVKqYV1qdWp7H7PSv0EjnAL5XrV9yT7wyYzI=; b=UqrsFAeESzIw+bYItxQJcNtVJ6wI7LKOJHKXeHArUrAcPglF65gnOwxolV8mpcLZKR gxLyRESz9OyOoNS8/aTMGye/I/gPiLF7bcH3Z9o85QBH5IcwsBaA5datsV7IRg/1HtpS wzA15tuW7zzq8zvXD6pikgJD75IPh44sqzCtM84dvPxmhLyjimRt2OMb3aK15Z4/gGEM mqMtk0GgaaKsmTkWzLmUltRuTQfObD8fAVBoFq69aBqD46FBw02/ehorauy3jTZ/ODU9 n3PH3NGZ+FkoG5b03W7U6rXtei9X5/8vQeELatzLE3K5anbTGrDVjlqdsFqmaNkoIng4 4pjA== X-Gm-Message-State: APjAAAXrguYqg3/S9KlmPe1mIr7ChNur8OubIjIHEzm0GE1E/6xdsD5z FZYEZsvwACK/xp2669GsKZg= X-Google-Smtp-Source: APXvYqyoAufw1JJb+gisc/+GrH+nZNn6Oe74hLjpr94kfXr5VFnqYqHplX0Q3NQsQ1CxOz1UwLnarA== X-Received: by 2002:a2e:b0ea:: with SMTP id h10mr31006790ljl.50.1564949855034; Sun, 04 Aug 2019 13:17:35 -0700 (PDT) Received: from saturn.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id p87sm16540794ljp.50.2019.08.04.13.17.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 04 Aug 2019 13:17:34 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Thierry Reding Subject: [PATCH v1 12/16] drm/panel: use inline comments in drm_panel.h Date: Sun, 4 Aug 2019 22:16:33 +0200 Message-Id: <20190804201637.1240-13-sam@ravnborg.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190804201637.1240-1-sam@ravnborg.org> References: <20190804201637.1240-1-sam@ravnborg.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190804_131736_566979_0BEE2071 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , Stefan Agner , Andrzej Hajda , Laurent Pinchart , Benjamin Gaignard , Fabio Estevam , Marek Vasut , Laurent Pinchart , Joonyoung Shim , Sam Ravnborg , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , Allison Randal , Philipp Zabel , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Sascha Hauer , Alison Wang , Maarten Lankhorst , Gwan-gyeong Mun , Inki Dae , Alexios Zavras , linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Shawn Guo , Seung-Woo Kim , Vincent Abriou , Kyungmin Park , Daniel Vetter , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Inline comments provide better space for additional comments. Comments was slightly edited to follow the normal style, but no change to actual content. Used the opportuniy to change the order in drm_panel_funcs to follow the order they will be used by a panel. Signed-off-by: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter --- include/drm/drm_panel.h | 82 +++++++++++++++++++++++++++++++++-------- 1 file changed, 66 insertions(+), 16 deletions(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 053d611656b9..5e62deea49ba 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -36,14 +36,6 @@ struct display_timing; /** * struct drm_panel_funcs - perform operations on a given panel - * @disable: disable panel (turn off back light, etc.) - * @unprepare: turn off panel - * @prepare: turn on panel and perform set up - * @enable: enable panel (turn on back light, etc.) - * @get_modes: add modes to the connector that the panel is attached to and - * return the number of modes added - * @get_timings: copy display timings into the provided array and return - * the number of display timings available * * The .prepare() function is typically called before the display controller * starts to transmit video data. Panel drivers can use this to turn the panel @@ -69,31 +61,89 @@ struct display_timing; * the panel. This is the job of the .unprepare() function. */ struct drm_panel_funcs { - int (*disable)(struct drm_panel *panel); - int (*unprepare)(struct drm_panel *panel); + /** + * @prepare: + * + * Turn on panel and perform set up. + */ int (*prepare)(struct drm_panel *panel); + + /** + * @enable: + * + * Enable panel (turn on back light, etc.). + */ int (*enable)(struct drm_panel *panel); + + /** + * @disable: + * + * Disable panel (turn off back light, etc.). + */ + int (*disable)(struct drm_panel *panel); + + /** + * @unprepare: + * + * Turn off panel. + */ + int (*unprepare)(struct drm_panel *panel); + + /** + * @get_modes: + * + * Add modes to the connector that the panel is attached to and + * return the number of modes added. + */ int (*get_modes)(struct drm_panel *panel); + + /** + * @get_timings: + * + * Copy display timings into the provided array and return + * the number of display timings available. + */ int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, struct display_timing *timings); }; /** * struct drm_panel - DRM panel object - * @drm: DRM device owning the panel - * @connector: DRM connector that the panel is attached to - * @dev: parent device of the panel - * @link: link from panel device (supplier) to DRM device (consumer) - * @funcs: operations that can be performed on the panel - * @list: panel entry in registry */ struct drm_panel { + /** + * @drm: + * + * DRM device owning the panel. + */ struct drm_device *drm; + + /** + * @connector: + * + * DRM connector that the panel is attached to. + */ struct drm_connector *connector; + + /** + * @dev: + * + * Parent device of the panel. + */ struct device *dev; + /** + * @funcs: + * + * Operations that can be performed on the panel. + */ const struct drm_panel_funcs *funcs; + /** + * @list: + * + * Panel entry in registry. + */ struct list_head list; }; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel