From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: [PATCH v1 16/16] drm/panel: simple: use drm_panel infrastructure Date: Sun, 4 Aug 2019 22:16:37 +0200 Message-ID: <20190804201637.1240-17-sam@ravnborg.org> References: <20190804201637.1240-1-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190804201637.1240-1-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, Thierry Reding Cc: Neil Armstrong , David Airlie , Laurent Pinchart , Marek Vasut , Laurent Pinchart , Sam Ravnborg , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , Allison Randal , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Alison Wang , Gwan-gyeong Mun , Alexios Zavras , linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , linux-arm-kernel@lists.infradead.org, Jernej Skrabec List-Id: linux-samsung-soc@vger.kernel.org VXNlIGRybV9wYW5lbCBpbmZyYXN0cnVjdXRlOgotIGRybV9wYW5lbCBoYXMgZ3VhcmRzIGZvciBj YWxsaW5nIGRpc2FibGUvZW5hYmxlIHR3aWNlCi0gZHJtX3BhbmVsIGhhcyBiYWNrbGlnaHQgc3Vw cG9ydAoKVG8gdXNlIHRoZSBkcm1fcGFuZWwgaW5mcmFzdHJ1Y3R1cmUgdXNlIHRoZSBkcm1fcGFu ZWxfKgp2YXJpYW50cyBmb3IgcHJlcGFyZS9lbmFibGUvZGlzYWJsZS91bnByZXBhcmUuCgpTaWdu ZWQtb2ZmLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+CkNjOiBUaGllcnJ5IFJl ZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgpDYzogU2FtIFJhdm5ib3JnIDxzYW1AcmF2 bmJvcmcub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyB8IDcz ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRp b25zKCspLCA2MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFu ZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMK aW5kZXggYmZmNzU3OGY4NGRkLi5jN2VlZDM0ZjJjOWMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFu ZWwtc2ltcGxlLmMKQEAgLTIxLDcgKzIxLDYgQEAKICAqIERFQUxJTkdTIElOIFRIRSBTT0ZUV0FS RS4KICAqLwogCi0jaW5jbHVkZSA8bGludXgvYmFja2xpZ2h0Lmg+CiAjaW5jbHVkZSA8bGludXgv ZGVsYXkuaD4KICNpbmNsdWRlIDxsaW51eC9ncGlvL2NvbnN1bWVyLmg+CiAjaW5jbHVkZSA8bGlu dXgvbW9kdWxlLmg+CkBAIC05OCwxMyArOTcsMTAgQEAgc3RydWN0IHBhbmVsX2Rlc2MgewogCiBz dHJ1Y3QgcGFuZWxfc2ltcGxlIHsKIAlzdHJ1Y3QgZHJtX3BhbmVsIGJhc2U7Ci0JYm9vbCBwcmVw YXJlZDsKLQlib29sIGVuYWJsZWQ7CiAJYm9vbCBub19ocGQ7CiAKIAljb25zdCBzdHJ1Y3QgcGFu ZWxfZGVzYyAqZGVzYzsKIAotCXN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpiYWNrbGlnaHQ7CiAJ c3RydWN0IHJlZ3VsYXRvciAqc3VwcGx5OwogCXN0cnVjdCBpMmNfYWRhcHRlciAqZGRjOwogCkBA IC0yMzIsMjAgKzIyOCw5IEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX2Rpc2FibGUoc3RydWN0 IGRybV9wYW5lbCAqcGFuZWwpCiB7CiAJc3RydWN0IHBhbmVsX3NpbXBsZSAqcCA9IHRvX3BhbmVs X3NpbXBsZShwYW5lbCk7CiAKLQlpZiAoIXAtPmVuYWJsZWQpCi0JCXJldHVybiAwOwotCi0JaWYg KHAtPmJhY2tsaWdodCkgewotCQlwLT5iYWNrbGlnaHQtPnByb3BzLnBvd2VyID0gRkJfQkxBTktf UE9XRVJET1dOOwotCQlwLT5iYWNrbGlnaHQtPnByb3BzLnN0YXRlIHw9IEJMX0NPUkVfRkJCTEFO SzsKLQkJYmFja2xpZ2h0X3VwZGF0ZV9zdGF0dXMocC0+YmFja2xpZ2h0KTsKLQl9Ci0KIAlpZiAo cC0+ZGVzYy0+ZGVsYXkuZGlzYWJsZSkKIAkJbXNsZWVwKHAtPmRlc2MtPmRlbGF5LmRpc2FibGUp OwogCi0JcC0+ZW5hYmxlZCA9IGZhbHNlOwotCiAJcmV0dXJuIDA7CiB9CiAKQEAgLTI1Myw5ICsy MzgsNiBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV91bnByZXBhcmUoc3RydWN0IGRybV9wYW5l bCAqcGFuZWwpCiB7CiAJc3RydWN0IHBhbmVsX3NpbXBsZSAqcCA9IHRvX3BhbmVsX3NpbXBsZShw YW5lbCk7CiAKLQlpZiAoIXAtPnByZXBhcmVkKQotCQlyZXR1cm4gMDsKLQogCWdwaW9kX3NldF92 YWx1ZV9jYW5zbGVlcChwLT5lbmFibGVfZ3BpbywgMCk7CiAKIAlyZWd1bGF0b3JfZGlzYWJsZShw LT5zdXBwbHkpOwpAQCAtMjYzLDggKzI0NSw2IEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX3Vu cHJlcGFyZShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKIAlpZiAocC0+ZGVzYy0+ZGVsYXkudW5w cmVwYXJlKQogCQltc2xlZXAocC0+ZGVzYy0+ZGVsYXkudW5wcmVwYXJlKTsKIAotCXAtPnByZXBh cmVkID0gZmFsc2U7Ci0KIAlyZXR1cm4gMDsKIH0KIApAQCAtMjc0LDkgKzI1NCw2IEBAIHN0YXRp YyBpbnQgcGFuZWxfc2ltcGxlX3ByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCiAJdW5z aWduZWQgaW50IGRlbGF5OwogCWludCBlcnI7CiAKLQlpZiAocC0+cHJlcGFyZWQpCi0JCXJldHVy biAwOwotCiAJZXJyID0gcmVndWxhdG9yX2VuYWJsZShwLT5zdXBwbHkpOwogCWlmIChlcnIgPCAw KSB7CiAJCWRldl9lcnIocGFuZWwtPmRldiwgImZhaWxlZCB0byBlbmFibGUgc3VwcGx5OiAlZFxu IiwgZXJyKTsKQEAgLTI5MSw4ICsyNjgsNiBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9wcmVw YXJlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQogCWlmIChkZWxheSkKIAkJbXNsZWVwKGRlbGF5 KTsKIAotCXAtPnByZXBhcmVkID0gdHJ1ZTsKLQogCXJldHVybiAwOwogfQogCkBAIC0zMDAsMjAg KzI3NSw5IEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX2VuYWJsZShzdHJ1Y3QgZHJtX3BhbmVs ICpwYW5lbCkKIHsKIAlzdHJ1Y3QgcGFuZWxfc2ltcGxlICpwID0gdG9fcGFuZWxfc2ltcGxlKHBh bmVsKTsKIAotCWlmIChwLT5lbmFibGVkKQotCQlyZXR1cm4gMDsKLQogCWlmIChwLT5kZXNjLT5k ZWxheS5lbmFibGUpCiAJCW1zbGVlcChwLT5kZXNjLT5kZWxheS5lbmFibGUpOwogCi0JaWYgKHAt PmJhY2tsaWdodCkgewotCQlwLT5iYWNrbGlnaHQtPnByb3BzLnN0YXRlICY9IH5CTF9DT1JFX0ZC QkxBTks7Ci0JCXAtPmJhY2tsaWdodC0+cHJvcHMucG93ZXIgPSBGQl9CTEFOS19VTkJMQU5LOwot CQliYWNrbGlnaHRfdXBkYXRlX3N0YXR1cyhwLT5iYWNrbGlnaHQpOwotCX0KLQotCXAtPmVuYWJs ZWQgPSB0cnVlOwotCiAJcmV0dXJuIDA7CiB9CiAKQEAgLTQxMyw3ICszNzcsNyBAQCBzdGF0aWMg dm9pZCBwYW5lbF9zaW1wbGVfcGFyc2VfcGFuZWxfdGltaW5nX25vZGUoc3RydWN0IGRldmljZSAq ZGV2LAogCiBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYs IGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjICpkZXNjKQogewotCXN0cnVjdCBkZXZpY2Vfbm9kZSAq YmFja2xpZ2h0LCAqZGRjOworCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZGRjOwogCXN0cnVjdCBwYW5l bF9zaW1wbGUgKnBhbmVsOwogCXN0cnVjdCBkaXNwbGF5X3RpbWluZyBkdDsKIAlpbnQgZXJyOwpA QCAtNDIyLDggKzM4Niw2IEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX3Byb2JlKHN0cnVjdCBk ZXZpY2UgKmRldiwgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgKmRlc2MpCiAJaWYgKCFwYW5lbCkK IAkJcmV0dXJuIC1FTk9NRU07CiAKLQlwYW5lbC0+ZW5hYmxlZCA9IGZhbHNlOwotCXBhbmVsLT5w cmVwYXJlZCA9IGZhbHNlOwogCXBhbmVsLT5kZXNjID0gZGVzYzsKIAogCXBhbmVsLT5ub19ocGQg PSBvZl9wcm9wZXJ0eV9yZWFkX2Jvb2woZGV2LT5vZl9ub2RlLCAibm8taHBkIik7CkBAIC00NDEs MjQgKzQwMywxMyBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9wcm9iZShzdHJ1Y3QgZGV2aWNl ICpkZXYsIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjICpkZXNjKQogCQlyZXR1cm4gZXJyOwogCX0K IAotCWJhY2tsaWdodCA9IG9mX3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiYmFja2xpZ2h0 IiwgMCk7Ci0JaWYgKGJhY2tsaWdodCkgewotCQlwYW5lbC0+YmFja2xpZ2h0ID0gb2ZfZmluZF9i YWNrbGlnaHRfYnlfbm9kZShiYWNrbGlnaHQpOwotCQlvZl9ub2RlX3B1dChiYWNrbGlnaHQpOwot Ci0JCWlmICghcGFuZWwtPmJhY2tsaWdodCkKLQkJCXJldHVybiAtRVBST0JFX0RFRkVSOwotCX0K LQogCWRkYyA9IG9mX3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiZGRjLWkyYy1idXMiLCAw KTsKIAlpZiAoZGRjKSB7CiAJCXBhbmVsLT5kZGMgPSBvZl9maW5kX2kyY19hZGFwdGVyX2J5X25v ZGUoZGRjKTsKIAkJb2Zfbm9kZV9wdXQoZGRjKTsKIAotCQlpZiAoIXBhbmVsLT5kZGMpIHsKLQkJ CWVyciA9IC1FUFJPQkVfREVGRVI7Ci0JCQlnb3RvIGZyZWVfYmFja2xpZ2h0OwotCQl9CisJCWlm ICghcGFuZWwtPmRkYykKKwkJCXJldHVybiAtRVBST0JFX0RFRkVSOwogCX0KIAogCWlmICghb2Zf Z2V0X2Rpc3BsYXlfdGltaW5nKGRldi0+b2Zfbm9kZSwgInBhbmVsLXRpbWluZyIsICZkdCkpCkBA IC00NjgsNiArNDE5LDEwIEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX3Byb2JlKHN0cnVjdCBk ZXZpY2UgKmRldiwgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgKmRlc2MpCiAJcGFuZWwtPmJhc2Uu ZGV2ID0gZGV2OwogCXBhbmVsLT5iYXNlLmZ1bmNzID0gJnBhbmVsX3NpbXBsZV9mdW5jczsKIAor CWVyciA9IGRybV9wYW5lbF9vZl9iYWNrbGlnaHQoJnBhbmVsLT5iYXNlKTsKKwlpZiAoZXJyKQor CQlnb3RvIGZyZWVfZGRjOworCiAJZXJyID0gZHJtX3BhbmVsX2FkZCgmcGFuZWwtPmJhc2UpOwog CWlmIChlcnIgPCAwKQogCQlnb3RvIGZyZWVfZGRjOwpAQCAtNDc5LDkgKzQzNCw2IEBAIHN0YXRp YyBpbnQgcGFuZWxfc2ltcGxlX3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgY29uc3Qgc3RydWN0 IHBhbmVsX2Rlc2MgKmRlc2MpCiBmcmVlX2RkYzoKIAlpZiAocGFuZWwtPmRkYykKIAkJcHV0X2Rl dmljZSgmcGFuZWwtPmRkYy0+ZGV2KTsKLWZyZWVfYmFja2xpZ2h0OgotCWlmIChwYW5lbC0+YmFj a2xpZ2h0KQotCQlwdXRfZGV2aWNlKCZwYW5lbC0+YmFja2xpZ2h0LT5kZXYpOwogCiAJcmV0dXJu IGVycjsKIH0KQEAgLTQ5MiwxNSArNDQ0LDEyIEBAIHN0YXRpYyBpbnQgcGFuZWxfc2ltcGxlX3Jl bW92ZShzdHJ1Y3QgZGV2aWNlICpkZXYpCiAKIAlkcm1fcGFuZWxfcmVtb3ZlKCZwYW5lbC0+YmFz ZSk7CiAKLQlwYW5lbF9zaW1wbGVfZGlzYWJsZSgmcGFuZWwtPmJhc2UpOwotCXBhbmVsX3NpbXBs ZV91bnByZXBhcmUoJnBhbmVsLT5iYXNlKTsKKwlkcm1fcGFuZWxfZGlzYWJsZSgmcGFuZWwtPmJh c2UpOworCWRybV9wYW5lbF91bnByZXBhcmUoJnBhbmVsLT5iYXNlKTsKIAogCWlmIChwYW5lbC0+ ZGRjKQogCQlwdXRfZGV2aWNlKCZwYW5lbC0+ZGRjLT5kZXYpOwogCi0JaWYgKHBhbmVsLT5iYWNr bGlnaHQpCi0JCXB1dF9kZXZpY2UoJnBhbmVsLT5iYWNrbGlnaHQtPmRldik7Ci0KIAlyZXR1cm4g MDsKIH0KIApAQCAtNTA4LDggKzQ1Nyw4IEBAIHN0YXRpYyB2b2lkIHBhbmVsX3NpbXBsZV9zaHV0 ZG93bihzdHJ1Y3QgZGV2aWNlICpkZXYpCiB7CiAJc3RydWN0IHBhbmVsX3NpbXBsZSAqcGFuZWwg PSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKIAotCXBhbmVsX3NpbXBsZV9kaXNhYmxlKCZwYW5lbC0+ YmFzZSk7Ci0JcGFuZWxfc2ltcGxlX3VucHJlcGFyZSgmcGFuZWwtPmJhc2UpOworCWRybV9wYW5l bF9kaXNhYmxlKCZwYW5lbC0+YmFzZSk7CisJZHJtX3BhbmVsX3VucHJlcGFyZSgmcGFuZWwtPmJh c2UpOwogfQogCiBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgYW1waXJlX2Ft XzQ4MDI3MmgzdG1xd190MDFoX21vZGUgPSB7Ci0tIAoyLjIwLjEKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6538BC433FF for ; Sun, 4 Aug 2019 20:20:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 332DA20882 for ; Sun, 4 Aug 2019 20:20:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lGkfoqPS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iWaSTn6m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 332DA20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mgXLdr633YOJxH6jU9yukfO0JOwkt6g+oJEFNnSfDQ0=; b=lGkfoqPSH89iLJ OvELLk0PqzBI1EiX6NQKAFg870JNxP11kSdqVSZhu0bU9gPElOtiXMLKT3ULCWPmhLzwqEXWWaklC axPa6eqvPHa0gmoO69Ln95IcPBcmSKjhyjq5RCsZ7tQa0qbW2GFFs+8Qi5+hNNYu2+QVPJjPvGWAf zeRKqq31AbUs+2BKfdD4RqqEOaTtuoeqjPy71Feghw9jCgsNr1wwQaclvZJslxsJ04LATEIF6RWKB BBYqpQru15/VeQvoxsuLpBhl+hHJBp1QfZ4jaOtgvv6IujIyKMLdZA8nzB5zRgV6OY51iEfL/zz79 GgyF/ub5ooXhpXex4egQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huMz9-0003xc-4k; Sun, 04 Aug 2019 20:20:07 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huMwt-0000gN-LQ for linux-arm-kernel@lists.infradead.org; Sun, 04 Aug 2019 20:17:50 +0000 Received: by mail-lj1-x244.google.com with SMTP id m23so77345833lje.12 for ; Sun, 04 Aug 2019 13:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=58L2c6AoPRdtw97mukFPxD0pdo2vv2X7JQRJbq8/vUE=; b=iWaSTn6msFtanMS3ltawVoyI/akm3SIk334RyboYedy/nyCR1hjYvRVV5qxkjjz0/H HqXXvHotINKZ0MV5HIpyWLnyZtxGL/1hGgmFIEEI7UdhvUfg75bpnhgOJWt5N8zKgrdm iOXfl/+wIB5SpvjXO1jqzazjXb4JocnXkPI+PCSJkpOFvrS+MIjtXrKGdq9eXuHzZGgb +cj5IV6oh60Itbyl7Tn5K5BhmHxd4/gcjJnW0V2KehXKtOWe4oIYhKGzrUlEdTmqAkt/ 88lPYDyYgqhmfZxkZeRgCPjyUrPVFHA+tyGQMdVbBGoApF+gML1pHYItNM5NHOyvti76 MsBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=58L2c6AoPRdtw97mukFPxD0pdo2vv2X7JQRJbq8/vUE=; b=QghldFNTnoMKo632KJ3mebor1kEfDnmYAzVZdSMDaQqdKt2kidCt3mDAGy6+ATDLoV gYfbEQxcbRV6Arjuw4kD+0wSSN8eqkPy+2JT/XM66SI1H4gEn8NcOogJN6cd9iaCJZOD su6Gugex8sDA+2pJmnxXD6q7p6o6sCX3PpcAArB39ySpX/rw37a/b5/QSfJSK0rIxZrI gxSfMbpOBlgs5wMjg8QmTKTiLPd8xyEzqwB49KPzmfDs7X7iyP2Ml2Yt1FRHiofkvF5Y 956VdioaEhcKKpFcuYhjKlw+aI04TqlfmGeETK5FVrvntrbZ9+zn0h6KEW4z6OtWO3ts ZS3Q== X-Gm-Message-State: APjAAAVj5ukH9jUfZgLO27S5oeR8PW+/ahvbxvsuaJxUoV0zi4aoxhrF GQnygaumycRJm5kH3QWkilI= X-Google-Smtp-Source: APXvYqwd3qng5VMg9Mb2Vmyn/6Orka9Dj+RSr/HOVzJm2eC00ZYEFloJNhEpBCBt7pNnr0htBnzZ8A== X-Received: by 2002:a2e:834e:: with SMTP id l14mr30558098ljh.158.1564949866148; Sun, 04 Aug 2019 13:17:46 -0700 (PDT) Received: from saturn.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id p87sm16540794ljp.50.2019.08.04.13.17.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 04 Aug 2019 13:17:45 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Thierry Reding Subject: [PATCH v1 16/16] drm/panel: simple: use drm_panel infrastructure Date: Sun, 4 Aug 2019 22:16:37 +0200 Message-Id: <20190804201637.1240-17-sam@ravnborg.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190804201637.1240-1-sam@ravnborg.org> References: <20190804201637.1240-1-sam@ravnborg.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190804_131747_865422_2B346539 X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , Stefan Agner , Andrzej Hajda , Laurent Pinchart , Benjamin Gaignard , Fabio Estevam , Marek Vasut , Laurent Pinchart , Joonyoung Shim , Sam Ravnborg , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , Allison Randal , Philipp Zabel , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Sascha Hauer , Alison Wang , Maarten Lankhorst , Gwan-gyeong Mun , Inki Dae , Alexios Zavras , linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Shawn Guo , Seung-Woo Kim , Vincent Abriou , Kyungmin Park , Daniel Vetter , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use drm_panel infrastrucute: - drm_panel has guards for calling disable/enable twice - drm_panel has backlight support To use the drm_panel infrastructure use the drm_panel_* variants for prepare/enable/disable/unprepare. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 73 +++++----------------------- 1 file changed, 11 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index bff7578f84dd..c7eed34f2c9c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -21,7 +21,6 @@ * DEALINGS IN THE SOFTWARE. */ -#include #include #include #include @@ -98,13 +97,10 @@ struct panel_desc { struct panel_simple { struct drm_panel base; - bool prepared; - bool enabled; bool no_hpd; const struct panel_desc *desc; - struct backlight_device *backlight; struct regulator *supply; struct i2c_adapter *ddc; @@ -232,20 +228,9 @@ static int panel_simple_disable(struct drm_panel *panel) { struct panel_simple *p = to_panel_simple(panel); - if (!p->enabled) - return 0; - - if (p->backlight) { - p->backlight->props.power = FB_BLANK_POWERDOWN; - p->backlight->props.state |= BL_CORE_FBBLANK; - backlight_update_status(p->backlight); - } - if (p->desc->delay.disable) msleep(p->desc->delay.disable); - p->enabled = false; - return 0; } @@ -253,9 +238,6 @@ static int panel_simple_unprepare(struct drm_panel *panel) { struct panel_simple *p = to_panel_simple(panel); - if (!p->prepared) - return 0; - gpiod_set_value_cansleep(p->enable_gpio, 0); regulator_disable(p->supply); @@ -263,8 +245,6 @@ static int panel_simple_unprepare(struct drm_panel *panel) if (p->desc->delay.unprepare) msleep(p->desc->delay.unprepare); - p->prepared = false; - return 0; } @@ -274,9 +254,6 @@ static int panel_simple_prepare(struct drm_panel *panel) unsigned int delay; int err; - if (p->prepared) - return 0; - err = regulator_enable(p->supply); if (err < 0) { dev_err(panel->dev, "failed to enable supply: %d\n", err); @@ -291,8 +268,6 @@ static int panel_simple_prepare(struct drm_panel *panel) if (delay) msleep(delay); - p->prepared = true; - return 0; } @@ -300,20 +275,9 @@ static int panel_simple_enable(struct drm_panel *panel) { struct panel_simple *p = to_panel_simple(panel); - if (p->enabled) - return 0; - if (p->desc->delay.enable) msleep(p->desc->delay.enable); - if (p->backlight) { - p->backlight->props.state &= ~BL_CORE_FBBLANK; - p->backlight->props.power = FB_BLANK_UNBLANK; - backlight_update_status(p->backlight); - } - - p->enabled = true; - return 0; } @@ -413,7 +377,7 @@ static void panel_simple_parse_panel_timing_node(struct device *dev, static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) { - struct device_node *backlight, *ddc; + struct device_node *ddc; struct panel_simple *panel; struct display_timing dt; int err; @@ -422,8 +386,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) if (!panel) return -ENOMEM; - panel->enabled = false; - panel->prepared = false; panel->desc = desc; panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd"); @@ -441,24 +403,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) return err; } - backlight = of_parse_phandle(dev->of_node, "backlight", 0); - if (backlight) { - panel->backlight = of_find_backlight_by_node(backlight); - of_node_put(backlight); - - if (!panel->backlight) - return -EPROBE_DEFER; - } - ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0); if (ddc) { panel->ddc = of_find_i2c_adapter_by_node(ddc); of_node_put(ddc); - if (!panel->ddc) { - err = -EPROBE_DEFER; - goto free_backlight; - } + if (!panel->ddc) + return -EPROBE_DEFER; } if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) @@ -468,6 +419,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) panel->base.dev = dev; panel->base.funcs = &panel_simple_funcs; + err = drm_panel_of_backlight(&panel->base); + if (err) + goto free_ddc; + err = drm_panel_add(&panel->base); if (err < 0) goto free_ddc; @@ -479,9 +434,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) free_ddc: if (panel->ddc) put_device(&panel->ddc->dev); -free_backlight: - if (panel->backlight) - put_device(&panel->backlight->dev); return err; } @@ -492,15 +444,12 @@ static int panel_simple_remove(struct device *dev) drm_panel_remove(&panel->base); - panel_simple_disable(&panel->base); - panel_simple_unprepare(&panel->base); + drm_panel_disable(&panel->base); + drm_panel_unprepare(&panel->base); if (panel->ddc) put_device(&panel->ddc->dev); - if (panel->backlight) - put_device(&panel->backlight->dev); - return 0; } @@ -508,8 +457,8 @@ static void panel_simple_shutdown(struct device *dev) { struct panel_simple *panel = dev_get_drvdata(dev); - panel_simple_disable(&panel->base); - panel_simple_unprepare(&panel->base); + drm_panel_disable(&panel->base); + drm_panel_unprepare(&panel->base); } static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel