From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] raw/ntb: fix null pointer dereference
Date: Mon, 5 Aug 2019 13:50:41 +0800 [thread overview]
Message-ID: <20190805055041.GF51603@intel.com> (raw)
In-Reply-To: <20190805050247.28624-1-xiaoyun.li@intel.com>
On 08/05, Xiaoyun Li wrote:
>This patch fixes null pointer dereference issues found by coverity scan.
>
>Coverity issue: 344981, 344991, 345000, 345002, 345006, 345024
>Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver")
>Cc: stable@dpdk.org
>
>Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>---
> drivers/raw/ntb/ntb.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
>index 4ba2f3a38..bfecce1e4 100644
>--- a/drivers/raw/ntb/ntb.c
>+++ b/drivers/raw/ntb/ntb.c
>@@ -447,14 +447,16 @@ static int
> ntb_attr_set(struct rte_rawdev *dev, const char *attr_name,
> uint64_t attr_value)
> {
>- struct ntb_hw *hw = dev->dev_private;
>- int index = 0;
>+ struct ntb_hw *hw;
>+ int index;
>
> if (dev == NULL || attr_name == NULL) {
> NTB_LOG(ERR, "Invalid arguments for setting attributes");
> return -EINVAL;
> }
>
>+ hw = dev->dev_private;
>+
> if (!strncmp(attr_name, NTB_SPAD_USER, NTB_SPAD_USER_LEN)) {
> if (hw->ntb_ops->spad_write == NULL)
> return -ENOTSUP;
>@@ -475,14 +477,16 @@ static int
> ntb_attr_get(struct rte_rawdev *dev, const char *attr_name,
> uint64_t *attr_value)
> {
>- struct ntb_hw *hw = dev->dev_private;
>- int index = 0;
>+ struct ntb_hw *hw;
>+ int index;
>
> if (dev == NULL || attr_name == NULL || attr_value == NULL) {
> NTB_LOG(ERR, "Invalid arguments for getting attributes");
> return -EINVAL;
> }
>
>+ hw = dev->dev_private;
>+
> if (!strncmp(attr_name, NTB_TOPO_NAME, NTB_ATTR_NAME_LEN)) {
> *attr_value = hw->topo;
> NTB_LOG(INFO, "Attribute (%s) Value (%" PRIu64 ")",
>@@ -735,7 +739,7 @@ ntb_create(struct rte_pci_device *pci_dev, int socket_id)
>
> if (pci_dev == NULL) {
> NTB_LOG(ERR, "Invalid pci_dev.");
>- ret = -EINVAL;
>+ return -EINVAL;
> }
>
> memset(name, 0, sizeof(name));
>@@ -750,7 +754,7 @@ ntb_create(struct rte_pci_device *pci_dev, int socket_id)
> socket_id);
> if (rawdev == NULL) {
> NTB_LOG(ERR, "Unable to allocate rawdev.");
>- ret = -EINVAL;
>+ return -EINVAL;
> }
>
> rawdev->dev_ops = &ntb_ops;
>@@ -766,7 +770,7 @@ ntb_create(struct rte_pci_device *pci_dev, int socket_id)
> return ret;
>
> fail:
>- if (rawdev)
>+ if (rawdev != NULL)
> rte_rawdev_pmd_release(rawdev);
>
> return ret;
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2019-08-05 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 5:02 [dpdk-dev] [PATCH] raw/ntb: fix null pointer dereference Xiaoyun Li
2019-08-05 5:50 ` Ye Xiaolong [this message]
2019-08-06 7:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805055041.GF51603@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.