Re: [dpdk-dev] [PATCH] examples/ntb: fix error handling

[Ye Xiaolong <xiaolong.ye@intel.com>]

On 08/05, Xiaoyun Li wrote:
>This patch adds return value checking for fseek function to fix
>error handling issue found by coverity scan.
>
>Coverity issue: 344996
>Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
>Cc: stable@dpdk.org
>
>Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>---
> examples/ntb/ntb_fwd.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
>index c169f01a3..671b13f50 100644
>--- a/examples/ntb/ntb_fwd.c
>+++ b/examples/ntb/ntb_fwd.c
>@@ -107,6 +107,7 @@ cmd_sendfile_parsed(void *parsed_result,
> 	uint8_t *buff;
> 	uint32_t val;
> 	FILE *file;
>+	int status;
> 
> 	if (!rte_rawdevs[dev_id].started) {
> 		printf("Device needs to be up first. Try later.\n");
>@@ -125,9 +126,17 @@ cmd_sendfile_parsed(void *parsed_result,
> 		return;
> 	}
> 
>-	fseek(file, 0, SEEK_END);
>+	status = fseek(file, 0, SEEK_END);
>+	if (status) {

How about simplify to 

	if (fseek(file, 0, SEEK_END) < 0)

>+		printf("Fail to get file size.\n");
>+		return;
>+	}
> 	size = ftell(file);
>-	fseek(file, 0, SEEK_SET);
>+	status = fseek(file, 0, SEEK_SET);
>+	if (status) {

Ditto.

Thanks,
Xiaolong
>+		printf("Fail to get file size.\n");
>+		return;
>+	}
> 
> 	/**
> 	 * No FIFO now. Only test memory. Limit sending file
>-- 
>2.17.1
>