From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 5 Aug 2019 12:18:01 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20190805111801.GK13734@work-vm> References: <1564810108-34852-1-git-send-email-bo.liu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564810108-34852-1-git-send-email-bo.liu@linux.alibaba.com> Subject: Re: [Virtio-fs] [PATCH] Virtiofsd: fix segfault when quit before dev init List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Bo Cc: virtio-fs@redhat.com * Liu Bo (bo.liu@linux.alibaba.com) wrote: > From: Eric Ren > > The daemon may bail out early on errors(e.g. in fuse_session_mount), where > it ends up a segfault error. > > Signed-off-by: Eric Ren Reviewed-by: Dr. David Alan Gilbert Thanks, added to my world > --- > contrib/virtiofsd/fuse_virtio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > index aa94b66..6292e87 100644 > --- a/contrib/virtiofsd/fuse_virtio.c > +++ b/contrib/virtiofsd/fuse_virtio.c > @@ -891,6 +891,10 @@ int virtio_session_mount(struct fuse_session *se) > void virtio_session_close(struct fuse_session *se) > { > close(se->vu_socketfd); > + > + if (!se->virtio_dev) > + return; > + > free(se->virtio_dev->qi); > free(se->virtio_dev); > se->virtio_dev = NULL; > -- > 1.8.3.1 > > _______________________________________________ > Virtio-fs mailing list > Virtio-fs@redhat.com > https://www.redhat.com/mailman/listinfo/virtio-fs -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK