From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E525C41514 for ; Mon, 5 Aug 2019 12:16:22 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C67AC2086D for ; Mon, 5 Aug 2019 12:16:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67AC2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 22C794A554; Mon, 5 Aug 2019 08:16:21 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oeiy5JBQm5l1; Mon, 5 Aug 2019 08:16:20 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0381B4A53B; Mon, 5 Aug 2019 08:16:20 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B5ACC4A524 for ; Mon, 5 Aug 2019 08:16:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ukSBFmPcfin1 for ; Mon, 5 Aug 2019 08:16:17 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BBE004A4E6 for ; Mon, 5 Aug 2019 08:16:17 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 363CC337; Mon, 5 Aug 2019 05:16:17 -0700 (PDT) Received: from filthy-habits.cambridge.arm.com (filthy-habits.cambridge.arm.com [10.1.197.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EE773F706; Mon, 5 Aug 2019 05:16:15 -0700 (PDT) From: Marc Zyngier To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/2] KVM: arm/arm64: Revamp sysreg reset checks Date: Mon, 5 Aug 2019 13:15:53 +0100 Message-Id: <20190805121555.130897-1-maz@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu The way we deal with sysreg reset is terrible, as we write junk to them while other parts of the system may be evaluating these. That's obviously wrong. Instead, let's switch to a mode where we track which sysregs have had a reset function applied to them. The result is less bad, but my gut feeling is that we'd be better of without any of this. Comments welcome. Marc Zyngier (2): KVM: arm64: Don't write junk to sysregs on reset KVM: arm: Don't write junk to CP15 registers on reset arch/arm/kvm/coproc.c | 23 +++++++++++++++-------- arch/arm64/kvm/sys_regs.c | 32 ++++++++++++++++++-------------- 2 files changed, 33 insertions(+), 22 deletions(-) -- 2.20.1 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18488C32751 for ; Mon, 5 Aug 2019 12:16:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E450420B1F for ; Mon, 5 Aug 2019 12:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p3j9QFul" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E450420B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pRB2/bxDpCPDRj/iMsjLHQKBSGAmSj7rruCzNx/GWKo=; b=p3j9QFulX0X0ZD VNS5FDCB/XXhaaCr9x3T38UYJjETo9vl64BXtHOF0Dqckehx2808sCME/etyiOrOisQR7O/S7lFxk LG9GxAijHy8Eqj/3SR/QV8j9oRGKAnAKHnQGAOkQNuyxUp6anozlW3KtaRax2YYynBHCnmOl3KhCE s4hWqkyR7oZYs7CgyJMvD/YRx+vnMLmJxi/hkEKEmYaOwTbpncy7F+GV72Rgtrx/T73JmZ685lKGW MCuyoCs6CHcxK9fl7CPLjdj1Rn22waqYwkCS+Y69g5EaUiYKAc0Gccse1V8kshH4d5ctoJnpzcmS1 l3JasjZf4d+XhM2pnlYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hubuX-0003EP-6m; Mon, 05 Aug 2019 12:16:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hubuU-0003DK-D3 for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 12:16:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 363CC337; Mon, 5 Aug 2019 05:16:17 -0700 (PDT) Received: from filthy-habits.cambridge.arm.com (filthy-habits.cambridge.arm.com [10.1.197.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EE773F706; Mon, 5 Aug 2019 05:16:15 -0700 (PDT) From: Marc Zyngier To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/2] KVM: arm/arm64: Revamp sysreg reset checks Date: Mon, 5 Aug 2019 13:15:53 +0100 Message-Id: <20190805121555.130897-1-maz@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_051618_489988_1D4118CA X-CRM114-Status: UNSURE ( 7.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zenghui Yu , Andrew Jones , James Morse , Julien Thierry , Suzuki K Poulose Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The way we deal with sysreg reset is terrible, as we write junk to them while other parts of the system may be evaluating these. That's obviously wrong. Instead, let's switch to a mode where we track which sysregs have had a reset function applied to them. The result is less bad, but my gut feeling is that we'd be better of without any of this. Comments welcome. Marc Zyngier (2): KVM: arm64: Don't write junk to sysregs on reset KVM: arm: Don't write junk to CP15 registers on reset arch/arm/kvm/coproc.c | 23 +++++++++++++++-------- arch/arm64/kvm/sys_regs.c | 32 ++++++++++++++++++-------------- 2 files changed, 33 insertions(+), 22 deletions(-) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D476EC0650F for ; Mon, 5 Aug 2019 12:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A86DE2086D for ; Mon, 5 Aug 2019 12:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565007378; bh=ZIr6wVknYm1ngO7QRWL60OE0ie+Xp+PpydmPRclbC2c=; h=From:To:Cc:Subject:Date:List-ID:From; b=Uc8ZHi0DkZpSE1sx8Mz7deOwoM3ZMUpgEpV0VMgAIsqSp7fqV36FY1J8SdqlYsHJ8 JmZN22qzn/p+I7g6KROx7oGK/zDs5E5BE5Fv/gDOVu9yMq2LIB6rt8kkIX0jnyg2N7 3MeUqI9upJuZDv2KAQRBnWThoyirOtxOVbBwj+ZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728483AbfHEMQR (ORCPT ); Mon, 5 Aug 2019 08:16:17 -0400 Received: from foss.arm.com ([217.140.110.172]:47188 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727349AbfHEMQR (ORCPT ); Mon, 5 Aug 2019 08:16:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 363CC337; Mon, 5 Aug 2019 05:16:17 -0700 (PDT) Received: from filthy-habits.cambridge.arm.com (filthy-habits.cambridge.arm.com [10.1.197.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EE773F706; Mon, 5 Aug 2019 05:16:15 -0700 (PDT) From: Marc Zyngier To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Cc: Zenghui Yu , Andrew Jones , Suzuki K Poulose , James Morse , Julien Thierry Subject: [PATCH 0/2] KVM: arm/arm64: Revamp sysreg reset checks Date: Mon, 5 Aug 2019 13:15:53 +0100 Message-Id: <20190805121555.130897-1-maz@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org The way we deal with sysreg reset is terrible, as we write junk to them while other parts of the system may be evaluating these. That's obviously wrong. Instead, let's switch to a mode where we track which sysregs have had a reset function applied to them. The result is less bad, but my gut feeling is that we'd be better of without any of this. Comments welcome. Marc Zyngier (2): KVM: arm64: Don't write junk to sysregs on reset KVM: arm: Don't write junk to CP15 registers on reset arch/arm/kvm/coproc.c | 23 +++++++++++++++-------- arch/arm64/kvm/sys_regs.c | 32 ++++++++++++++++++-------------- 2 files changed, 33 insertions(+), 22 deletions(-) -- 2.20.1