From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: remove unnecessary PageReserved check
Date: Mon, 5 Aug 2019 08:05:51 -0700 [thread overview]
Message-ID: <20190805150551.GA29275@linux.intel.com> (raw)
In-Reply-To: <1564996902-22600-1-git-send-email-pbonzini@redhat.com>
On Mon, Aug 05, 2019 at 11:21:42AM +0200, Paolo Bonzini wrote:
> The same check is already done in kvm_is_reserved_pfn.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
This patch was effectively submitted in Nov 2018, but was buried at the
end of a DAX series. https://patchwork.kernel.org/patch/10886265/
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> virt/kvm/kvm_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 416969d9fefe..c5f1186f4b60 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1855,8 +1855,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn)
> if (!kvm_is_reserved_pfn(pfn)) {
> struct page *page = pfn_to_page(pfn);
>
> - if (!PageReserved(page))
> - SetPageDirty(page);
> + SetPageDirty(page);
> }
> }
> EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
> --
> 1.8.3.1
>
prev parent reply other threads:[~2019-08-05 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 9:21 [PATCH] kvm: remove unnecessary PageReserved check Paolo Bonzini
2019-08-05 15:05 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805150551.GA29275@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.