From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, davem@davemloft.net,
sthemmin@microsoft.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces
Date: Mon, 5 Aug 2019 17:20:19 +0200 [thread overview]
Message-ID: <20190805152019.GE2349@nanopsycho.orion> (raw)
In-Reply-To: <566cdf6c-dafc-fb3e-bd94-b75eba3488b5@gmail.com>
Mon, Aug 05, 2019 at 04:51:22PM CEST, dsahern@gmail.com wrote:
>On 8/5/19 8:49 AM, Jiri Pirko wrote:
>>> Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a
>>> per-namepace accounting to all namespaces managed by a single devlink
>>> instance in init_net - which is completely wrong.
>> No. Not "all namespaces". Only the one where the devlink is. And that is
>> always init_net, until this patchset.
>>
>>
>
>Jiri: your change to fib.c does not take into account namespace when
>doing rules and routes accounting. you broke it. fix it.
What do you mean by "account namespace"? It's a device resource, why to
tight it with namespace? What if you have 2 netdevsim-devlink instances
in one namespace? Why the setting should be per-namespace?
next prev parent reply other threads:[~2019-08-05 15:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 8:57 [patch net-next v2 0/3] net: devlink: Finish network namespace support Jiri Pirko
2019-07-30 8:57 ` [patch net-next v2 1/3] net: devlink: allow to change namespaces Jiri Pirko
2019-07-30 22:39 ` Jakub Kicinski
2019-07-31 19:26 ` Jiri Pirko
2019-07-31 19:41 ` David Ahern
2019-07-31 19:45 ` Jiri Pirko
2019-07-31 19:46 ` David Ahern
2019-07-31 19:58 ` David Ahern
2019-07-31 20:20 ` David Ahern
2019-08-02 7:48 ` Jiri Pirko
2019-08-02 15:45 ` David Ahern
2019-08-05 5:54 ` Jiri Pirko
2019-08-05 14:10 ` David Ahern
2019-08-05 14:49 ` Jiri Pirko
2019-08-05 14:51 ` David Ahern
2019-08-05 15:20 ` Jiri Pirko [this message]
2019-08-06 17:34 ` David Ahern
2019-08-06 17:53 ` Jiri Pirko
2019-08-06 17:55 ` David Ahern
2019-08-06 18:07 ` Jiri Pirko
2019-08-02 7:43 ` Jiri Pirko
2019-07-30 8:57 ` [patch net-next v2 2/3] net: devlink: export devlink net set/get helpers Jiri Pirko
2019-07-30 22:40 ` Jakub Kicinski
2019-07-30 8:57 ` [patch net-next v2 3/3] netdevsim: create devlink and netdev instances in namespace Jiri Pirko
2019-07-30 22:40 ` Jakub Kicinski
2019-07-30 8:59 ` [patch iproute2-next v2 1/2] devlink: introduce cmdline option to switch to a different namespace Jiri Pirko
2019-07-30 8:59 ` [patch iproute2-next v2 2/2] devlink: add support for network namespace change Jiri Pirko
2019-07-31 22:59 ` [patch net-next v2 0/3] net: devlink: Finish network namespace support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805152019.GE2349@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.