From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled Date: Mon, 5 Aug 2019 17:22:14 +0200 Message-ID: <20190805152214.GS24275@lunn.ch> References: <20190805165453.3989-1-alexandru.ardelean@analog.com> <20190805165453.3989-15-alexandru.ardelean@analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190805165453.3989-15-alexandru.ardelean@analog.com> Sender: netdev-owner@vger.kernel.org To: Alexandru Ardelean Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com, f.fainelli@gmail.com, hkallweit1@gmail.com List-Id: devicetree@vger.kernel.org On Mon, Aug 05, 2019 at 07:54:51PM +0300, Alexandru Ardelean wrote: > Down-speed auto-negotiation may not always be enabled, in which case the > PHY won't down-shift to 100 or 10 during auto-negotiation. Please look at how the marvell driver enables and configures this feature. Ideally we want all PHY drivers to use the same configuration API for features like this. Andrew