From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BFA0C433FF for ; Tue, 6 Aug 2019 13:10:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E84D720C01 for ; Tue, 6 Aug 2019 13:10:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E84D720C01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huzEj-0001qB-9u for qemu-devel@archiver.kernel.org; Tue, 06 Aug 2019 09:10:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53834) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huzEM-0001QV-41 for qemu-devel@nongnu.org; Tue, 06 Aug 2019 09:10:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huzEK-0005tg-MB for qemu-devel@nongnu.org; Tue, 06 Aug 2019 09:10:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1huzEK-0005tS-GW for qemu-devel@nongnu.org; Tue, 06 Aug 2019 09:10:20 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D770D7E428 for ; Tue, 6 Aug 2019 13:10:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.16.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DDD460127; Tue, 6 Aug 2019 13:10:19 +0000 (UTC) Date: Tue, 6 Aug 2019 14:10:17 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Message-ID: <20190806131017.GF14887@redhat.com> References: <1565075475-15313-1-git-send-email-pbonzini@redhat.com> <20190806094140.GB14887@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 06 Aug 2019 13:10:19 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] crypto: move common bits for all emulators to libqemuutil X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 06, 2019 at 03:07:40PM +0200, Paolo Bonzini wrote: > On 06/08/19 11:41, Daniel P. Berrang=C3=A9 wrote: > > On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote: > >> qcrypto_random_*, AES and qcrypto_init do not need to be linked as a= whole > >> and are the only parts that are used by user-mode emulation. Place = them > >> in libqemuutil, so that whatever needs them will pick them up automa= tically. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> MAINTAINERS | 3 +++ > >> Makefile | 4 +--- > >> Makefile.objs | 1 - > >> Makefile.target | 2 -- > >> crypto/Makefile.objs | 7 ------- > >> util/Makefile.objs | 5 +++++ > >> {crypto =3D> util}/aes.c | 0 > >> crypto/init.c =3D> util/crypto-init.c | 0 > >> {crypto =3D> util}/random-gcrypt.c | 0 > >> {crypto =3D> util}/random-gnutls.c | 0 > >> {crypto =3D> util}/random-platform.c | 0 > >=20 > > Ewww, definitely do not want to see these files moved as it spreads t= he > > crypto related code over multiple locations again, which is exactly w= hat > > I spent time fixing when introducing the crypto/ directory. > >=20 > > Placing them to libqemuutil.a shouldn't mean we need to move the code= too. >=20 > Fair enough, will do in v2. I would love to be able to have a libqemucrypto.a library for everything in crypto/ really, but the way we do QOM registration via library constructors breaks this. The ld linker isn't clever enough to see the .o is used via a constructor so unhelpfully throws away all the .o files containing QOM objects :-( Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|