From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] autobuild-run: fix cross tools prefix for diffoscope
Date: Tue, 6 Aug 2019 23:42:48 +0530 [thread overview]
Message-ID: <20190806181251.21885-3-itsatharva@gmail.com> (raw)
In-Reply-To: <20190806181251.21885-1-itsatharva@gmail.com>
Make outputs "make: entering directory" when called from a different
directory which is unnecessary and yields a wrong prefix. Adding this
argument supresses unnecessary output and yields the right prefix.
Before and after: https://gitlab.com/snippets/1877119
Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
scripts/autobuild-run | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index ab49dcb..69766b2 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -447,7 +447,8 @@ class Builder:
with open(reproducible_results, 'w') as diff:
if self.sysinfo.has("diffoscope"):
# Prefix to point diffoscope towards cross-tools
- prefix = subprocess.check_output(["make", "O=%s" % self.outputdir, "-C", self.srcdir, "printvars", "VARS=TARGET_CROSS"])
+ prefix = subprocess.check_output(["make", "--no-print-directory", "O=%s" % self.outputdir,
+ "-C", self.srcdir, "printvars", "VARS=TARGET_CROSS"])
# Remove TARGET_CROSS= and \n from the string
prefix = prefix[13:-1]
log_write(self.log, "INFO: running diffoscope on images")
--
2.22.0
next prev parent reply other threads:[~2019-08-06 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 18:12 [Buildroot] [PATCH 1/6] autobuild-run: use different output directories for reproducible builds testing Atharva Lele
2019-08-06 18:12 ` [Buildroot] [PATCH 2/6] autobuild-run: make prepare_build() clean the output directory used for reproducibility testing Atharva Lele
2019-08-06 18:12 ` Atharva Lele [this message]
2019-08-06 20:18 ` [Buildroot] [PATCH 3/6] autobuild-run: fix cross tools prefix for diffoscope Thomas Petazzoni
2019-08-06 18:12 ` [Buildroot] [PATCH 4/6] autobuild-run: make diffoscope output to a JSON-formatted file Atharva Lele
2019-08-06 19:40 ` Thomas Petazzoni
2019-08-07 6:12 ` Atharva Lele
2019-08-06 18:12 ` [Buildroot] [PATCH 5/6] autobuild-run: initial implementation of get_reproducibility_failure_reason() Atharva Lele
2019-08-06 20:21 ` Thomas Petazzoni
2019-08-07 6:07 ` Atharva Lele
2019-08-06 18:12 ` [Buildroot] [PATCH 6/6] autobuild-run: account for reproducibility failures in get_failure_reason() Atharva Lele
2019-08-06 19:37 ` [Buildroot] [PATCH 1/6] autobuild-run: use different output directories for reproducible builds testing Thomas Petazzoni
2019-08-07 6:02 ` Atharva Lele
2019-08-07 8:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806181251.21885-3-itsatharva@gmail.com \
--to=itsatharva@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.