Re: [meta-oe][PATCH] modemmanager: Use a simpler workaround for the clang build

[Adrian Bunk <bunk@stusta.de>]

On Tue, Aug 06, 2019 at 11:09:50AM -0700, Khem Raj wrote:
> On Tue, Aug 6, 2019 at 8:39 AM Adrian Bunk <bunk@stusta.de> wrote:
>...
> > @@ -33,7 +32,7 @@ PACKAGECONFIG[qmi] = "--with-qmi,--without-qmi,libqmi"
> >  EXTRA_OECONF = " \
> >      --with-udev-base-dir=${nonarch_base_libdir}/udev \
> >  "
> > -CFLAGS_append_toolchain-gcc = " -Wno-unused-but-set-variable"
> > +EXTRA_OECONF_append_toolchain-clang = " --enable-more-warnings=no"
> >
> 
> I think this will disable extra warnings but since the patch was
> anyway doing same although just for one warning
> this is fine by me.

And it's only for clang.

> I still would like to have an option to be able to
> build with default warning set and have easy way for OE devs to
> fix/report such issues to package upstream instead of masking them
> out.

If someone wants to fix or report warnings upstream, then a stable 
release that might be years behind upstream master is usually not
a good starting point - when you are upstream in OE you are also
not very enthusiastic when people send patches for Yocto 2.0 today.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed