From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hv5FG-0005Q4-IK for mharc-grub-devel@gnu.org; Tue, 06 Aug 2019 15:35:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54868) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hv5FD-0005Os-42 for grub-devel@gnu.org; Tue, 06 Aug 2019 15:35:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hv5FB-0003ox-PR for grub-devel@gnu.org; Tue, 06 Aug 2019 15:35:38 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:52372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hv5FB-0003mj-Hr for grub-devel@gnu.org; Tue, 06 Aug 2019 15:35:37 -0400 Received: by mail-wm1-x341.google.com with SMTP id s3so79339634wms.2 for ; Tue, 06 Aug 2019 12:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JF46c0ZWt8nsgg7syotmNbFrSFUZa8bG2EgbRkvgyYY=; b=AxKjsJFekaGC+6dBFV8eoO5MInhFcAtPP9Aq26kAK03OJxg9wLhVxe9nKxJY6fXfJc q9PvgykHcJJzjLVCsPdfHSTnL6TU4zYpDATpYuDF5jhomO278tr3MihCTFpvo/6vY0si 2oorpsDYN59G48rCwmYNew9AAPmF/0bWp7sAsMjEC2Fv5c2YPvJF1Grk6McGIeHHiNxY tOw6WPsGnr/SlZ5XSZwNmQe4pPE0C3hUx8W97uuYqtggfLQM6sYt1MzVo7434p+G6JKv ueg+RrsChiAZJuX1hu7IvnWaWE+pF3uOjDXuSgl4yXM3ZHNuAjj7hQD4lDNh834j3ZgB rVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JF46c0ZWt8nsgg7syotmNbFrSFUZa8bG2EgbRkvgyYY=; b=SgOVVApOwWYDEMW2P1oHn046ssUQ7RdUzUQ8+cOHnDHVEEUI35uYQlslR0vovuIH37 gREB6iCn3uQIy+kgynEIzOn04xbP6aGwfREifJvWyzGaygNkJdS7aK44s2R7fTy55WRN /XvfLFo4HWdSWTdqp7M/EQ9K8ESFt4foWRp4xXz5soc8o4VEQv6OMcGZQuCwmhYA/IpW ivKuLRCQkrqx6ZByWrA3pxqBzfDCBf5XaHwurY1yCnWxnqcFUylGVRgZy+rzW/72Z6Zc 6ZkQDIelFNU3dDXftx6G0MaNUQkTyrdQf7pSTu0FZfN1OMXJlg4eRjRAAApbZjYzo1u/ OlXw== X-Gm-Message-State: APjAAAUe8nB7E+8w1sREOdrsHIuTcd8LwiJO9B3HK/fBE0YvJfmY7udq Mj1dL2qnQWGdKZLv/tPnJ1WvwA== X-Google-Smtp-Source: APXvYqw5uJF4mamoZcyeRFuYhJQFpG/RspcuqRnwqB4g0wjlBTPaXkQc8Q7aIzkdas4z7Y2J590Vpw== X-Received: by 2002:a7b:c30f:: with SMTP id k15mr1125622wmj.11.1565120135761; Tue, 06 Aug 2019 12:35:35 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w7sm103865721wrn.11.2019.08.06.12.35.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 12:35:34 -0700 (PDT) Date: Tue, 6 Aug 2019 20:35:33 +0100 From: Leif Lindholm To: Heinrich Schuchardt Cc: Peter Jones , Patrick Wildt , Alexander Graf , u-boot@lists.denx.de, Simon Glass , AKASHI Takahiro , GRUB development mailing list , Javier Martinez Canillas Subject: Re: EFI_PXE_BASE_CODE_PROTOCOL Message-ID: <20190806193533.GL25813@bivouac.eciton.net> References: <12c99515-030e-3cd6-1eca-cb839d47b00b@gmx.de> <20190410092035.GA96616@thor.local> <20190410092453.GA96737@thor.local> <20190802192639.GA4631@nyx.fritz.box> <3b958976-1801-c3cc-196d-606293a06938@gmx.de> <20190806084414.GD25813@bivouac.eciton.net> <20190806170202.tcav77l3a764wqxv@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Aug 2019 19:35:40 -0000 On Tue, Aug 06, 2019 at 08:52:09PM +0200, Heinrich Schuchardt wrote: > > > > EFI_PXE_BASE_CODE_PACKET DhcpAck is a union: > > > > > > > > typedef union { > > > > UINT8 Raw[1472]; > > > > EFI_PXE_BASE_CODE_DHCPV4_PACKET Dhcpv4; > > > > EFI_PXE_BASE_CODE_DHCPV6_PACKET Dhcpv6; > > > > } EFI_PXE_BASE_CODE_PACKET; > > > > > > > > Should the check be done in grub_efi_net_config_real()? > > > > > > Possibly. I've cc:d Peter since he's the last person I know who took a > > > proper look at this. > > > > That's actually what we've got in our current patch set, based on > > Michael Chang at SuSE's https work. Javier Martinez (cc'd) is working > > on getting those ready for upstream, but in the mean time, check out the > > patches nearby to: > > > > https://github.com/rhboot/grub2/commit/4f977935a9271727bf21889526fdf82f0fc8fed9 > > Thank you for the link. > > There are currently no plans to implement these device paths in U-Boot: > > * IPv4 Device Path > * IPv6 Device Path > * Uniform Resource Identifiers (URI) Device Path > > I assume that these device paths would only be installed on handles > implementing the EFI DHCPv4 Protocol or the EFI DHCPv6 Protocol but > could not identify the relevant information in the specification. 10.3.4.12/13 (UEFI 2.8 spec) for IPv4/IPv6. 10.3.4.23 for URI. (And 10.3.4.21 for iSCSI.) But if you are only asking because you found the (NULLed-out) PXE protocol implemented, then I would suggest we can ignore this for now. I guess it could be useful for netbooting GRUB (the device paths, and passing DHCP information retrieved by U-Boot into GRUB), not the EFI_PXE_BASE_CODE_PROTOCOL). / Leif From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leif Lindholm Date: Tue, 6 Aug 2019 20:35:33 +0100 Subject: [U-Boot] EFI_PXE_BASE_CODE_PROTOCOL In-Reply-To: References: <12c99515-030e-3cd6-1eca-cb839d47b00b@gmx.de> <20190410092035.GA96616@thor.local> <20190410092453.GA96737@thor.local> <20190802192639.GA4631@nyx.fritz.box> <3b958976-1801-c3cc-196d-606293a06938@gmx.de> <20190806084414.GD25813@bivouac.eciton.net> <20190806170202.tcav77l3a764wqxv@redhat.com> Message-ID: <20190806193533.GL25813@bivouac.eciton.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 06, 2019 at 08:52:09PM +0200, Heinrich Schuchardt wrote: > > > > EFI_PXE_BASE_CODE_PACKET DhcpAck is a union: > > > > > > > > typedef union { > > > > UINT8 Raw[1472]; > > > > EFI_PXE_BASE_CODE_DHCPV4_PACKET Dhcpv4; > > > > EFI_PXE_BASE_CODE_DHCPV6_PACKET Dhcpv6; > > > > } EFI_PXE_BASE_CODE_PACKET; > > > > > > > > Should the check be done in grub_efi_net_config_real()? > > > > > > Possibly. I've cc:d Peter since he's the last person I know who took a > > > proper look at this. > > > > That's actually what we've got in our current patch set, based on > > Michael Chang at SuSE's https work. Javier Martinez (cc'd) is working > > on getting those ready for upstream, but in the mean time, check out the > > patches nearby to: > > > > https://github.com/rhboot/grub2/commit/4f977935a9271727bf21889526fdf82f0fc8fed9 > > Thank you for the link. > > There are currently no plans to implement these device paths in U-Boot: > > * IPv4 Device Path > * IPv6 Device Path > * Uniform Resource Identifiers (URI) Device Path > > I assume that these device paths would only be installed on handles > implementing the EFI DHCPv4 Protocol or the EFI DHCPv6 Protocol but > could not identify the relevant information in the specification. 10.3.4.12/13 (UEFI 2.8 spec) for IPv4/IPv6. 10.3.4.23 for URI. (And 10.3.4.21 for iSCSI.) But if you are only asking because you found the (NULLed-out) PXE protocol implemented, then I would suggest we can ignore this for now. I guess it could be useful for netbooting GRUB (the device paths, and passing DHCP information retrieved by U-Boot into GRUB), not the EFI_PXE_BASE_CODE_PROTOCOL). / Leif