From: Alan Kao <alankao@andestech.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: linux-riscv@lists.infradead.org, Nicolas Pitre <nico@fluxnic.net>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH] RISC-V: Remove udivdi3
Date: Wed, 7 Aug 2019 08:18:46 +0800 [thread overview]
Message-ID: <20190807001846.GA21655@andestech.com> (raw)
In-Reply-To: <20190807000508.9477-1-palmer@sifive.com>
On Tue, Aug 06, 2019 at 05:05:08PM -0700, Palmer Dabbelt wrote:
> This should never have landed in the first place: it was added as part
> of 64-bit divide support for 32-bit systems, but the kernel doesn't
> allow this sort of division. I must have forgotten to remove it.
>
> This patch removes the support. Since this routine only worked on
> 64-bit platforms but was only built on 32-bit platforms, it's
> essentially just nonsense anyway.
>
It would be more complete if we add
"Reported-by: Eric Lin <tesheng@andestech.com>" here.
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
> ---
> arch/riscv/lib/Makefile | 2 --
> arch/riscv/lib/udivdi3.S | 32 --------------------------------
> 2 files changed, 34 deletions(-)
> delete mode 100644 arch/riscv/lib/udivdi3.S
>
> diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile
> index 8e364ebf37de..267feaa10f6a 100644
> --- a/arch/riscv/lib/Makefile
> +++ b/arch/riscv/lib/Makefile
> @@ -5,5 +5,3 @@ lib-y += memset.o
> lib-y += uaccess.o
>
> lib-$(CONFIG_64BIT) += tishift.o
> -
> -lib-$(CONFIG_32BIT) += udivdi3.o
> diff --git a/arch/riscv/lib/udivdi3.S b/arch/riscv/lib/udivdi3.S
> deleted file mode 100644
> index 3f07476a91a9..000000000000
> --- a/arch/riscv/lib/udivdi3.S
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - * Copyright (C) 2016-2017 Free Software Foundation, Inc.
> - */
> -
> -#include <linux/linkage.h>
> -
> -ENTRY(__udivdi3)
> - mv a2, a1
> - mv a1, a0
> - li a0, -1
> - beqz a2, .L5
> - li a3, 1
> - bgeu a2, a1, .L2
> -.L1:
> - blez a2, .L2
> - slli a2, a2, 1
> - slli a3, a3, 1
> - bgtu a1, a2, .L1
> -.L2:
> - li a0, 0
> -.L3:
> - bltu a1, a2, .L4
> - sub a1, a1, a2
> - or a0, a0, a3
> -.L4:
> - srli a3, a3, 1
> - srli a2, a2, 1
> - bnez a3, .L3
> -.L5:
> - ret
> -ENDPROC(__udivdi3)
> --
> 2.21.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-07 0:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:05 [PATCH] RISC-V: Remove udivdi3 Palmer Dabbelt
2019-08-07 0:18 ` Alan Kao [this message]
2019-08-07 0:38 ` Paul Walmsley
2019-08-07 2:09 ` Paul Walmsley
2019-08-07 2:33 ` Nicolas Pitre
2019-08-07 2:40 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807001846.GA21655@andestech.com \
--to=alankao@andestech.com \
--cc=linux-riscv@lists.infradead.org \
--cc=nico@fluxnic.net \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.