From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCHv2 2/3] i915: convert to new mount API Date: Wed, 7 Aug 2019 08:30:02 +0200 Message-ID: <20190807063002.GG6627@lst.de> References: <20190805160307.5418-1-sergey.senozhatsky@gmail.com> <20190805160307.5418-3-sergey.senozhatsky@gmail.com> <20190805181255.GH1131@ZenIV.linux.org.uk> <20190805182834.GI1131@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hugh Dickins Cc: dri-devel@lists.freedesktop.org, David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Howells , Sergey Senozhatsky , Al Viro , linux-fsdevel@vger.kernel.org, Christoph Hellwig List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMDYsIDIwMTkgYXQgMTI6NTA6MTBBTSAtMDcwMCwgSHVnaCBEaWNraW5zIHdy b3RlOgo+IFRob3VnaCBwZXJzb25hbGx5IEknbSBhdmVyc2UgdG8gbWFuYWdpbmcgImYib2JqZWN0 cyB0aHJvdWdoCj4gIm0iaW50ZXJmYWNlcywgd2hpY2ggY2FuIGdldCByaWRpY3Vsb3VzIChub3Rh Ymx5LCBNQURWX0hVR0VQQUdFIHdvcmtzCj4gb24gdGhlIHZpcnR1YWwgYWRkcmVzcyBvZiBhIG1h cHBpbmcsIGJ1dCB0aGUgaHVnZS1vci1ub3QgYWxpZ25tZW50IG9mCj4gdGhhdCBtYXBwaW5nIG11 c3QgaGF2ZSBiZWVuIGRlY2lkZWQgcHJldmlvdXNseSkuICBJbiBHb29nbGUgd2UgZG8gdXNlCj4g ZmNudGxzIEZfSFVHRVBBR0UgYW5kIEZfTk9IVUdFUEFHRSB0byBvdmVycmlkZSBvbiBhIHBlci1m aWxlIGJhc2lzIC0KPiBvbmUgZGF5IEknbGwgZ2V0IHRvIHVwc3RyZWFtaW5nIHRob3NlLgoKU3Vj aCBhbiBpbnRlcmZhY2Ugc2VlbXMgdmVyeSB1c2VmdWwsIGFsdGhvdWdoIHRoZSB0d28gZmNudGxz IHNlZW0gYSBiaXQKb2RkLgoKQnV0IEkgdGhpbmsgdGhlIHBvaW50IGhlcmUgaXMgdGhhdCB0aGUg aTkxNSBoYXMgaXRzIG93biBzb21ld2hhdCBvZGQKaW5zdGFuY2Ugb2YgdG1wZnMuICBJZiB3ZSBj b3VsZCBwYXNzIHRoZSBlcXVpdmFsZW50IG9mIHRoZSBodWdlPSoKb3B0aW9ucyB0byBzaG1lbV9m aWxlX3NldHVwIGFsbCB0aGF0IGdhcmJhZ2UgKGluY2x1ZGluZyB0aGUKc2htZW1fZmlsZV9zZXR1 cF93aXRoX21udCBmdW5jdGlvbikgY291bGQgZ28gYXdheS4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1734C19759 for ; Wed, 7 Aug 2019 06:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C39D2214C6 for ; Wed, 7 Aug 2019 06:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbfHGGaN (ORCPT ); Wed, 7 Aug 2019 02:30:13 -0400 Received: from verein.lst.de ([213.95.11.211]:34839 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbfHGGaM (ORCPT ); Wed, 7 Aug 2019 02:30:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 662B368B05; Wed, 7 Aug 2019 08:30:03 +0200 (CEST) Date: Wed, 7 Aug 2019 08:30:02 +0200 From: Christoph Hellwig To: Hugh Dickins Cc: Al Viro , Sergey Senozhatsky , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Chris Wilson , David Howells , Christoph Hellwig , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCHv2 2/3] i915: convert to new mount API Message-ID: <20190807063002.GG6627@lst.de> References: <20190805160307.5418-1-sergey.senozhatsky@gmail.com> <20190805160307.5418-3-sergey.senozhatsky@gmail.com> <20190805181255.GH1131@ZenIV.linux.org.uk> <20190805182834.GI1131@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote: > Though personally I'm averse to managing "f"objects through > "m"interfaces, which can get ridiculous (notably, MADV_HUGEPAGE works > on the virtual address of a mapping, but the huge-or-not alignment of > that mapping must have been decided previously). In Google we do use > fcntls F_HUGEPAGE and F_NOHUGEPAGE to override on a per-file basis - > one day I'll get to upstreaming those. Such an interface seems very useful, although the two fcntls seem a bit odd. But I think the point here is that the i915 has its own somewhat odd instance of tmpfs. If we could pass the equivalent of the huge=* options to shmem_file_setup all that garbage (including the shmem_file_setup_with_mnt function) could go away.