From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Date: Wed, 7 Aug 2019 06:07:59 -0700 Message-ID: <20190807130759.GA24028@infradead.org> References: <20190807025640.682-1-tao.zhou1@amd.com> <20190807070834.GA24792@infradead.org> <20190807104104.GA18773@infradead.org> <18cd9fa5-2d87-2f41-b5fa-927b9790287d@amd.com> <20190807125928.GC4048@sirena.co.uk> <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "Koenig, Christian" Cc: "linux-arm-kernel@lists.infradead.org" , "kernel-build-reports@lists.linaro.org" , "Zhou1, Tao" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Mark Brown , "linux-next@vger.kernel.org" , "Deucher, Alexander" , "akpm@linux-foundation.org" , "Li, Dennis" , "Zhang, Hawking" List-Id: amd-gfx.lists.freedesktop.org On Wed, Aug 07, 2019 at 01:00:48PM +0000, Koenig, Christian wrote: > Am 07.08.19 um 14:59 schrieb Mark Brown: > > On Wed, Aug 07, 2019 at 10:55:01AM +0000, Koenig, Christian wrote: > >> Am 07.08.19 um 12:41 schrieb Christoph Hellwig: > >>> writeq/readq are provided whenever the CPU actually supports 64-bit > >>> atomic loads and stores. > >> Is there a config option which we can make the driver depend on? > > 64BIT should do the trick. > > That doesn't work because 32bit x86 does support writeq/readq as far as > I know. I also had a vague memory that x86-32 did support it with SSE, but I can't actually find any traces of that support. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8EFC433FF for ; Wed, 7 Aug 2019 13:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 860D321E6B for ; Wed, 7 Aug 2019 13:08:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="f2Zq4Lbe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387982AbfHGNIB (ORCPT ); Wed, 7 Aug 2019 09:08:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45212 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387981AbfHGNIB (ORCPT ); Wed, 7 Aug 2019 09:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rmgbWtAZ1SkJnpcyByHyTfiJSGtDnoRv+7kKXSQccI0=; b=f2Zq4LbePSmi7NsCDnVefk8D+ LxL1NCuMCeHAPIxU+md1raizksrHj4wVieebphgx7/zbtVQjsZe2c49hJMdRVrP4NSePYFXoBfkvA ygWBU3p8fvkkcX4X95wYM3/1uAqT4COnD3W9DjbFNrMa9K76lrddPngDoxKElCaHW4O+duM2LEmRa ZB+0ascLh8HNsSb6ddw86SU2FH/OQ0twMCEarz4rNNOnuUzl3TI2dmtd0egvDzzNn5LfHlkN4OiMb a5LiEPSI3VCXVUMyPwrZl5pDwoZhAKQTTH0X9KKSM6oDXAw+pYicxsPcMdijSV2kTJxt6NLod6eiM bI8Zohxng==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hvLfb-0006Iu-DD; Wed, 07 Aug 2019 13:07:59 +0000 Date: Wed, 7 Aug 2019 06:07:59 -0700 From: Christoph Hellwig To: "Koenig, Christian" Cc: Mark Brown , Christoph Hellwig , "Zhou1, Tao" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , "Zhang, Hawking" , "Li, Dennis" , "akpm@linux-foundation.org" , "linux-next@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel-build-reports@lists.linaro.org" Subject: Re: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Message-ID: <20190807130759.GA24028@infradead.org> References: <20190807025640.682-1-tao.zhou1@amd.com> <20190807070834.GA24792@infradead.org> <20190807104104.GA18773@infradead.org> <18cd9fa5-2d87-2f41-b5fa-927b9790287d@amd.com> <20190807125928.GC4048@sirena.co.uk> <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Aug 07, 2019 at 01:00:48PM +0000, Koenig, Christian wrote: > Am 07.08.19 um 14:59 schrieb Mark Brown: > > On Wed, Aug 07, 2019 at 10:55:01AM +0000, Koenig, Christian wrote: > >> Am 07.08.19 um 12:41 schrieb Christoph Hellwig: > >>> writeq/readq are provided whenever the CPU actually supports 64-bit > >>> atomic loads and stores. > >> Is there a config option which we can make the driver depend on? > > 64BIT should do the trick. > > That doesn't work because 32bit x86 does support writeq/readq as far as > I know. I also had a vague memory that x86-32 did support it with SSE, but I can't actually find any traces of that support. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B93BC32751 for ; Wed, 7 Aug 2019 13:08:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E425621E6E for ; Wed, 7 Aug 2019 13:08:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y6++FDLk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E425621E6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5BhXS80ETqxqvOcBTYBupmUDLBNSsCeIH67NiOuPL08=; b=Y6++FDLkbnpm+5 l5K9kkUNoy6cnCt1E8Byhb3cqnkG24id8LfNuRfm16VGCZZqkHzrzBYFx85h9vV4SP6eYN/cG+lPS daQeP8aUP+ME1btTsr89Xh6ByawqUgTNf1LaIj46gzDSIjCQ9haIsmuy7qgQilf5AIeNmzG4mjj47 6I0xwI2TZYW5yldrGYpsXtuaHeMBNEK+FeRqoURvvsScvs5Z/y0hVYWtKRMtMyyBi/GqrlBXxBCfY 3AHrzozXkQopC23TWQfaI2jKCPUDRd/qhxZ0C7Uf0lolrAb/Tzw+5s6khhFLJrqBoy6ghFe75tUKs tJ/pf5GVZS4G8nc2JH0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvLfd-0006JG-Gs; Wed, 07 Aug 2019 13:08:01 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hvLfb-0006Iu-DD; Wed, 07 Aug 2019 13:07:59 +0000 Date: Wed, 7 Aug 2019 06:07:59 -0700 From: Christoph Hellwig To: "Koenig, Christian" Subject: Re: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Message-ID: <20190807130759.GA24028@infradead.org> References: <20190807025640.682-1-tao.zhou1@amd.com> <20190807070834.GA24792@infradead.org> <20190807104104.GA18773@infradead.org> <18cd9fa5-2d87-2f41-b5fa-927b9790287d@amd.com> <20190807125928.GC4048@sirena.co.uk> <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <461cd4e8-31b8-def3-ca92-5b33db8d5621@amd.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" , "kernel-build-reports@lists.linaro.org" , "Zhou1, Tao" , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Mark Brown , "linux-next@vger.kernel.org" , "Deucher, Alexander" , "akpm@linux-foundation.org" , "Li, Dennis" , "Zhang, Hawking" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 07, 2019 at 01:00:48PM +0000, Koenig, Christian wrote: > Am 07.08.19 um 14:59 schrieb Mark Brown: > > On Wed, Aug 07, 2019 at 10:55:01AM +0000, Koenig, Christian wrote: > >> Am 07.08.19 um 12:41 schrieb Christoph Hellwig: > >>> writeq/readq are provided whenever the CPU actually supports 64-bit > >>> atomic loads and stores. > >> Is there a config option which we can make the driver depend on? > > 64BIT should do the trick. > > That doesn't work because 32bit x86 does support writeq/readq as far as > I know. I also had a vague memory that x86-32 did support it with SSE, but I can't actually find any traces of that support. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel