From: Stephen Boyd <sboyd@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
linux-clk@vger.kernel.org, mturquette@baylibre.com
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: Re: [PATCH] clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()
Date: Wed, 07 Aug 2019 15:34:24 -0700 [thread overview]
Message-ID: <20190807223425.65327214C6@mail.kernel.org> (raw)
In-Reply-To: <20190804163151.6511-1-nishkadg.linux@gmail.com>
Quoting Nishka Dasgupta (2019-08-04 09:31:51)
> In function st_of_flexgen_setup, variable pnode takes the return value
> of of_get_parent, which gets a node but does not put it. If pnode is not
> put before the function returns, it may cause a memory leak. Hence put
> pnode after its last occurrence.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2019-08-07 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 16:31 [PATCH] clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup() Nishka Dasgupta
2019-08-07 22:34 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807223425.65327214C6@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.