From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2793232883210417262==" MIME-Version: 1.0 From: Peter Krystad To: mptcp at lists.01.org Subject: [MPTCP] [PATCH v3 06/10] Fix return value if no DSS option is created. Date: Wed, 07 Aug 2019 15:44:30 -0700 Message-ID: <20190807224434.2829-7-peter.krystad@linux.intel.com> In-Reply-To: 20190807224434.2829-1-peter.krystad@linux.intel.com X-Status: X-Keywords: X-UID: 1599 --===============2793232883210417262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Strictly speaking mptcp_established_options_dss() should return false if no DSS option is created. squashto: Write MPTCP DSS headers to outgoing data packets Signed-off-by: Peter Krystad --- net/mptcp/options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/mptcp/options.c b/net/mptcp/options.c index 1f54c543304e..01f59ad629e5 100644 --- a/net/mptcp/options.c +++ b/net/mptcp/options.c @@ -400,6 +400,9 @@ static bool mptcp_established_options_dss(struct sock *= sk, struct sk_buff *skb, WARN(1, "MPTCP: Ack dropped"); } = + if (!dss_size) + return false; + *size =3D ALIGN(dss_size, 4); return true; } -- = 2.17.2 --===============2793232883210417262==--