From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFD2C32751 for ; Wed, 7 Aug 2019 23:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6787B2186A for ; Wed, 7 Aug 2019 23:59:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565222365; bh=xlQGs4Ss1PEAXXFBoCe2f1wiOxkqtY6afXuf8TMA9Xw=; h=In-Reply-To:References:From:Cc:To:Subject:Date:List-ID:From; b=PsZWKQaSCPvh1wZv9yfVgsp70+lH4PF0wVYc7GXE0K6lTDuN9gT/X5d1Y7moQG4Ej corCuYVPKUhMXIdjiZO9VPmm4Ex2LTyTwJN1sij5GCd2OTUB2Oms35/OD07gw6Kb9w LswDUTa4eGEWiaO343Xtata+lCiMem8vK+ei/Uzk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730117AbfHGX7Z (ORCPT ); Wed, 7 Aug 2019 19:59:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:51464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730045AbfHGX7Y (ORCPT ); Wed, 7 Aug 2019 19:59:24 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D714217D9; Wed, 7 Aug 2019 23:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565222363; bh=xlQGs4Ss1PEAXXFBoCe2f1wiOxkqtY6afXuf8TMA9Xw=; h=In-Reply-To:References:From:Cc:To:Subject:Date:From; b=Rc4GwQf5rpwauL1csS5qRpDY92wjK/Dpk0A1DPPcgh/V0YCa3P+3ZIsWZ5ZhjOmf+ JAq4VaPmsevg5gVvmNGKIQwcxSWHA5UuY8suZLnlz2HFwreM07sWviu+W3xPx2TzJY P4xr+s0CUvYCi/0zj+BnoWFtJ7JU1oJGqMrDMHAw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20190725020551.27034-1-Anson.Huang@nxp.com> <20190725210619.5EB94218D4@mail.kernel.org> From: Stephen Boyd Cc: Anson Huang , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-clk , "linux-kernel@vger.kernel.org" , Mark Rutland , Michael Turquette , Sascha Hauer , Shawn Guo , NXP Linux Team To: Rob Herring Subject: Re: [PATCH] dt-bindings: clock: imx8mn: Fix tab indentation for yaml file User-Agent: alot/0.8.1 Date: Wed, 07 Aug 2019 16:59:22 -0700 Message-Id: <20190807235923.9D714217D9@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Rob Herring (2019-07-25 14:37:24) > On Thu, Jul 25, 2019 at 3:06 PM Stephen Boyd wrote: > > > > Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51) > > > From: Anson Huang > > > > > > YAML file can NOT contain tab as indentation, fix it. > > > > > > > Would be nice if checkpatch could check for this. >=20 > Would be nice if folks just ran 'make dt_binding_check'. :) It > wouldn't be hard to add a tab check to checkpatch, but that's just one > potential problem. >=20 Cool, thanks for the pointer. Seems I forgot :) Here's a patch to improve the documentation and make help to answer questions I had about how to work this into my workflow. diff --git a/Documentation/devicetree/writing-schema.md b/Documentation/dev= icetree/writing-schema.md index dc032db36262..17ad67887fde 100644 --- a/Documentation/devicetree/writing-schema.md +++ b/Documentation/devicetree/writing-schema.md @@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which genera= tes the processed schema. It is also possible to run checks with a single schema file by setting the 'DT_SCHEMA_FILES' variable to a specific schema file. =20 +`make dt_binding_check DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings= /trivial-devices.yaml` `make dtbs_check DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/trivi= al-devices.yaml` =20 =20 diff --git a/Makefile b/Makefile index 9be5834073f8..96bb28aa1c46 100644 --- a/Makefile +++ b/Makefile @@ -1503,8 +1503,10 @@ help: @echo '' @$(if $(dtstree), \ echo 'Devicetree:'; \ - echo '* dtbs - Build device tree blobs for enabled boards'; \ - echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo '* dtbs - Build device tree blobs for enabled boards'; \ + echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo ' dt_binding_check - Validate device tree binding documents'; \ + echo ' dtbs_check - Validate device tree source files'; \ echo '') =20 @echo 'Userspace tools targets:' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6812BC433FF for ; Wed, 7 Aug 2019 23:59:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36BCD217D9 for ; Wed, 7 Aug 2019 23:59:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WkYUpU16"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rc4GwQf5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36BCD217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lurxC0CDVdhluG9ZYbP9ctsDr5GlC9PERFA1iVKtGzM=; b=WkYUpU16FhWknm z9Y/mW0SDwqTUSAkwU2ju0g1RS9xRjA+q1iztus08eo2yC34L56EEjvQncXHHE2wmZ1Uawhl+w9rB p6WSKZMO6HKL/F31MgBI3LG3YxoqvbJiBX+7pA1pgVLzc/lejPhB/VQFCIf33AFx/7dzM0M9+rayJ LjsF2IsSsMNIkVUe0SzDoyxmbJb7J3xyHA4EuV3cWrvH+vgwoP20OTaO7/Hba1lvQ0qXAynDvPEH9 zxJEONHFVXyT47DsJ6oAeZEvIlnxP4vac7TOhOqzFgLY19oyI4iu/jAvd/3eW5735MWf22x3Yy99O 0w9kNqhWufWEyeR8yRNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvVq4-00067n-Cl; Wed, 07 Aug 2019 23:59:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvVq0-00067O-LP for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 23:59:26 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D714217D9; Wed, 7 Aug 2019 23:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565222363; bh=xlQGs4Ss1PEAXXFBoCe2f1wiOxkqtY6afXuf8TMA9Xw=; h=In-Reply-To:References:From:Cc:To:Subject:Date:From; b=Rc4GwQf5rpwauL1csS5qRpDY92wjK/Dpk0A1DPPcgh/V0YCa3P+3ZIsWZ5ZhjOmf+ JAq4VaPmsevg5gVvmNGKIQwcxSWHA5UuY8suZLnlz2HFwreM07sWviu+W3xPx2TzJY P4xr+s0CUvYCi/0zj+BnoWFtJ7JU1oJGqMrDMHAw= MIME-Version: 1.0 In-Reply-To: References: <20190725020551.27034-1-Anson.Huang@nxp.com> <20190725210619.5EB94218D4@mail.kernel.org> From: Stephen Boyd To: Rob Herring Subject: Re: [PATCH] dt-bindings: clock: imx8mn: Fix tab indentation for yaml file User-Agent: alot/0.8.1 Date: Wed, 07 Aug 2019 16:59:22 -0700 Message-Id: <20190807235923.9D714217D9@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_165924_731694_86748DBE X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sascha Hauer , Anson Huang , Shawn Guo , Michael Turquette , "linux-kernel@vger.kernel.org" , NXP Linux Team , Sascha Hauer , Fabio Estevam , linux-clk , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Rob Herring (2019-07-25 14:37:24) > On Thu, Jul 25, 2019 at 3:06 PM Stephen Boyd wrote: > > > > Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51) > > > From: Anson Huang > > > > > > YAML file can NOT contain tab as indentation, fix it. > > > > > > > Would be nice if checkpatch could check for this. > > Would be nice if folks just ran 'make dt_binding_check'. :) It > wouldn't be hard to add a tab check to checkpatch, but that's just one > potential problem. > Cool, thanks for the pointer. Seems I forgot :) Here's a patch to improve the documentation and make help to answer questions I had about how to work this into my workflow. diff --git a/Documentation/devicetree/writing-schema.md b/Documentation/devicetree/writing-schema.md index dc032db36262..17ad67887fde 100644 --- a/Documentation/devicetree/writing-schema.md +++ b/Documentation/devicetree/writing-schema.md @@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which generates the processed schema. It is also possible to run checks with a single schema file by setting the 'DT_SCHEMA_FILES' variable to a specific schema file. +`make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml` `make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml` diff --git a/Makefile b/Makefile index 9be5834073f8..96bb28aa1c46 100644 --- a/Makefile +++ b/Makefile @@ -1503,8 +1503,10 @@ help: @echo '' @$(if $(dtstree), \ echo 'Devicetree:'; \ - echo '* dtbs - Build device tree blobs for enabled boards'; \ - echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo '* dtbs - Build device tree blobs for enabled boards'; \ + echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo ' dt_binding_check - Validate device tree binding documents'; \ + echo ' dtbs_check - Validate device tree source files'; \ echo '') @echo 'Userspace tools targets:' _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel