From: Wei Yang <richardw.yang@linux.intel.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: quintela@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH
Date: Thu, 8 Aug 2019 08:59:35 +0800 [thread overview]
Message-ID: <20190808005935.GA3084@richard> (raw)
In-Reply-To: <20190807183534.GN27871@work-vm>
On Wed, Aug 07, 2019 at 07:35:34PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> For migration incoming side, it either quit in precopy or postcopy. It
>> is safe to use the mis->bh for both instead of allocating a dedicated
>> QEMUBH for postcopy.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>Hi Wei,
> Can you check this, the patchew tests came back with a failure which
>seems bh related; I've not tried it, but can you just see if you can
>reproduce it?
Hmm... the error message in mail is a little confusion.
I see following error, but have no idea about what it is.
==8174==ERROR: AddressSanitizer: heap-use-after-free on address 0x61200002c7f0 at pc 0x5566916cbf76 bp 0x7fc74f4b8680 sp 0x7fc74f4b8678
WRITE of size 1 at 0x61200002c7f0 thread T9
==8179==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
PASS 3 ahci-test /x86_64/ahci/pci_enable
==8192==WARNING: ASan doesn't fully support makecontext/swapcontext functions and may produce false positives in some cases!
#0 0x5566916cbf75 in aio_notify /tmp/qemu-test/src/util/async.c:351:9
#1 0x5566916cdbab in qemu_bh_schedule /tmp/qemu-test/src/util/async.c:167:9
#2 0x5566916d0db0 in aio_co_schedule /tmp/qemu-test/src/util/async.c:464:5
---
Right alloca redzone: cb
Shadow gap: cc
==8174==ABORTING
ERROR - too few tests run (expected 40, got 18)
make: *** [/tmp/qemu-test/src/tests/Makefile.include:904: check-unit] Error 1
make: *** Waiting for unfinished jobs....
PASS 4 ahci-test /x86_64/ahci/hba_spec
I am trying to reproduce it. I guess docker should be used. Would you mind
sharing some link on setup the environment.
Thanks
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-08-08 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 5:31 [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH Wei Yang
2019-08-05 6:35 ` no-reply
2019-08-07 18:35 ` Dr. David Alan Gilbert
2019-08-08 0:59 ` Wei Yang [this message]
2019-08-08 2:02 ` Wei Yang
2019-08-08 17:44 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808005935.GA3084@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.