From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCHv2 2/3] i915: convert to new mount API Date: Thu, 8 Aug 2019 02:23:14 +0100 Message-ID: <20190808012314.GK1131@ZenIV.linux.org.uk> References: <20190805160307.5418-1-sergey.senozhatsky@gmail.com> <20190805160307.5418-3-sergey.senozhatsky@gmail.com> <20190805181255.GH1131@ZenIV.linux.org.uk> <20190805182834.GI1131@ZenIV.linux.org.uk> <20190807063002.GG6627@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190807063002.GG6627@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christoph Hellwig Cc: David Airlie , intel-gfx@lists.freedesktop.org, Hugh Dickins , linux-kernel@vger.kernel.org, David Howells , Sergey Senozhatsky , dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMDcsIDIwMTkgYXQgMDg6MzA6MDJBTSArMDIwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gT24gVHVlLCBBdWcgMDYsIDIwMTkgYXQgMTI6NTA6MTBBTSAtMDcwMCwgSHVn aCBEaWNraW5zIHdyb3RlOgo+ID4gVGhvdWdoIHBlcnNvbmFsbHkgSSdtIGF2ZXJzZSB0byBtYW5h Z2luZyAiZiJvYmplY3RzIHRocm91Z2gKPiA+ICJtImludGVyZmFjZXMsIHdoaWNoIGNhbiBnZXQg cmlkaWN1bG91cyAobm90YWJseSwgTUFEVl9IVUdFUEFHRSB3b3Jrcwo+ID4gb24gdGhlIHZpcnR1 YWwgYWRkcmVzcyBvZiBhIG1hcHBpbmcsIGJ1dCB0aGUgaHVnZS1vci1ub3QgYWxpZ25tZW50IG9m Cj4gPiB0aGF0IG1hcHBpbmcgbXVzdCBoYXZlIGJlZW4gZGVjaWRlZCBwcmV2aW91c2x5KS4gIElu IEdvb2dsZSB3ZSBkbyB1c2UKPiA+IGZjbnRscyBGX0hVR0VQQUdFIGFuZCBGX05PSFVHRVBBR0Ug dG8gb3ZlcnJpZGUgb24gYSBwZXItZmlsZSBiYXNpcyAtCj4gPiBvbmUgZGF5IEknbGwgZ2V0IHRv IHVwc3RyZWFtaW5nIHRob3NlLgo+IAo+IFN1Y2ggYW4gaW50ZXJmYWNlIHNlZW1zIHZlcnkgdXNl ZnVsLCBhbHRob3VnaCB0aGUgdHdvIGZjbnRscyBzZWVtIGEgYml0Cj4gb2RkLgo+IAo+IEJ1dCBJ IHRoaW5rIHRoZSBwb2ludCBoZXJlIGlzIHRoYXQgdGhlIGk5MTUgaGFzIGl0cyBvd24gc29tZXdo YXQgb2RkCj4gaW5zdGFuY2Ugb2YgdG1wZnMuICBJZiB3ZSBjb3VsZCBwYXNzIHRoZSBlcXVpdmFs ZW50IG9mIHRoZSBodWdlPSoKPiBvcHRpb25zIHRvIHNobWVtX2ZpbGVfc2V0dXAgYWxsIHRoYXQg Z2FyYmFnZSAoaW5jbHVkaW5nIHRoZQo+IHNobWVtX2ZpbGVfc2V0dXBfd2l0aF9tbnQgZnVuY3Rp b24pIGNvdWxkIGdvIGF3YXkuCgouLi4gb3IgZm9sbG93IHNobWVtX2ZpbGVfc3VwZXIoKSB3aXRo IHdoYXRldmVyIHRoYXQgZmNudGwgbWFwcyB0bwppbnRlcm5hbGx5LiAgSSB3b3VsZCByZWFsbHkg bG92ZSB0byBnZXQgcmlkIG9mIHRoYXQgaTkxNSBrbHVkZ2UuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A95DC32751 for ; Thu, 8 Aug 2019 01:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 130B02186A for ; Thu, 8 Aug 2019 01:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730467AbfHHBXX (ORCPT ); Wed, 7 Aug 2019 21:23:23 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:49848 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730382AbfHHBXX (ORCPT ); Wed, 7 Aug 2019 21:23:23 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hvX98-0000RZ-U7; Thu, 08 Aug 2019 01:23:15 +0000 Date: Thu, 8 Aug 2019 02:23:14 +0100 From: Al Viro To: Christoph Hellwig Cc: Hugh Dickins , Sergey Senozhatsky , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Chris Wilson , David Howells , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCHv2 2/3] i915: convert to new mount API Message-ID: <20190808012314.GK1131@ZenIV.linux.org.uk> References: <20190805160307.5418-1-sergey.senozhatsky@gmail.com> <20190805160307.5418-3-sergey.senozhatsky@gmail.com> <20190805181255.GH1131@ZenIV.linux.org.uk> <20190805182834.GI1131@ZenIV.linux.org.uk> <20190807063002.GG6627@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807063002.GG6627@lst.de> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Aug 07, 2019 at 08:30:02AM +0200, Christoph Hellwig wrote: > On Tue, Aug 06, 2019 at 12:50:10AM -0700, Hugh Dickins wrote: > > Though personally I'm averse to managing "f"objects through > > "m"interfaces, which can get ridiculous (notably, MADV_HUGEPAGE works > > on the virtual address of a mapping, but the huge-or-not alignment of > > that mapping must have been decided previously). In Google we do use > > fcntls F_HUGEPAGE and F_NOHUGEPAGE to override on a per-file basis - > > one day I'll get to upstreaming those. > > Such an interface seems very useful, although the two fcntls seem a bit > odd. > > But I think the point here is that the i915 has its own somewhat odd > instance of tmpfs. If we could pass the equivalent of the huge=* > options to shmem_file_setup all that garbage (including the > shmem_file_setup_with_mnt function) could go away. ... or follow shmem_file_super() with whatever that fcntl maps to internally. I would really love to get rid of that i915 kludge.