From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
Date: Thu, 8 Aug 2019 09:03:26 +0200 [thread overview]
Message-ID: <20190808090326.76961230@jawa> (raw)
In-Reply-To: <20190806102302.9338-1-peng.fan@nxp.com>
On Tue, 6 Aug 2019 10:07:26 +0000
Peng Fan <peng.fan@nxp.com> wrote:
> Add missed break for HDMI entry.
> And moving FIT parsing earlier, because it does not have parameter,
> it will not runs into CFG_REG_SIZE.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> tools/imx8mimage.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
> index 50a256cbac..6c02337698 100644
> --- a/tools/imx8mimage.c
> +++ b/tools/imx8mimage.c
> @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token,
> char *name, int lineno) break;
> case CMD_SIGNED_HDMI:
> signed_hdmi = token;
> - case CMD_FIT:
> - using_fit = 1;
> break;
> case CMD_DDR_FW:
> /* Do nothing */
> @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char
> *token, name, lineno, token);
> exit(EXIT_FAILURE);
> }
> + switch (*cmd) {
> + case CMD_FIT:
> + using_fit = 1;
> + break;
> + }
> break;
> case CFG_REG_SIZE:
> parse_cfg_cmd(*cmd, token, name, lineno);
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190808/bb930389/attachment.sig>
next prev parent reply other threads:[~2019-08-08 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 10:07 [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing Peng Fan
2019-08-07 9:55 ` Ye Li
2019-08-08 7:03 ` Lukasz Majewski [this message]
2019-08-13 8:27 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808090326.76961230@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.