From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Chandan Rajendra <chandan@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
harish@linux.ibm.com, jack@suse.cz
Subject: Re: [PATCH V2] jbd2: flush_descriptor(): Do not decrease buffer head's ref count
Date: Thu, 8 Aug 2019 11:50:40 -0400 [thread overview]
Message-ID: <20190808155040.GF3340@mit.edu> (raw)
In-Reply-To: <20190805040800.31743-1-chandan@linux.ibm.com>
On Mon, Aug 05, 2019 at 09:38:00AM +0530, Chandan Rajendra wrote:
> When executing generic/388 on a ppc64le machine, we notice the following
> call trace,
>
> VFS: brelse: Trying to free free buffer
> WARNING: CPU: 0 PID: 6637 at /root/repos/linux/fs/buffer.c:1195 __brelse+0x84/0xc0
>
> Call Trace:
> __brelse+0x80/0xc0 (unreliable)
> invalidate_bh_lru+0x78/0xc0
> on_each_cpu_mask+0xa8/0x130
> on_each_cpu_cond_mask+0x130/0x170
> invalidate_bh_lrus+0x44/0x60
> invalidate_bdev+0x38/0x70
> ext4_put_super+0x294/0x560
> generic_shutdown_super+0xb0/0x170
> kill_block_super+0x38/0xb0
> deactivate_locked_super+0xa4/0xf0
> cleanup_mnt+0x164/0x1d0
> task_work_run+0x110/0x160
> do_notify_resume+0x414/0x460
> ret_from_except_lite+0x70/0x74
>
> The warning happens because flush_descriptor() drops bh reference it
> does not own. The bh reference acquired by
> jbd2_journal_get_descriptor_buffer() is owned by the log_bufs list and
> gets released when this list is processed. The reference for doing IO is
> only acquired in write_dirty_buffer() later in flush_descriptor().
>
> Reported-by: Harish Sriram <harish@linux.ibm.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Chandan Rajendra <chandan@linux.ibm.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-08-08 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 4:08 [PATCH V2] jbd2: flush_descriptor(): Do not decrease buffer head's ref count Chandan Rajendra
2019-08-08 15:50 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808155040.GF3340@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=chandan@linux.ibm.com \
--cc=harish@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.