All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Woods, Brian" <Brian.Woods@amd.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Woods,  Brian" <Brian.Woods@amd.com>,
	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else"
Date: Thu, 8 Aug 2019 16:30:05 +0000	[thread overview]
Message-ID: <20190808163002.GA17090@amd.com> (raw)
In-Reply-To: <06b8a3a1-8e24-3b77-2a21-7802f4fb19af@suse.com>

On Tue, Aug 06, 2019 at 03:08:11PM +0200, Jan Beulich wrote:
> The blank line between it and the prior if() clearly indicates that this
> was meant to be a standalone if().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Brian Woods <brian.woods@amd.com>

> ---
> v5: New.
> 
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -166,8 +166,8 @@ static int __init iov_detect(void)
>      if ( !iommu_enable && !iommu_intremap )
>          return 0;
> -    else if ( (init_done ? amd_iommu_init_interrupt()
> -                         : amd_iommu_init(false)) != 0 )
> +    if ( (init_done ? amd_iommu_init_interrupt()
> +                    : amd_iommu_init(false)) != 0 )
>      {
>          printk("AMD-Vi: Error initialization\n");
>          return -ENODEV;
> 

-- 
Brian Woods

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-08-08 16:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 13:05 [Xen-devel] [PATCH v5 00/10] AMD IOMMU: further improvements Jan Beulich
2019-08-06 13:07 ` [Xen-devel] [PATCH v5 01/10] AMD/IOMMU: miscellaneous DTE handling adjustments Jan Beulich
2019-08-06 20:11   ` Woods, Brian
2019-08-06 13:08 ` [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else" Jan Beulich
2019-08-07  9:48   ` Andrew Cooper
2019-08-07  9:58     ` Jan Beulich
2019-08-08 16:30   ` Woods, Brian [this message]
2019-08-06 13:08 ` [Xen-devel] [PATCH v5 03/10] AMD/IOMMU: don't free shared IRT multiple times Jan Beulich
2019-09-17 12:42   ` Andrew Cooper
2019-08-06 13:08 ` [Xen-devel] [PATCH v5 04/10] AMD/IOMMU: introduce a "valid" flag for IVRS mappings Jan Beulich
2019-09-17 12:45   ` Andrew Cooper
2019-08-06 13:09 ` [Xen-devel] [PATCH v5 05/10] AMD/IOMMU: let callers of amd_iommu_alloc_intremap_table() handle errors Jan Beulich
2019-09-17 12:47   ` Andrew Cooper
2019-08-06 13:09 ` [Xen-devel] [PATCH v5 06/10] AMD/IOMMU: don't blindly allocate interrupt remapping tables Jan Beulich
2019-09-17 13:10   ` Andrew Cooper
2019-09-18  8:55     ` Jan Beulich
2019-09-18 11:36       ` Andrew Cooper
2019-09-18 13:01         ` Jan Beulich
2019-08-06 13:09 ` [Xen-devel] [PATCH v5 07/10] AMD/IOMMU: make phantom functions share " Jan Beulich
2019-09-17 13:20   ` Andrew Cooper
2019-08-06 13:10 ` [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early Jan Beulich
2019-08-06 14:25   ` Roger Pau Monné
2019-08-06 14:47     ` Jan Beulich
2019-08-06 15:16       ` Roger Pau Monné
2019-08-06 15:24         ` Jan Beulich
2019-09-17 13:29   ` Andrew Cooper
2019-08-06 13:11 ` [Xen-devel] [PATCH v5 09/10] AMD/IOMMU: replace INTREMAP_ENTRIES Jan Beulich
2019-09-17 15:08   ` Andrew Cooper
2019-08-06 13:11 ` [Xen-devel] [PATCH v5 10/10] AMD/IOMMU: restrict interrupt remapping table sizes Jan Beulich
2019-09-17 15:30   ` Andrew Cooper
2019-09-18  8:11     ` Jan Beulich
2019-09-18 10:45       ` Andrew Cooper
2019-09-18 12:31         ` Jan Beulich
2019-08-15 22:30 ` [Xen-devel] [PATCH v5 00/10] AMD IOMMU: further improvements Woods, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808163002.GA17090@amd.com \
    --to=brian.woods@amd.com \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.