From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hvjfO-0002KP-KF for mharc-qemu-riscv@gnu.org; Thu, 08 Aug 2019 10:45:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58513) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvjfN-0002KI-2m for qemu-riscv@nongnu.org; Thu, 08 Aug 2019 10:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvjfM-0002tb-3X for qemu-riscv@nongnu.org; Thu, 08 Aug 2019 10:45:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvjfL-0002sj-Tp; Thu, 08 Aug 2019 10:45:20 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C740A3024562; Thu, 8 Aug 2019 14:45:18 +0000 (UTC) Received: from gondolin (dhcp-192-181.str.redhat.com [10.33.192.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F11FF6EA; Thu, 8 Aug 2019 14:44:40 +0000 (UTC) Date: Thu, 8 Aug 2019 16:44:38 +0200 From: Cornelia Huck To: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20190808164438.7045c4cc.cohuck@redhat.com> In-Reply-To: <1565166604452.72353@bt.com> References: <45ec4924e0b34a3d9124e2db06af75b4@tpw09926dag18e.domain1.systemhost.net> <1565166604452.72353@bt.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 08 Aug 2019 14:45:19 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64} X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 14:45:22 -0000 On Wed, 7 Aug 2019 08:30:04 +0000 wrote: > Temporarily no-op size_memop was introduced to aid the conversion of > memory_region_dispatch_{read|write} operand "unsigned size" into > "MemOp op". > > Now size_memop is implemented, again hard coded size but with "Now that size_memop has been implemented properly, again hard code the size but with..." > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. s/avoid/avoids/ > > Signed-off-by: Tony Nguyen > --- > hw/s390x/s390-pci-inst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:51d0:0:0:0:0:0 with SMTP id n16csp7963287wrv; Thu, 8 Aug 2019 07:45:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/AWORr3Ahx1wUFb6UjXyUn27pU6ko6nLe7eR5OdJ6cO4GkVqyWJC5HDohAporR3U2pv2C X-Received: by 2002:a17:907:20bb:: with SMTP id pw27mr13672580ejb.93.1565275530093; Thu, 08 Aug 2019 07:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565275530; cv=none; d=google.com; s=arc-20160816; b=yI4WySDwD+W0C8U+cwrJh2juq/KdbjED/TLmLMkYV+uBkkAOuqb0hScapqf0Hwn0L4 yCcDE5oizearui9buVVCHRtPhPJqGvJY4QVZif7EieOl5In2s5mO0ucGpviKX8I39PiC L+qKUbd5lt2tUIijTN6qrPkQbJ2DQ1PW5FSlvG7VaIfXmggIFW6K1KovbbfR0v82eLpG 6FILW6hK8SRc5gMyrOk4iENZ5WJuVIO9bt9HQn7UiVPhVNfbPMUbvb+aH0IVN5P29uvD nV8RMZeUNKMcI796kr9jNasFwQRGGRMGQWbz+0jSsIVGyvl8ZLZCnGrkACaWhXGfjtl/ 7upQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:to:from:date; bh=Z+Ljq4IWNcqlNX20/Ss0hH1c7a0t0fluQdCoBlFgjCo=; b=QuAMA4Vs4J2vk5rYhRrkk6gk6+l1b0PcXsVGbP+pARBkC51/EZzIfOdc3YuFUvRhnm skU5m4O6NKIU8v3tJcEFo5j8eEqPmddBL5sTsJKw167ovl8gE/wY2v9Hfth7nu+lqDxw RORZPehduYiUnyiv0LZ6OzeROwbBFpOIFN47ysn9JKwTspiOBhBl1IF9eQJCn+m+whA+ KHwzw8csybs1qi1JgprTlGj0fx9wR5fUl6aKbObNhAifOXt45xPSa+a+dlvlbLfbm4n4 Tgxzq7QCVkx9bVjy09OlfDAbu82nJSO+hreI92frIdP8bkq2/rp8T8qwjmaaKq3Phryf RLNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x3si36138538eda.298.2019.08.08.07.45.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 07:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvjfV-0002MA-6X for alex.bennee@linaro.org; Thu, 08 Aug 2019 10:45:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58543) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvjfP-0002Kl-G4 for qemu-arm@nongnu.org; Thu, 08 Aug 2019 10:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvjfO-0002vh-ID for qemu-arm@nongnu.org; Thu, 08 Aug 2019 10:45:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvjfO-0002uy-DG; Thu, 08 Aug 2019 10:45:22 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C614DC04D293; Thu, 8 Aug 2019 14:45:18 +0000 (UTC) Received: from gondolin (dhcp-192-181.str.redhat.com [10.33.192.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F11FF6EA; Thu, 8 Aug 2019 14:44:40 +0000 (UTC) Date: Thu, 8 Aug 2019 16:44:38 +0200 From: Cornelia Huck To: Message-ID: <20190808164438.7045c4cc.cohuck@redhat.com> In-Reply-To: <1565166604452.72353@bt.com> References: <45ec4924e0b34a3d9124e2db06af75b4@tpw09926dag18e.domain1.systemhost.net> <1565166604452.72353@bt.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 08 Aug 2019 14:45:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64} X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, i.mitsyanko@gmail.com, sagark@eecs.berkeley.edu, david@redhat.com, jasowang@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, dmitry.fleytman@gmail.com, kraxel@redhat.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, xiaoguangrong.eric@gmail.com, peter.chubb@nicta.com.au, philmd@redhat.com, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, chouteau@adacore.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, jcd@tribudubois.net, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, david@gibson.dropbear.id.au, lersek@redhat.com, green@moxielogic.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, marex@denx.de, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, qemu-s390x@nongnu.org, sw@weilnetz.de, alistair@alistair23.me, yuval.shaia@oracle.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, jan.kiszka@web.de, clg@kaod.org, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, qemu-riscv@nongnu.org, proljc@gmail.com, pbonzini@redhat.com, andrew@aj.id.au, kbastian@mail.uni-paderborn.de, crwulff@gmail.com, laurent@vivier.eu, Andrew.Baumann@microsoft.com, sundeep.lkml@gmail.com, andrew.smirnov@gmail.com, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, imammedo@redhat.com, aurelien@aurel32.net, stefanb@linux.ibm.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 8qs1vcxlXtL5 On Wed, 7 Aug 2019 08:30:04 +0000 wrote: > Temporarily no-op size_memop was introduced to aid the conversion of > memory_region_dispatch_{read|write} operand "unsigned size" into > "MemOp op". > > Now size_memop is implemented, again hard coded size but with "Now that size_memop has been implemented properly, again hard code the size but with..." > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. s/avoid/avoids/ > > Signed-off-by: Tony Nguyen > --- > hw/s390x/s390-pci-inst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762E4C433FF for ; Thu, 8 Aug 2019 14:45:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 535D32184E for ; Thu, 8 Aug 2019 14:45:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 535D32184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvjfP-0007sQ-7u; Thu, 08 Aug 2019 14:45:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvjfO-0007sG-HU for xen-devel@lists.xenproject.org; Thu, 08 Aug 2019 14:45:22 +0000 X-Inumbo-ID: 25ffa090-b9eb-11e9-a8b4-2781b8db2347 Received: from mx1.redhat.com (unknown [209.132.183.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 25ffa090-b9eb-11e9-a8b4-2781b8db2347; Thu, 08 Aug 2019 14:45:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C614DC04D293; Thu, 8 Aug 2019 14:45:18 +0000 (UTC) Received: from gondolin (dhcp-192-181.str.redhat.com [10.33.192.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F11FF6EA; Thu, 8 Aug 2019 14:44:40 +0000 (UTC) Date: Thu, 8 Aug 2019 16:44:38 +0200 From: Cornelia Huck To: Message-ID: <20190808164438.7045c4cc.cohuck@redhat.com> In-Reply-To: <1565166604452.72353@bt.com> References: <45ec4924e0b34a3d9124e2db06af75b4@tpw09926dag18e.domain1.systemhost.net> <1565166604452.72353@bt.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 08 Aug 2019 14:45:21 +0000 (UTC) Subject: Re: [Xen-devel] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64} X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, i.mitsyanko@gmail.com, sagark@eecs.berkeley.edu, david@redhat.com, jasowang@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, dmitry.fleytman@gmail.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, xiaoguangrong.eric@gmail.com, peter.chubb@nicta.com.au, philmd@redhat.com, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, chouteau@adacore.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, jcd@tribudubois.net, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, david@gibson.dropbear.id.au, lersek@redhat.com, green@moxielogic.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, marex@denx.de, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, qemu-s390x@nongnu.org, sw@weilnetz.de, alistair@alistair23.me, yuval.shaia@oracle.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, jan.kiszka@web.de, clg@kaod.org, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, qemu-riscv@nongnu.org, proljc@gmail.com, pbonzini@redhat.com, andrew@aj.id.au, kbastian@mail.uni-paderborn.de, crwulff@gmail.com, laurent@vivier.eu, Andrew.Baumann@microsoft.com, sundeep.lkml@gmail.com, andrew.smirnov@gmail.com, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, imammedo@redhat.com, aurelien@aurel32.net, stefanb@linux.ibm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gV2VkLCA3IEF1ZyAyMDE5IDA4OjMwOjA0ICswMDAwCjx0b255Lm5ndXllbkBidC5jb20+IHdy b3RlOgoKPiBUZW1wb3JhcmlseSBuby1vcCBzaXplX21lbW9wIHdhcyBpbnRyb2R1Y2VkIHRvIGFp ZCB0aGUgY29udmVyc2lvbiBvZgo+IG1lbW9yeV9yZWdpb25fZGlzcGF0Y2hfe3JlYWR8d3JpdGV9 IG9wZXJhbmQgInVuc2lnbmVkIHNpemUiIGludG8KPiAiTWVtT3Agb3AiLgo+IAo+IE5vdyBzaXpl X21lbW9wIGlzIGltcGxlbWVudGVkLCBhZ2FpbiBoYXJkIGNvZGVkIHNpemUgYnV0IHdpdGgKCiJO b3cgdGhhdCBzaXplX21lbW9wIGhhcyBiZWVuIGltcGxlbWVudGVkIHByb3Blcmx5LCBhZ2FpbiBo YXJkIGNvZGUgdGhlCnNpemUgYnV0IHdpdGguLi4iCgo+IE1PX3s4fDE2fDMyfDY0fS4gVGhpcyBp cyBtb3JlIGV4cHJlc3NpdmUgYW5kIGF2b2lkIHNpemVfbWVtb3AgY2FsbHMuCgpzL2F2b2lkL2F2 b2lkcy8KCj4gCj4gU2lnbmVkLW9mZi1ieTogVG9ueSBOZ3V5ZW4gPHRvbnkubmd1eWVuQGJ0LmNv bT4KPiAtLS0KPiAgaHcvczM5MHgvczM5MC1wY2ktaW5zdC5jIHwgMyArLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKUmV2aWV3ZWQtYnk6IENvcm5l bGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA==