From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E8EC0650F for ; Thu, 8 Aug 2019 19:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 084982184E for ; Thu, 8 Aug 2019 19:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291487; bh=LS87dti7zdc7kX7Pyq3fOGJGubx/ROvQrnb62CiV/2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fGZU5gbQsccKZHZS0SAHywOfNjAS2pddiVwEbMeowbK3od9t3IxhtVvM0LAhaYIF8 0bX50NVMWqCDDquj9MYiwk6lj1GZie274ZNqRkvn20a9m/dGYU7fqqIsyGYb6u5W4W zBluRSwYYTkw48GBZixoUVcDSLqaSey80nG3fkJI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405477AbfHHTLZ (ORCPT ); Thu, 8 Aug 2019 15:11:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405466AbfHHTLW (ORCPT ); Thu, 8 Aug 2019 15:11:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84D4921743; Thu, 8 Aug 2019 19:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291481; bh=LS87dti7zdc7kX7Pyq3fOGJGubx/ROvQrnb62CiV/2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wz8QxP82wpXmuDWkBEzaxRj8iVa+ikqDIuXjBXl0TfrS2vS/5ndhq24QLg081VGNO +POtwsSXinM8p1QcsrVpNKy4Fir8YZOQp7Mf4iOlGOf0me9YPui6deh7DduguLdutw UetD3t9AMG6Gw1lzH4COBGXeuRAG2oMCTK1SvlmI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jason Gunthorpe Subject: [PATCH 4.14 09/33] [PATCH] IB: directly cast the sockaddr union to aockaddr Date: Thu, 8 Aug 2019 21:05:16 +0200 Message-Id: <20190808190454.035338318@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190808190453.582417307@linuxfoundation.org> References: <20190808190453.582417307@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Like commit 641114d2af31 ("RDMA: Directly cast the sockaddr union to sockaddr") we need to quiet gcc 9 from warning about this crazy union. That commit did not fix all of the warnings in 4.19 and older kernels because the logic in roce_resolve_route_from_path() was rewritten between 4.19 and 5.2 when that change happened. Cc: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/sa_query.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/infiniband/core/sa_query.c +++ b/drivers/infiniband/core/sa_query.c @@ -1263,7 +1263,6 @@ int ib_init_ah_from_path(struct ib_devic &init_net }; union { - struct sockaddr _sockaddr; struct sockaddr_in _sockaddr_in; struct sockaddr_in6 _sockaddr_in6; } sgid_addr, dgid_addr; @@ -1271,12 +1270,13 @@ int ib_init_ah_from_path(struct ib_devic if (!device->get_netdev) return -EOPNOTSUPP; - rdma_gid2ip(&sgid_addr._sockaddr, &rec->sgid); - rdma_gid2ip(&dgid_addr._sockaddr, &rec->dgid); + rdma_gid2ip((struct sockaddr *)&sgid_addr, &rec->sgid); + rdma_gid2ip((struct sockaddr *)&dgid_addr, &rec->dgid); /* validate the route */ - ret = rdma_resolve_ip_route(&sgid_addr._sockaddr, - &dgid_addr._sockaddr, &dev_addr); + ret = rdma_resolve_ip_route((struct sockaddr *)&sgid_addr, + (struct sockaddr *)&dgid_addr, + &dev_addr); if (ret) return ret;