From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] drm/panfrost: Implement per FD address spaces
Date: Thu, 8 Aug 2019 16:11:10 -0700 [thread overview]
Message-ID: <20190808231110.GA12294@kevin> (raw)
In-Reply-To: <20190808222918.15153-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 701 bytes --]
> @@ -448,6 +453,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, void *data)
> }
>
> if (status & JOB_INT_MASK_DONE(j)) {
> + panfrost_mmu_as_put(pfdev, &pfdev->jobs[j]->file_priv->mmu);
> panfrost_devfreq_record_transition(pfdev, j);
> dma_fence_signal(pfdev->jobs[j]->done_fence);
> }
Is the idea to switch AS's when an IRQ is fired corresponding to a
process with a particular address sspace? (Where do we switch back? Or
is that not how the MMU actually works here?)
Logically it seems sound, just armchair nervous about potential race
conditions with weird multithreading setups.
> + /* Assign the free or reclaimed AS to the */
to the....?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-08 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 22:29 [PATCH] drm/panfrost: Implement per FD address spaces Rob Herring
2019-08-08 23:11 ` Alyssa Rosenzweig [this message]
2019-08-09 3:01 ` Rob Herring
2019-08-09 7:53 ` Tomeu Vizoso
2019-08-09 12:45 ` Steven Price
2019-08-09 15:53 ` Rob Herring
2019-08-08 23:17 ` Matthew Auld
2019-08-09 2:40 ` Rob Herring
2019-08-09 12:36 ` Steven Price
2019-08-09 14:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808231110.GA12294@kevin \
--to=alyssa.rosenzweig@collabora.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.