From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C5FC0650F for ; Fri, 9 Aug 2019 03:13:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 232542171F for ; Fri, 9 Aug 2019 03:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dfd3jsOy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 232542171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andred.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QLO6TVmYyoIA34BZtmRmZZZxeqxe1ZZ2KfCmNHnw5rs=; b=Dfd3jsOy3TYY5j /NO42GVUKSTWj46ICO+1Gh5x+ZCSuEThI7GenVxyygZpKaWrTqlsMl96xTsE25k0gVbVG8VugMXe6 ILLZRbMelOYdxs9TJIu6ZRWtdLY5ViKxEIBnW/VNOZB8xMdd9tEBRVJ5o8Q9RHlow9yvgu70DJKy4 /5W0xtHCdJ1mZAChZ0RGXEDOEhCf8mG1R5W2h0xkdlYc7o7uAA1GngeASnek7u41sQ1rZ3UGIzeCf nQLdnw5NDbBW/BQmdBIGK7QpZBfm90erEtofj9mnGUBKHxHakipo/4o5/IYGYkXgPy/XutQbal9w1 z1ppInixVP9CtH9nxSVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvvKz-0007EC-V1; Fri, 09 Aug 2019 03:13:05 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvvKv-0007DG-Qe for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 03:13:04 +0000 Received: by mail-wr1-f67.google.com with SMTP id q12so6574681wrj.12 for ; Thu, 08 Aug 2019 20:13:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uonr7JGvdCWxCXj+k6k7pRPYOSgXIk19KhW6G51a7QQ=; b=sTFmoBBjm76dEqEX4qmYLRuKDPOVC5fR7Jf80OXIO6wt36QEPdsbfvJVIGWZlp4MqP xN9P0joWuctNnhfU0x0m1x95VTigDFplP+bGxOccURxJ9Gd2hIIQeCCcnhjrfhCnXr3h 5O5a0/EF1vMGFlIu1tX+mNylftKYIXRWtwRfjfr/u3PxZnruiJqvUUku80phqQ/WpeNg 6OHP7BIEJPaac7dEaaMfxvcZ8sR2He7bcU3n8RzYsCb2DjahAZJiVo3DQiCJ3nPZh/lm LddZv7MNlZueyVu85jnKnX1rw0CKtLU/UQBW+9aGVpJIHZNbjCv0bIj4dEMBTPVKs9bX uMBQ== X-Gm-Message-State: APjAAAVnptAnc/1aIcTISL17jYNMRp1yzBj9PZA3pf4SaFUbnOktzCj+ tcYqTsBYPGieD0OiKqP5Cb8= X-Google-Smtp-Source: APXvYqxTo5Q9T2mOXycuvfbxR4lb1X0KpEpQKQKLAhovI4Yky74FgaZTgY7LTdrzkcmNh0U1VAJxjQ== X-Received: by 2002:adf:fe10:: with SMTP id n16mr20512822wrr.92.1565320380703; Thu, 08 Aug 2019 20:13:00 -0700 (PDT) Received: from tfsielt31850.garage.tyco.com ([79.97.20.138]) by smtp.gmail.com with ESMTPSA id l14sm119815wrn.42.2019.08.08.20.12.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 20:13:00 -0700 (PDT) From: =?UTF-8?q?Andr=C3=A9=20Draszik?= To: linux-kernel@vger.kernel.org Subject: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay Date: Fri, 9 Aug 2019 04:12:56 +0100 Message-Id: <20190809031256.3594-1-git@andred.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_201301_860148_07D94D81 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Sascha Hauer , Russell King , NXP Linux Team , Pengutronix Kernel Team , Greg Kroah-Hartman , Shawn Guo , Thomas Gleixner , Leonard Crestez , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org UmVjZW50IGNoYW5nZXMgdG8gdGhlIEF0aGVyb3MgYXQ4MDN4IGRyaXZlciBjYXVzZQp0aGUgYXBw cm9hY2ggdGFrZW4gaGVyZSB0byBzdG9wIHdvcmtpbmcgYmVjYXVzZQpjb21taXQgNmQ0Y2QwNDFm MGFmCigibmV0OiBwaHk6IGF0ODAzeDogZGlzYWJsZSBkZWxheSBvbmx5IGZvciBSR01JSSBtb2Rl IikKYW5kIGNvbW1pdCBjZDI4ZDFkNmU1MmUKKCJuZXQ6IHBoeTogYXQ4MDN4OiBEaXNhYmxlIHBo eSBkZWxheSBmb3IgUkdNSUkgbW9kZSIpCmZpeCB0aGUgQVI4MDMxIGRyaXZlciB0byBjb25maWd1 cmUgdGhlIHBoeSdzIChSWC9UWCkKZGVsYXlzIGFzIHBlciB0aGUgJ3BoeS1tb2RlJyBpbiB0aGUg ZGV2aWNlIHRyZWUuCgpJbiBwYXJ0aWN1bGFyLCB0aGUgcGh5IHR4IChhbmQgcngpIGRlbGF5cyBh cmUgdXBkYXRlZAphZ2FpbiBhcyBwZXIgdGhlICdwaHktbW9kZScgKmFmdGVyKiB0aGUgY29kZSBp biBoZXJlCnJ1bnMuCgpUaGluZ3Mgd29ya2VkIGJlZm9yZSBhYm92ZSBjb21taXRzLCBiZWNhdXNl IHRoZSBBUjgwMzEKY29tZXMgb3V0IG9mIHJlc2V0IHdpdGggUlggZGVsYXkgZW5hYmxlZCwgYW5k IHRoZQphdDgwM3ggZHJpdmVyIGRpZG4ndCB0b3VjaCB0aGUgZGVsYXkgY29uZmlndXJhdGlvbiBh dAphbGwgd2hlbiAicmdtaWkiIG1vZGUgd2FzIHNlbGVjdGVkLgoKSXQgYXBwZWFycyB0aGUgY29k ZSBpbiBoZXJlIHRyaWVzIHRvIG1ha2UgZGV2aWNlCnRyZWVzIHdvcmsgdGhhdCBpbmNvcnJlY3Rs eSBzcGVjaWZ5ICJyZ21paSIsIGJ1dAp0aGF0IGNhbid0IHdvcmsgYW55IG1vcmUgYW5kIGl0IGlz IGltcGVyYXRpdmUgc2luY2UKYWJvdmUgY29tbWl0cyB0byBoYXZlIHRoZSBwaHktbW9kZSBjb25m aWd1cmVkCmNvcnJlY3RseSBpbiB0aGUgZGV2aWNlIHRyZWUuCgpJIHN1c3BlY3QgdGhlcmUgYXJl IGEgZmV3IGlteDdkIGJhc2VkIGJvYXJkcyB1c2luZwp0aGUgYXI4MDMxIHBoeSBhbmQgcGh5LW1v ZGUgPSAicmdtaWkiLCBidXQgZ2l2ZW4gSQpkb24ndCBrbm93IHdoaWNoIG9uZXMgZXhhY3RseSwg SSBhbSBub3QgaW4gYQpwb3NpdGlvbiB0byB1cGRhdGUgdGhlIHJlc3BlY3RpdmUgZGV2aWNlIHRy ZWVzLgoKSGVuY2UgdGhpcyBwYXRjaCBpcyBzaW1wbHkgcmVtb3ZpbmcgdGhlIHN1cGVyZmx1b3Vz CmNvZGUgZnJvbSB0aGUgaW14N2QgaW5pdGlhbGlzYXRpb24uIEFuIGFsdGVybmF0aXZlCmNvdWxk IGJlIHRvIGFkZCBhIHdhcm5pbmcgaW5zdGVhZCwgYnV0IHRoYXQgd291bGQKcGVuYWxpemUgYWxs IGJvYXJkcyB0aGF0IGhhdmUgYmVlbiB1cGRhdGVkIGFscmVhZHkuCgpTaWduZWQtb2ZmLWJ5OiBB bmRyw6kgRHJhc3ppayA8Z2l0QGFuZHJlZC5uZXQ+CkNDOiBSdXNzZWxsIEtpbmcgPGxpbnV4QGFy bWxpbnV4Lm9yZy51az4KQ0M6IFNoYXduIEd1byA8c2hhd25ndW9Aa2VybmVsLm9yZz4KQ0M6IFNh c2NoYSBIYXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4KQ0M6IFBlbmd1dHJvbml4IEtlcm5l bCBUZWFtIDxrZXJuZWxAcGVuZ3V0cm9uaXguZGU+CkNDOiBGYWJpbyBFc3RldmFtIDxmZXN0ZXZh bUBnbWFpbC5jb20+CkNDOiBOWFAgTGludXggVGVhbSA8bGludXgtaW14QG54cC5jb20+CkNDOiBL YXRlIFN0ZXdhcnQgPGtzdGV3YXJ0QGxpbnV4Zm91bmRhdGlvbi5vcmc+CkNDOiBHcmVnIEtyb2Fo LUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgpDQzogVGhvbWFzIEdsZWl4bmVy IDx0Z2x4QGxpbnV0cm9uaXguZGU+CkNDOiBMZW9uYXJkIENyZXN0ZXogPGxlb25hcmQuY3Jlc3Rl ekBueHAuY29tPgpDQzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCi0tLQog YXJjaC9hcm0vbWFjaC1pbXgvbWFjaC1pbXg3ZC5jIHwgNiAtLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtL21hY2gtaW14L21hY2gtaW14 N2QuYyBiL2FyY2gvYXJtL21hY2gtaW14L21hY2gtaW14N2QuYwppbmRleCA5NTcxMzQ1MDU5MWEu LmViYjI3NTkyYTlmNyAxMDA2NDQKLS0tIGEvYXJjaC9hcm0vbWFjaC1pbXgvbWFjaC1pbXg3ZC5j CisrKyBiL2FyY2gvYXJtL21hY2gtaW14L21hY2gtaW14N2QuYwpAQCAtMzAsMTIgKzMwLDYgQEAg c3RhdGljIGludCBhcjgwMzFfcGh5X2ZpeHVwKHN0cnVjdCBwaHlfZGV2aWNlICpkZXYpCiAJdmFs ICY9IH4oMHgxIDw8IDgpOwogCXBoeV93cml0ZShkZXYsIDB4ZSwgdmFsKTsKIAotCS8qIGludHJv ZHVjZSB0eCBjbG9jayBkZWxheSAqLwotCXBoeV93cml0ZShkZXYsIDB4MWQsIDB4NSk7Ci0JdmFs ID0gcGh5X3JlYWQoZGV2LCAweDFlKTsKLQl2YWwgfD0gMHgwMTAwOwotCXBoeV93cml0ZShkZXYs IDB4MWUsIHZhbCk7Ci0KIAlyZXR1cm4gMDsKIH0KIAotLSAKMi4yMC4xCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C3A1C433FF for ; Fri, 9 Aug 2019 03:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E941D2173C for ; Fri, 9 Aug 2019 03:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405001AbfHIDND (ORCPT ); Thu, 8 Aug 2019 23:13:03 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46900 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404958AbfHIDND (ORCPT ); Thu, 8 Aug 2019 23:13:03 -0400 Received: by mail-wr1-f68.google.com with SMTP id z1so96836744wru.13 for ; Thu, 08 Aug 2019 20:13:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uonr7JGvdCWxCXj+k6k7pRPYOSgXIk19KhW6G51a7QQ=; b=d0tecrJwZbMRlnIIPBH4bv10bWdENjG3fbgjRip0V+KitFqb7bUx8cyREvjX409UCE +hDBjlEVikIN6fbCio/ls4+jwfBqPihfxo1H2RrUKFexNo1xGzx9RRYA2vclntJUsoR2 s/oomIkAPaceMRLwaLo/4i4yH+gX7+EmP9V8kg0rQslO9XuV3j3O9OvKaWDNs0ss0zWb PSUFdyXwoLKJ7PfrKvpoUQ5l9HtYoy4qWUOvpsIBd5JGflscmqm1zOwAIaumGqXPfklq WBHo1AgErUXKw20pdKaX8FofvM/3R47seTBj676kwD2Zfkvukz8XLrQschqfmv4l2bmI 9i4g== X-Gm-Message-State: APjAAAVjS2+zT1WE+u7vjp50CXn4FxkCaAmsS4o/dMoJJz/XQA9mta42 FpLLRXVCECDA168edyOau3fzKJIv8sw3WA== X-Google-Smtp-Source: APXvYqxTo5Q9T2mOXycuvfbxR4lb1X0KpEpQKQKLAhovI4Yky74FgaZTgY7LTdrzkcmNh0U1VAJxjQ== X-Received: by 2002:adf:fe10:: with SMTP id n16mr20512822wrr.92.1565320380703; Thu, 08 Aug 2019 20:13:00 -0700 (PDT) Received: from tfsielt31850.garage.tyco.com ([79.97.20.138]) by smtp.gmail.com with ESMTPSA id l14sm119815wrn.42.2019.08.08.20.12.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 20:13:00 -0700 (PDT) From: =?UTF-8?q?Andr=C3=A9=20Draszik?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Andr=C3=A9=20Draszik?= , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , Leonard Crestez , linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay Date: Fri, 9 Aug 2019 04:12:56 +0100 Message-Id: <20190809031256.3594-1-git@andred.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Recent changes to the Atheros at803x driver cause the approach taken here to stop working because commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") and commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") fix the AR8031 driver to configure the phy's (RX/TX) delays as per the 'phy-mode' in the device tree. In particular, the phy tx (and rx) delays are updated again as per the 'phy-mode' *after* the code in here runs. Things worked before above commits, because the AR8031 comes out of reset with RX delay enabled, and the at803x driver didn't touch the delay configuration at all when "rgmii" mode was selected. It appears the code in here tries to make device trees work that incorrectly specify "rgmii", but that can't work any more and it is imperative since above commits to have the phy-mode configured correctly in the device tree. I suspect there are a few imx7d based boards using the ar8031 phy and phy-mode = "rgmii", but given I don't know which ones exactly, I am not in a position to update the respective device trees. Hence this patch is simply removing the superfluous code from the imx7d initialisation. An alternative could be to add a warning instead, but that would penalize all boards that have been updated already. Signed-off-by: André Draszik CC: Russell King CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team CC: Kate Stewart CC: Greg Kroah-Hartman CC: Thomas Gleixner CC: Leonard Crestez CC: linux-arm-kernel@lists.infradead.org --- arch/arm/mach-imx/mach-imx7d.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c index 95713450591a..ebb27592a9f7 100644 --- a/arch/arm/mach-imx/mach-imx7d.c +++ b/arch/arm/mach-imx/mach-imx7d.c @@ -30,12 +30,6 @@ static int ar8031_phy_fixup(struct phy_device *dev) val &= ~(0x1 << 8); phy_write(dev, 0xe, val); - /* introduce tx clock delay */ - phy_write(dev, 0x1d, 0x5); - val = phy_read(dev, 0x1e); - val |= 0x0100; - phy_write(dev, 0x1e, val); - return 0; } -- 2.20.1