From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Jyri Sarha <jsarha@ti.com>, Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
zhong jiang <zhongjiang@huawei.com>
Subject: Re: [PATCH] omapdrm: no need to check return value of debugfs_create functions
Date: Fri, 9 Aug 2019 09:47:33 +0200 [thread overview]
Message-ID: <20190809074733.GA19892@kroah.com> (raw)
In-Reply-To: <2d1fa29e-1441-2266-31f0-73a20cf3cebb@ti.com>
On Fri, Aug 09, 2019 at 09:59:56AM +0300, Tomi Valkeinen wrote:
> Hi,
>
> On 08/08/2019 15:50, Laurent Pinchart wrote:
> > Hi Greg,
> >
> > Thank you for the patch.
> >
> > On Thu, Jun 13, 2019 at 01:57:49PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs functions, there is no need to ever check the
> > > return value. The function can work or not, but the code logic should
> > > never do something different based on this.
> > >
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > Cc: Jyri Sarha <jsarha@ti.com>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: zhong jiang <zhongjiang@huawei.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > This makes sense.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Tomi, will you take this patch in your tree ?
>
> Yes, I'll pick this up. I presume debugfs_create_file() will give a warning
> print if it fails to create the file, instead of being silent.
Yes it does, please see 43e23b6c0b01 ("debugfs: log errors when
something goes wrong") and c33d442328f5 ("debugfs: make error message a
bit more verbose") for the details if you are curious.
Those warnings have already found at least one user of debugfs that was
doing things wrong and no one had noticed before.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-08-09 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 11:57 [PATCH] omapdrm: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-08 12:50 ` Laurent Pinchart
2019-08-09 6:59 ` Tomi Valkeinen
2019-08-09 7:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809074733.GA19892@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sebastian.reichel@collabora.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.