From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-block@vger.kernel.org, Matias Bjorling <mb@lightnvm.io>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH -next] lightnvm: Fix unused variable warning
Date: Fri, 9 Aug 2019 07:38:48 -0300 [thread overview]
Message-ID: <20190809103848.GA24835@continental> (raw)
In-Reply-To: <1565342296-45355-1-git-send-email-zhangshaokun@hisilicon.com>
On Fri, Aug 09, 2019 at 05:18:16PM +0800, Shaokun Zhang wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’ [-Wunused-variable]
> struct nvm_geo *geo = &dev->geo;
> ^
> Fixes: ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> Cc: Matias Bjorling <mb@lightnvm.io>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/lightnvm/pblk-read.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
> index 0cdc48f9cfbf..8efd14e683dc 100644
> --- a/drivers/lightnvm/pblk-read.c
> +++ b/drivers/lightnvm/pblk-read.c
> @@ -417,8 +417,6 @@ static int read_rq_gc(struct pblk *pblk, struct nvm_rq *rqd,
>
> int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
> {
> - struct nvm_tgt_dev *dev = pblk->dev;
> - struct nvm_geo *geo = &dev->geo;
> struct nvm_rq rqd;
> int ret = NVM_IO_OK;
>
Jens went ahead and already fixed this one in for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=f0e6f41669d9e07f45b472e4de33d7c233a847bd
> --
> 2.7.4
>
prev parent reply other threads:[~2019-08-09 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:18 [PATCH -next] lightnvm: Fix unused variable warning Shaokun Zhang
2019-08-09 10:38 ` Marcos Paulo de Souza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809103848.GA24835@continental \
--to=marcos.souza.org@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.