From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH for_v22 0/6] x86/sgx: Remove EADD worker and page copy
Date: Fri, 9 Aug 2019 09:22:53 -0700 [thread overview]
Message-ID: <20190809162253.GC10541@linux.intel.com> (raw)
In-Reply-To: <c2938cd31a0f062d8fd319b918a0830ad6e277ec.camel@linux.intel.com>
On Fri, Aug 09, 2019 at 07:21:18PM +0300, Jarkko Sakkinen wrote:
> On Thu, 2019-08-08 at 15:13 -0700, Sean Christopherson wrote:
> > As suggested by Andy, remove the work queue in favor of handling the
> > entire EADD flow in the context of the ioctl(). After the worker is
> > gone, pass the source page/address directly to EADD instead of first
> > copying the data into kernel memory.
> >
> > This applies on top the bug fix series I sent yesterday,
> > https://patchwork.kernel.org/cover/11082995/.
> >
> > Sean Christopherson (6):
> > x86/sgx: Validate generic SECINFO immediately after copying from user
> > x86/sgx: Set SGX_ENCL_PAGE_TCS when allocating encl_page
> > x86/sgx: Move encl_page insertion into tree out of alloc flow
> > x86/sgx: Allocate encl_page prior to taking encl->lock
> > x86/sgx: Remove the EADD page worker
> > x86/sgx: Pass userspace source address directly to EADD
> >
> > arch/x86/kernel/cpu/sgx/driver/ioctl.c | 402 +++++++------------------
> > arch/x86/kernel/cpu/sgx/driver/main.c | 4 -
> > arch/x86/kernel/cpu/sgx/encl.h | 2 -
> > 3 files changed, 103 insertions(+), 305 deletions(-)
>
> Can you resend a rebased one, once I've squashed the fixes?
Yep, not a problem.
prev parent reply other threads:[~2019-08-09 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 22:13 [PATCH for_v22 0/6] x86/sgx: Remove EADD worker and page copy Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 1/6] x86/sgx: Validate generic SECINFO immediately after copying from user Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 2/6] x86/sgx: Set SGX_ENCL_PAGE_TCS when allocating encl_page Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 3/6] x86/sgx: Move encl_page insertion into tree out of alloc flow Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 4/6] x86/sgx: Allocate encl_page prior to taking encl->lock Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 5/6] x86/sgx: Remove the EADD page worker Sean Christopherson
2019-08-08 22:13 ` [PATCH for_v22 6/6] x86/sgx: Pass userspace source address directly to EADD Sean Christopherson
2019-08-09 16:21 ` [PATCH for_v22 0/6] x86/sgx: Remove EADD worker and page copy Jarkko Sakkinen
2019-08-09 16:22 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809162253.GC10541@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.