From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Date: Sat, 10 Aug 2019 05:01:53 +0000 Subject: [PATCH] sh: kernel: disassemble: Mark expected switch fall-throughs Message-Id: <20190810050153.GA13927@embeddedor> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshinori Sato , Rich Felker Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Guenter Roeck Mark switch cases where we are expecting to fall through. Fix the following warnings (Building: defconfig sh): arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Gustavo A. R. Silva --- If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4. arch/sh/kernel/disassemble.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c index defebf1a9c8a..91c87e9891da 100644 --- a/arch/sh/kernel/disassemble.c +++ b/arch/sh/kernel/disassemble.c @@ -477,6 +477,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) case FD_REG_N: if (0) goto d_reg_n; + /* else, fall through */ case F_REG_N: printk("fr%d", rn); break; @@ -488,6 +489,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) printk("xd%d", rn & ~1); break; } + /* else, fall through */ d_reg_n: case D_REG_N: printk("dr%d", rn); @@ -497,6 +499,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) printk("xd%d", rm & ~1); break; } + /* else, fall through */ case D_REG_M: printk("dr%d", rm); break; -- 2.22.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F4AC433FF for ; Sat, 10 Aug 2019 05:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEBDE2166E for ; Sat, 10 Aug 2019 05:01:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="aM5hjr/t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbfHJFB4 (ORCPT ); Sat, 10 Aug 2019 01:01:56 -0400 Received: from gateway24.websitewelcome.com ([192.185.51.61]:30702 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfHJFB4 (ORCPT ); Sat, 10 Aug 2019 01:01:56 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 6F4E71BDA for ; Sat, 10 Aug 2019 00:01:55 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id wJVrhuTtW2PzOwJVrhxFsj; Sat, 10 Aug 2019 00:01:55 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Type:MIME-Version:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JDIqY2cej5MXXLKNmQZWHt5rIYXlsg9boU/BzQ+gAIA=; b=aM5hjr/tAwY+xb8ZVWXAvX8KHK fol843Mp0I/tHMYweaPEB5SGqExXKtJm/PPZWQU7+JhsV2130POhQXbNH9v90pLksyvcxZhWpAAoA 75gISP2kWKiUuZDTZYZkFVrxCL3+GUnV4QQA50R7p34Zt5PTkcqcpiOfGNOprbSwmX6tpKnL/9k4X pbeDyX0/clugbKz3QY47JC/aMZjYzlHKBpGd3n+3cIBLEvDwmS1CBLS5/+XMJpl+7hlJJR33MC0oH WH9gY7zetwxkrwZc9cGPaTXwpPOPG/cN2nzj2s3Zca+A15Bpd4OHnZOBpUba+Pzclcmi7PBxijSPA aTTrc9yw==; Received: from [187.192.11.120] (port=56646 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.92) (envelope-from ) id 1hwJVq-000Z5F-AQ; Sat, 10 Aug 2019 00:01:54 -0500 Date: Sat, 10 Aug 2019 00:01:53 -0500 From: "Gustavo A. R. Silva" To: Yoshinori Sato , Rich Felker Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Guenter Roeck Subject: [PATCH] sh: kernel: disassemble: Mark expected switch fall-throughs Message-ID: <20190810050153.GA13927@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.11.120 X-Source-L: No X-Exim-ID: 1hwJVq-000Z5F-AQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [187.192.11.120]:56646 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark switch cases where we are expecting to fall through. Fix the following warnings (Building: defconfig sh): arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Gustavo A. R. Silva --- If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4. arch/sh/kernel/disassemble.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c index defebf1a9c8a..91c87e9891da 100644 --- a/arch/sh/kernel/disassemble.c +++ b/arch/sh/kernel/disassemble.c @@ -477,6 +477,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) case FD_REG_N: if (0) goto d_reg_n; + /* else, fall through */ case F_REG_N: printk("fr%d", rn); break; @@ -488,6 +489,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) printk("xd%d", rn & ~1); break; } + /* else, fall through */ d_reg_n: case D_REG_N: printk("dr%d", rn); @@ -497,6 +499,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) printk("xd%d", rm & ~1); break; } + /* else, fall through */ case D_REG_M: printk("dr%d", rm); break; -- 2.22.0