From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from asavdk4.altibox.net ([109.247.116.15]:37694 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbfHJGqR (ORCPT ); Sat, 10 Aug 2019 02:46:17 -0400 Date: Sat, 10 Aug 2019 08:46:11 +0200 From: Sam Ravnborg Subject: Re: [PATCH 0/5] kbuild: allow big modules to sub-divide Makefiles Message-ID: <20190810064611.GC13020@ravnborg.org> References: <20190806063923.1266-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806063923.1266-1-yamada.masahiro@socionext.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Jani Nikula , intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Michal Marek , Rodrigo Vivi , Zhenyu Wang , Zhi Wang , dri-devel@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org Hi Masahiro On Tue, Aug 06, 2019 at 03:39:18PM +0900, Masahiro Yamada wrote: > > Recently, Jani Nikula requests a better build system support > for drivers spanning multiple directories. > (better kbuild support for drivers spanning multiple directories?) > > I implemented it, so please take a look at it. > > Note: > The single targets do not work correctly. > > The single targets have never worked correctly: It works in most cases, but now always. I dunno how much it is used. Myself I almost always do make /drivers/foo/bar/ > > [1] For instance, "make drivers/foo/bar/baz.o" will descend into > drivers/foo/bar/Makefile, which may not necessarily specify > the build rule of baz.o > > It is possible for drivers/foo/Makefile having > obj-$(CONFIG_BAZ) += bar/baz.o > > [2] subdir-ccflags-y does not work. > > The single targets directly descend into the directory of > that file resides. > > It missed subdir-ccflags-y if it is specifies in parent > Makefiles. > > Perhaps, I will have to manage correct implementation of single targets. The day that kbuild has a separate step to read all Makefiles and then without using recursive make can build the kernel we can have this fixed. Until then we can accpet it as is - as fixing this may not be simple. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 0/5] kbuild: allow big modules to sub-divide Makefiles Date: Sat, 10 Aug 2019 08:46:11 +0200 Message-ID: <20190810064611.GC13020@ravnborg.org> References: <20190806063923.1266-1-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190806063923.1266-1-yamada.masahiro@socionext.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Masahiro Yamada Cc: Michal Marek , dri-devel@lists.freedesktop.org, linux-kbuild@vger.kernel.org, Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, Zhi Wang List-Id: dri-devel@lists.freedesktop.org SGkgTWFzYWhpcm8KCk9uIFR1ZSwgQXVnIDA2LCAyMDE5IGF0IDAzOjM5OjE4UE0gKzA5MDAsIE1h c2FoaXJvIFlhbWFkYSB3cm90ZToKPiAKPiBSZWNlbnRseSwgSmFuaSBOaWt1bGEgcmVxdWVzdHMg YSBiZXR0ZXIgYnVpbGQgc3lzdGVtIHN1cHBvcnQKPiBmb3IgZHJpdmVycyBzcGFubmluZyBtdWx0 aXBsZSBkaXJlY3Rvcmllcy4KPiAoYmV0dGVyIGtidWlsZCBzdXBwb3J0IGZvciBkcml2ZXJzIHNw YW5uaW5nIG11bHRpcGxlIGRpcmVjdG9yaWVzPykKPiAKPiBJIGltcGxlbWVudGVkIGl0LCBzbyBw bGVhc2UgdGFrZSBhIGxvb2sgYXQgaXQuCj4gCj4gTm90ZToKPiBUaGUgc2luZ2xlIHRhcmdldHMg ZG8gbm90IHdvcmsgY29ycmVjdGx5Lgo+IAo+IFRoZSBzaW5nbGUgdGFyZ2V0cyBoYXZlIG5ldmVy IHdvcmtlZCBjb3JyZWN0bHk6CgpJdCB3b3JrcyBpbiBtb3N0IGNhc2VzLCBidXQgbm93IGFsd2F5 cy4KSSBkdW5ubyBob3cgbXVjaCBpdCBpcyB1c2VkLgpNeXNlbGYgSSBhbG1vc3QgYWx3YXlzIGRv IG1ha2UgL2RyaXZlcnMvZm9vL2Jhci8KPiAKPiBbMV0gRm9yIGluc3RhbmNlLCAibWFrZSBkcml2 ZXJzL2Zvby9iYXIvYmF6Lm8iIHdpbGwgZGVzY2VuZCBpbnRvCj4gICAgIGRyaXZlcnMvZm9vL2Jh ci9NYWtlZmlsZSwgd2hpY2ggbWF5IG5vdCBuZWNlc3NhcmlseSBzcGVjaWZ5Cj4gICAgIHRoZSBi dWlsZCBydWxlIG9mIGJhei5vCj4gCj4gICAgIEl0IGlzIHBvc3NpYmxlIGZvciBkcml2ZXJzL2Zv by9NYWtlZmlsZSBoYXZpbmcKPiAgICAgICAgIG9iai0kKENPTkZJR19CQVopICs9IGJhci9iYXou bwo+IAo+IFsyXSBzdWJkaXItY2NmbGFncy15IGRvZXMgbm90IHdvcmsuCj4gCj4gICAgIFRoZSBz aW5nbGUgdGFyZ2V0cyBkaXJlY3RseSBkZXNjZW5kIGludG8gdGhlIGRpcmVjdG9yeSBvZgo+ICAg ICB0aGF0IGZpbGUgcmVzaWRlcy4KPiAKPiAgICAgSXQgbWlzc2VkIHN1YmRpci1jY2ZsYWdzLXkg aWYgaXQgaXMgc3BlY2lmaWVzIGluIHBhcmVudAo+ICAgICBNYWtlZmlsZXMuCj4gCj4gUGVyaGFw cywgSSB3aWxsIGhhdmUgdG8gbWFuYWdlIGNvcnJlY3QgaW1wbGVtZW50YXRpb24gb2Ygc2luZ2xl IHRhcmdldHMuClRoZSBkYXkgdGhhdCBrYnVpbGQgaGFzIGEgc2VwYXJhdGUgc3RlcCB0byByZWFk IGFsbCBNYWtlZmlsZXMKYW5kIHRoZW4gd2l0aG91dCB1c2luZyByZWN1cnNpdmUgbWFrZSBjYW4g YnVpbGQgdGhlIGtlcm5lbCB3ZSBjYW4gaGF2ZQp0aGlzIGZpeGVkLgpVbnRpbCB0aGVuIHdlIGNh biBhY2NwZXQgaXQgYXMgaXMgLSBhcyBmaXhpbmcgdGhpcyBtYXkgbm90IGJlIHNpbXBsZS4KCglT YW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs