From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE0A5C433FF for ; Sat, 10 Aug 2019 10:31:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E6292166E for ; Sat, 10 Aug 2019 10:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="puZu/Wn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E6292166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hwOeX-0003uP-QJ; Sat, 10 Aug 2019 10:31:13 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hwOeW-0003uK-Bj for xen-devel@lists.xenproject.org; Sat, 10 Aug 2019 10:31:12 +0000 X-Inumbo-ID: f883af19-bb59-11e9-8980-bc764e045a96 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id f883af19-bb59-11e9-8980-bc764e045a96; Sat, 10 Aug 2019 10:31:11 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE5E42166E; Sat, 10 Aug 2019 10:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565433070; bh=1VpqSEukS5sRGvDloeUS/AAIRLLZaGzwqQwNoch3q5U=; h=Date:From:To:Cc:Subject:From; b=puZu/Wn5vERBaeAJ3FXBSEM4mmBMDonlL39tIcojB+A7MHgNMC6zohYDFNSvE85EO ePUrjr2BUv+roD7V2Sp+CMqY0mUG3v7tqHjf9DnyYx1HZjVsuiw6Vj5jsBaQHQqY0E z0x7YUWsTvAr27z0Cl4hAiMNHOp7cwxqkDpnswVs= Date: Sat, 10 Aug 2019 12:31:08 +0200 From: Greg Kroah-Hartman To: Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org Message-ID: <20190810103108.GA29487@kroah.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.12.1 (2019-06-15) Subject: [Xen-devel] [PATCH] xen-netback: no need to check return value of debugfs_create functions X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKQ2M6IFdlaSBMaXUgPHdlaS5saXVAa2VybmVsLm9yZz4KQ2M6IFBhdWwgRHVy cmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+CkNjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKQ2M6IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcKU2lnbmVkLW9mZi1ieTogR3JlZyBL cm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0tCiBkcml2ZXJzL25l dC94ZW4tbmV0YmFjay9uZXRiYWNrLmMgfCAgMyAtLQogZHJpdmVycy9uZXQveGVuLW5ldGJhY2sv eGVuYnVzLmMgIHwgNDYgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL25ldC94ZW4tbmV0YmFjay9uZXRiYWNrLmMgYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFj ay9uZXRiYWNrLmMKaW5kZXggMWQ5OTQwZDRlOGM3Li5lMDE4OTMyYWJmNDkgMTAwNjQ0Ci0tLSBh L2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL25ldGJhY2suYworKysgYi9kcml2ZXJzL25ldC94ZW4t bmV0YmFjay9uZXRiYWNrLmMKQEAgLTE2NTMsOSArMTY1Myw2IEBAIHN0YXRpYyBpbnQgX19pbml0 IG5ldGJhY2tfaW5pdCh2b2lkKQogCiAjaWZkZWYgQ09ORklHX0RFQlVHX0ZTCiAJeGVuX25ldGJh Y2tfZGJnX3Jvb3QgPSBkZWJ1Z2ZzX2NyZWF0ZV9kaXIoInhlbi1uZXRiYWNrIiwgTlVMTCk7Ci0J aWYgKElTX0VSUl9PUl9OVUxMKHhlbl9uZXRiYWNrX2RiZ19yb290KSkKLQkJcHJfd2FybigiSW5p dCBvZiBkZWJ1Z2ZzIHJldHVybmVkICVsZCFcbiIsCi0JCQlQVFJfRVJSKHhlbl9uZXRiYWNrX2Ri Z19yb290KSk7CiAjZW5kaWYgLyogQ09ORklHX0RFQlVHX0ZTICovCiAKIAlyZXR1cm4gMDsKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jIGIvZHJpdmVycy9uZXQv eGVuLW5ldGJhY2sveGVuYnVzLmMKaW5kZXggNDEwMzQyNjRiZDM0Li5mNTMzYjczNzJkNTkgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jCisrKyBiL2RyaXZlcnMv bmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jCkBAIC0xNzAsNTAgKzE3MCwyNiBAQCBERUZJTkVfU0hP V19BVFRSSUJVVEUoeGVudmlmX2N0cmwpOwogCiBzdGF0aWMgdm9pZCB4ZW52aWZfZGVidWdmc19h ZGRpZihzdHJ1Y3QgeGVudmlmICp2aWYpCiB7Ci0Jc3RydWN0IGRlbnRyeSAqcGZpbGU7CiAJaW50 IGk7CiAKLQlpZiAoSVNfRVJSX09SX05VTEwoeGVuX25ldGJhY2tfZGJnX3Jvb3QpKQotCQlyZXR1 cm47Ci0KIAl2aWYtPnhlbnZpZl9kYmdfcm9vdCA9IGRlYnVnZnNfY3JlYXRlX2Rpcih2aWYtPmRl di0+bmFtZSwKIAkJCQkJCSAgeGVuX25ldGJhY2tfZGJnX3Jvb3QpOwotCWlmICghSVNfRVJSX09S X05VTEwodmlmLT54ZW52aWZfZGJnX3Jvb3QpKSB7Ci0JCWZvciAoaSA9IDA7IGkgPCB2aWYtPm51 bV9xdWV1ZXM7ICsraSkgewotCQkJY2hhciBmaWxlbmFtZVtzaXplb2YoImlvX3JpbmdfcSIpICsg NF07Ci0KLQkJCXNucHJpbnRmKGZpbGVuYW1lLCBzaXplb2YoZmlsZW5hbWUpLCAiaW9fcmluZ19x JWQiLCBpKTsKLQkJCXBmaWxlID0gZGVidWdmc19jcmVhdGVfZmlsZShmaWxlbmFtZSwKLQkJCQkJ CSAgICAwNjAwLAotCQkJCQkJICAgIHZpZi0+eGVudmlmX2RiZ19yb290LAotCQkJCQkJICAgICZ2 aWYtPnF1ZXVlc1tpXSwKLQkJCQkJCSAgICAmeGVudmlmX2RiZ19pb19yaW5nX29wc19mb3BzKTsK LQkJCWlmIChJU19FUlJfT1JfTlVMTChwZmlsZSkpCi0JCQkJcHJfd2FybigiQ3JlYXRpb24gb2Yg aW9fcmluZyBmaWxlIHJldHVybmVkICVsZCFcbiIsCi0JCQkJCVBUUl9FUlIocGZpbGUpKTsKLQkJ fQorCWZvciAoaSA9IDA7IGkgPCB2aWYtPm51bV9xdWV1ZXM7ICsraSkgeworCQljaGFyIGZpbGVu YW1lW3NpemVvZigiaW9fcmluZ19xIikgKyA0XTsKIAotCQlpZiAodmlmLT5jdHJsX2lycSkgewot CQkJcGZpbGUgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJjdHJsIiwKLQkJCQkJCSAgICAwNDAwLAot CQkJCQkJICAgIHZpZi0+eGVudmlmX2RiZ19yb290LAotCQkJCQkJICAgIHZpZiwKLQkJCQkJCSAg ICAmeGVudmlmX2N0cmxfZm9wcyk7Ci0JCQlpZiAoSVNfRVJSX09SX05VTEwocGZpbGUpKQotCQkJ CXByX3dhcm4oIkNyZWF0aW9uIG9mIGN0cmwgZmlsZSByZXR1cm5lZCAlbGQhXG4iLAotCQkJCQlQ VFJfRVJSKHBmaWxlKSk7Ci0JCX0KLQl9IGVsc2UKLQkJbmV0ZGV2X3dhcm4odmlmLT5kZXYsCi0J CQkgICAgIkNyZWF0aW9uIG9mIHZpZiBkZWJ1Z2ZzIGRpciByZXR1cm5lZCAlbGQhXG4iLAotCQkJ ICAgIFBUUl9FUlIodmlmLT54ZW52aWZfZGJnX3Jvb3QpKTsKKwkJc25wcmludGYoZmlsZW5hbWUs IHNpemVvZihmaWxlbmFtZSksICJpb19yaW5nX3ElZCIsIGkpOworCQlkZWJ1Z2ZzX2NyZWF0ZV9m aWxlKGZpbGVuYW1lLCAwNjAwLCB2aWYtPnhlbnZpZl9kYmdfcm9vdCwKKwkJCQkgICAgJnZpZi0+ cXVldWVzW2ldLAorCQkJCSAgICAmeGVudmlmX2RiZ19pb19yaW5nX29wc19mb3BzKTsKKwl9CisK KwlpZiAodmlmLT5jdHJsX2lycSkKKwkJZGVidWdmc19jcmVhdGVfZmlsZSgiY3RybCIsIDA0MDAs IHZpZi0+eGVudmlmX2RiZ19yb290LCB2aWYsCisJCQkJICAgICZ4ZW52aWZfY3RybF9mb3BzKTsK IH0KIAogc3RhdGljIHZvaWQgeGVudmlmX2RlYnVnZnNfZGVsaWYoc3RydWN0IHhlbnZpZiAqdmlm KQogewotCWlmIChJU19FUlJfT1JfTlVMTCh4ZW5fbmV0YmFja19kYmdfcm9vdCkpCi0JCXJldHVy bjsKLQogCWRlYnVnZnNfcmVtb3ZlX3JlY3Vyc2l2ZSh2aWYtPnhlbnZpZl9kYmdfcm9vdCk7CiAJ dmlmLT54ZW52aWZfZGJnX3Jvb3QgPSBOVUxMOwogfQotLSAKMi4yMi4wCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D44C32751 for ; Sat, 10 Aug 2019 10:31:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85A64217D7 for ; Sat, 10 Aug 2019 10:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565433072; bh=1VpqSEukS5sRGvDloeUS/AAIRLLZaGzwqQwNoch3q5U=; h=Date:From:To:Cc:Subject:List-ID:From; b=b4gU79ch6iGzJ5mmUhrLsRYWp3KR1FB5U1IUtnv3kM9k16qHfF6vqm08ndLhFGuDQ gu0fxBMxk7xleh7fOAsB+jrsdsaR/YGYsofit0P0Rt10erXuXHBBIzOsGzQxIQ+tPw nT3RiuH/+gLl5YmsFUnd30eM2qlrxLK9MXTnVXrU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbfHJKbL (ORCPT ); Sat, 10 Aug 2019 06:31:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:34304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfHJKbL (ORCPT ); Sat, 10 Aug 2019 06:31:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE5E42166E; Sat, 10 Aug 2019 10:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565433070; bh=1VpqSEukS5sRGvDloeUS/AAIRLLZaGzwqQwNoch3q5U=; h=Date:From:To:Cc:Subject:From; b=puZu/Wn5vERBaeAJ3FXBSEM4mmBMDonlL39tIcojB+A7MHgNMC6zohYDFNSvE85EO ePUrjr2BUv+roD7V2Sp+CMqY0mUG3v7tqHjf9DnyYx1HZjVsuiw6Vj5jsBaQHQqY0E z0x7YUWsTvAr27z0Cl4hAiMNHOp7cwxqkDpnswVs= Date: Sat, 10 Aug 2019 12:31:08 +0200 From: Greg Kroah-Hartman To: Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Subject: [PATCH] xen-netback: no need to check return value of debugfs_create functions Message-ID: <20190810103108.GA29487@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Wei Liu Cc: Paul Durrant Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/xen-netback/netback.c | 3 -- drivers/net/xen-netback/xenbus.c | 46 ++++++++----------------------- 2 files changed, 11 insertions(+), 38 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 1d9940d4e8c7..e018932abf49 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -1653,9 +1653,6 @@ static int __init netback_init(void) #ifdef CONFIG_DEBUG_FS xen_netback_dbg_root = debugfs_create_dir("xen-netback", NULL); - if (IS_ERR_OR_NULL(xen_netback_dbg_root)) - pr_warn("Init of debugfs returned %ld!\n", - PTR_ERR(xen_netback_dbg_root)); #endif /* CONFIG_DEBUG_FS */ return 0; diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 41034264bd34..f533b7372d59 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -170,50 +170,26 @@ DEFINE_SHOW_ATTRIBUTE(xenvif_ctrl); static void xenvif_debugfs_addif(struct xenvif *vif) { - struct dentry *pfile; int i; - if (IS_ERR_OR_NULL(xen_netback_dbg_root)) - return; - vif->xenvif_dbg_root = debugfs_create_dir(vif->dev->name, xen_netback_dbg_root); - if (!IS_ERR_OR_NULL(vif->xenvif_dbg_root)) { - for (i = 0; i < vif->num_queues; ++i) { - char filename[sizeof("io_ring_q") + 4]; - - snprintf(filename, sizeof(filename), "io_ring_q%d", i); - pfile = debugfs_create_file(filename, - 0600, - vif->xenvif_dbg_root, - &vif->queues[i], - &xenvif_dbg_io_ring_ops_fops); - if (IS_ERR_OR_NULL(pfile)) - pr_warn("Creation of io_ring file returned %ld!\n", - PTR_ERR(pfile)); - } + for (i = 0; i < vif->num_queues; ++i) { + char filename[sizeof("io_ring_q") + 4]; - if (vif->ctrl_irq) { - pfile = debugfs_create_file("ctrl", - 0400, - vif->xenvif_dbg_root, - vif, - &xenvif_ctrl_fops); - if (IS_ERR_OR_NULL(pfile)) - pr_warn("Creation of ctrl file returned %ld!\n", - PTR_ERR(pfile)); - } - } else - netdev_warn(vif->dev, - "Creation of vif debugfs dir returned %ld!\n", - PTR_ERR(vif->xenvif_dbg_root)); + snprintf(filename, sizeof(filename), "io_ring_q%d", i); + debugfs_create_file(filename, 0600, vif->xenvif_dbg_root, + &vif->queues[i], + &xenvif_dbg_io_ring_ops_fops); + } + + if (vif->ctrl_irq) + debugfs_create_file("ctrl", 0400, vif->xenvif_dbg_root, vif, + &xenvif_ctrl_fops); } static void xenvif_debugfs_delif(struct xenvif *vif) { - if (IS_ERR_OR_NULL(xen_netback_dbg_root)) - return; - debugfs_remove_recursive(vif->xenvif_dbg_root); vif->xenvif_dbg_root = NULL; } -- 2.22.0