From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stefan Roese <sr@denx.de>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Pavel Machek <pavel@denx.de>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 2/2] serial: mctrl_gpio: Support all GPIO suffixes (gpios vs gpio)
Date: Mon, 12 Aug 2019 15:31:37 +0300 [thread overview]
Message-ID: <20190812123137.GG30120@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXs=AdURCgB1GWRT=huKbXX7rGn6=upi1MMuFDHhKqX0g@mail.gmail.com>
On Mon, Aug 12, 2019 at 02:11:42PM +0200, Geert Uytterhoeven wrote:
> On Mon, Aug 12, 2019 at 1:54 PM Stefan Roese <sr@denx.de> wrote:
> > On 12.08.19 13:17, Geert Uytterhoeven wrote:
> > If we all agree, that only the documented "-gpios" variant needs to
> > be supported, then we can drop this patch.
>
> BTW, I'm still wondering if d99482673f950817 ("serial: mctrl_gpio: Check
> if GPIO property exisits before requesting it") is the right fix.
> This is a place where we rely explicitly on named GPIOs being present, so
> IMHO the ACPI code should not return a random GPIO instead.
ACPI is not taking it to consideration for now. That is, there is no support of
mctrl gpio for ACPI.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-08-12 12:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:25 [PATCH 1/2] gpiolib: Add for_each_gpio_suffix() helper Stefan Roese
2019-08-08 13:25 ` [PATCH 2/2] serial: mctrl_gpio: Support all GPIO suffixes (gpios vs gpio) Stefan Roese
2019-08-08 13:48 ` Andy Shevchenko
2019-08-08 13:59 ` Stefan Roese
2019-08-12 10:53 ` Andy Shevchenko
2019-08-13 11:42 ` Pavel Machek
2019-08-13 12:15 ` Andy Shevchenko
2019-08-12 11:17 ` Geert Uytterhoeven
2019-08-12 11:53 ` Stefan Roese
2019-08-12 12:11 ` Geert Uytterhoeven
2019-08-12 12:31 ` Andy Shevchenko [this message]
2019-08-08 13:44 ` [PATCH 1/2] gpiolib: Add for_each_gpio_suffix() helper Andy Shevchenko
2019-08-08 14:13 ` Stefan Roese
2019-08-10 8:27 ` Linus Walleij
2019-08-10 8:48 ` Greg Kroah-Hartman
2019-08-12 11:18 ` Geert Uytterhoeven
2019-08-14 8:48 ` Linus Walleij
2019-08-14 13:17 ` Stefan Roese
2019-08-14 13:32 ` Geert Uytterhoeven
2019-08-14 13:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812123137.GG30120@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pavel@denx.de \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.