From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Song Liu <songliubraving@fb.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.wilcox@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Kernel Team <Kernel-team@fb.com>,
William Kucharski <william.kucharski@oracle.com>,
"srikar@linux.vnet.ibm.com" <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH v12 5/6] khugepaged: enable collapse pmd for pte-mapped THP
Date: Mon, 12 Aug 2019 15:22:58 +0200 [thread overview]
Message-ID: <20190812132257.GB31560@redhat.com> (raw)
In-Reply-To: <20190812121144.f46abvpg6lvxwwzs@box>
On 08/12, Kirill A. Shutemov wrote:
>
> On Fri, Aug 09, 2019 at 06:01:18PM +0000, Song Liu wrote:
> > + if (pte_none(*pte) || !pte_present(*pte))
> > + continue;
>
> You don't need to check both. Present is never none.
Agreed.
Kirill, while you are here, shouldn't retract_page_tables() check
vma->anon_vma (and probably do mm_find_pmd) under vm_mm->mmap_sem?
Can't it race with, say, do_cow_fault?
Oleg.
next prev parent reply other threads:[~2019-08-12 13:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 23:37 [PATCH v12 0/6] THP aware uprobe Song Liu
2019-08-07 23:37 ` [PATCH v12 1/6] mm: move memcmp_pages() and pages_identical() Song Liu
2019-08-07 23:37 ` [PATCH v12 2/6] uprobe: use original page when all uprobes are removed Song Liu
2019-08-07 23:37 ` [PATCH v12 3/6] mm, thp: introduce FOLL_SPLIT_PMD Song Liu
2019-08-08 16:37 ` Oleg Nesterov
2019-08-08 17:16 ` Song Liu
2019-08-09 16:35 ` Oleg Nesterov
2019-08-09 16:50 ` Song Liu
2019-08-07 23:37 ` [PATCH v12 4/6] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT Song Liu
2019-08-07 23:37 ` [PATCH v12 5/6] khugepaged: enable collapse pmd for pte-mapped THP Song Liu
2019-08-08 16:33 ` Oleg Nesterov
2019-08-08 17:05 ` Song Liu
2019-08-09 15:24 ` Oleg Nesterov
2019-08-09 16:30 ` Song Liu
2019-08-09 18:01 ` Song Liu
2019-08-12 12:11 ` Kirill A. Shutemov
2019-08-12 13:22 ` Oleg Nesterov [this message]
2019-08-12 14:40 ` Kirill A. Shutemov
2019-08-12 21:04 ` Song Liu
2019-08-13 14:44 ` Song Liu
2019-08-15 10:16 ` Oleg Nesterov
2019-08-15 16:27 ` Song Liu
2019-08-13 13:30 ` Oleg Nesterov
2019-08-13 14:05 ` Oleg Nesterov
2019-08-13 15:05 ` Kirill A. Shutemov
2019-08-13 16:24 ` Oleg Nesterov
2019-08-16 14:54 ` Kirill A. Shutemov
2019-08-12 13:06 ` Oleg Nesterov
2019-08-12 14:36 ` Song Liu
2019-08-07 23:37 ` [PATCH v12 6/6] uprobe: collapse THP pmd after removing all uprobes Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812132257.GB31560@redhat.com \
--to=oleg@redhat.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.