All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessio Balsini <balsini@android.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@android.com, Jason Gunthorpe <jgg@mellanox.com>,
	Leon Romanovsky <leonro@mellanox.com>,
	"hange-folder>?" <toggle-mailboxes@google.com>
Subject: Re: [PATCH 4.9.y 4.14.y] IB/mlx5: Fix leaking stack memory to userspace
Date: Tue, 13 Aug 2019 10:27:28 +0100	[thread overview]
Message-ID: <20190812160714.GA246269@google.com> (raw)
In-Reply-To: <20190812142316.GA12869@kroah.com>

Oops, you are totally right, I was still looking at the latest
mlx5_ib_create_qp_resp struct while backporting these patches :)

Sorry for that,
Alessio

On Mon, Aug 12, 2019 at 04:23:16PM +0200, Greg KH wrote:
> On Mon, Aug 12, 2019 at 11:55:03AM +0100, Alessio Balsini wrote:
> > From: Jason Gunthorpe <jgg@mellanox.com>
> > 
> > commit 0625b4ba1a5d4703c7fb01c497bd6c156908af00 upstream.
> > 
> > mlx5_ib_create_qp_resp was never initialized and only the first 4 bytes
> > were written.
> > 
> > Fixes: 41d902cb7c32 ("RDMA/mlx5: Fix definition of mlx5_ib_create_qp_resp")
> 
> This commit only showed up in the following kernel releases:
> 	4.17 4.18.7 4.19
> 
> so why is this "fix" commit needed in anything older than 4.17?
> 
> That's why I did not backport it to older kernels, as I do not think it
> is needed there.  Do you?
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2019-08-13  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 10:48 [PATCH 3.18.y] IB/mlx5: Fix leaking stack memory to userspace Alessio Balsini
2019-08-12 10:51 ` [PATCH 4.4.y] " Alessio Balsini
2019-08-12 10:55   ` [PATCH 4.9.y 4.14.y] " Alessio Balsini
2019-08-12 14:23     ` Greg KH
2019-08-13  9:27       ` Alessio Balsini [this message]
2019-08-13 10:01         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812160714.GA246269@google.com \
    --to=balsini@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@mellanox.com \
    --cc=kernel-team@android.com \
    --cc=leonro@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=toggle-mailboxes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.