From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [RFC PATCH v6 00/92] VM introspection Date: Mon, 12 Aug 2019 14:40:41 -0700 Message-ID: <20190812214041.GA4996@linux.intel.com> References: <20190809160047.8319-1-alazar@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190809160047.8319-1-alazar@bitdefender.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Adalbert =?utf-8?B?TGF6xINy?= Cc: Tamas K Lengyel , Weijiang Yang , Yu C , kvm@vger.kernel.org, Konrad Rzeszutek Wilk , Jan Kiszka , Samuel =?iso-8859-1?Q?Laur=E9n?= , Radim =?utf-8?B?S3LEjW3DocWZ?= , Zhang@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Patrick Colp , Mathieu Tarral , Stefan Hajnoczi , Paolo Bonzini , Mihai =?utf-8?B?RG9uyJt1?= List-Id: virtualization@lists.linuxfoundation.org T24gRnJpLCBBdWcgMDksIDIwMTkgYXQgMDY6NTk6MTVQTSArMDMwMCwgQWRhbGJlcnQgTGF6xINy IHdyb3RlOgo+ICA1NSBmaWxlcyBjaGFuZ2VkLCAxMzQ4NSBpbnNlcnRpb25zKCspLCAyMjUgZGVs ZXRpb25zKC0pCgpUaGUgc2l6ZSBvZiB0aGlzIHNlcmllcyBpcyBvdmVyd2hlbG1pbmcsIHRvIHNh eSB0aGUgbGVhc3QuICBUaGUgcmVtb3RlCnBhZ2VzIGNvbmNlcHQgYW5kIFNQUCBwYXRjaGVzIG9u IHRoZWlyIG93biB3b3VsZCBiZSBoZWZ0eSBzZXJpZXMgdG8gcmV2aWV3LgoKSXQgd291bGQgYmUg dmVyeSBoZWxwZnVsIHRvIHJldmlld2VycyB0byByZW9yZGVyIHRoZSBwYXRjaGVzIGFuZCBvbmx5 IHNlbmQKdGhlIGJpdHMgdGhhdCBhcmUgYWJzb2x1dGVseSBtYW5kYXRvcnkgZm9yIGluaXRpYWwg c3VwcG9ydC4gIEZvciBleGFtcGxlLApBRkFJQ1QgdGhlIFNQUCBzdXBwb3J0IGFuZCByZW1vdGUg cGFnZXMgY29uY2VwdCBhcmUgbGFyZ2VseSBwZXJmb3JtYW5jZQpyZWxhdGVkIGFuZCBub3QgZnVu Y3Rpb25hbGx5IHJlcXVpcmVkLgoKTm90ZSwgdGhpcyB3b3VsZG4ndCBwcmV2ZW50IHlvdSBmcm9t IGNhcnJ5aW5nIHRoZSBzZXJpZXMgaW4gaXRzIGVudGlyZXR5CmluIHlvdXIgb3duIGJyYW5jaGVz LgoKUG9zc2libGUgcmVvcmRlcmluZzoKCiAgLSBCdWcgZml4ZXMgKGlmIGFueSBwYXRjaGVzIHF1 YWxpZnkgYXMgc3VjaCkKICAtIEVtdWxhdG9yIGNoYW5nZXMKICAtIEtWTSBwcmVwYXJhdG9yeSBw YXRjaGVzCiAgLSBCYXNpYyBpbnN0cm9zcGVjdGlvbiBmdW5jdGlvbmFsaXR5CgotLS0tLS0+OC0t LS0tLS0tIGN1dCB0aGUgc2VyaWVzIGhlcmUKCiAgLSBPcHRpb25hbCBpbnRyb3NwZWN0aW9uIGZ1 bmN0aW9uYWxpdHkgKGlmIHRoZXJlIGlzIGFueSkKICAtIFNQUCBhbmQgaW50cm9zcGVjdGlvbiBp bnRlZ3JhdGlvbgogIC0gUmVtb3RlIHBhZ2VzIGFuZCBpbnRyb3NwZWN0aW9uIGludGVncmF0aW9u Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxp emF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9u Lm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92 aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F1CC433FF for ; Mon, 12 Aug 2019 21:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEA442070C for ; Mon, 12 Aug 2019 21:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfHLVlP (ORCPT ); Mon, 12 Aug 2019 17:41:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:42798 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbfHLVlP (ORCPT ); Mon, 12 Aug 2019 17:41:15 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 14:40:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="200279228" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga004.fm.intel.com with ESMTP; 12 Aug 2019 14:40:48 -0700 Date: Mon, 12 Aug 2019 14:40:41 -0700 From: Sean Christopherson To: Adalbert =?utf-8?B?TGF6xINy?= Cc: kvm@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Konrad Rzeszutek Wilk , Tamas K Lengyel , Mathieu Tarral , Samuel =?iso-8859-1?Q?Laur=E9n?= , Patrick Colp , Jan Kiszka , Stefan Hajnoczi , Weijiang Yang , Zhang@vger.kernel.org, Yu C , Mihai =?utf-8?B?RG9uyJt1?= Subject: Re: [RFC PATCH v6 00/92] VM introspection Message-ID: <20190812214041.GA4996@linux.intel.com> References: <20190809160047.8319-1-alazar@bitdefender.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190809160047.8319-1-alazar@bitdefender.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Aug 09, 2019 at 06:59:15PM +0300, Adalbert Lazăr wrote: > 55 files changed, 13485 insertions(+), 225 deletions(-) The size of this series is overwhelming, to say the least. The remote pages concept and SPP patches on their own would be hefty series to review. It would be very helpful to reviewers to reorder the patches and only send the bits that are absolutely mandatory for initial support. For example, AFAICT the SPP support and remote pages concept are largely performance related and not functionally required. Note, this wouldn't prevent you from carrying the series in its entirety in your own branches. Possible reordering: - Bug fixes (if any patches qualify as such) - Emulator changes - KVM preparatory patches - Basic instrospection functionality ------>8-------- cut the series here - Optional introspection functionality (if there is any) - SPP and introspection integration - Remote pages and introspection integration