From: Rob Herring <robh@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: pantelis.antoniou@konsulko.com, frowand.list@gmail.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] of: resolver: Add of_node_put() before return and break
Date: Mon, 12 Aug 2019 16:52:28 -0600 [thread overview]
Message-ID: <20190812225228.GA21794@bogus> (raw)
In-Reply-To: <20190716054331.2775-1-nishkadg.linux@gmail.com>
On Tue, 16 Jul 2019 11:13:30 +0530, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return or break from the middle of the loop, there is no
> put, thus causing a memory leak. Hence add an of_node_put before the
> return or break in three places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/of/resolver.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2019-08-12 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 5:43 [PATCH] of: resolver: Add of_node_put() before return and break Nishka Dasgupta
2019-08-12 22:52 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812225228.GA21794@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.