All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Joe Slater <joe.slater@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 1/1] php: zlib and zip support
Date: Tue, 13 Aug 2019 07:50:03 +0300	[thread overview]
Message-ID: <20190813045003.GA5396@localhost> (raw)
In-Reply-To: <20190812192220.238334-1-joe.slater@windriver.com>

On Mon, Aug 12, 2019 at 12:22:20PM -0700, Joe Slater wrote:
> Add back zlib support.  Define zip support but do not enable it.
>...
> +# For zip, select one or none.  oldzip uses a bundled library and is deprecated.
> +#
> +PACKAGECONFIG[newzip] = "--enable-zip --with-libzip=${STAGING_EXECPREFIXDIR},,libzip"
> +PACKAGECONFIG[oldzip] = "--enable-zip --without-libzip,"
>...

Any reason why this can't be PACKAGECONFIG[zip] for the external libzip only
without any option for the bundled library?

Bundled libraries are usually behind on security fixes,
and php is a software where this tends to matter.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  parent reply	other threads:[~2019-08-13  4:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 19:22 [meta-oe][PATCH 1/1] php: zlib and zip support Joe Slater
2019-08-12 19:33 ` akuster808
2019-08-12 21:52   ` Slater, Joseph
2019-08-12 23:04     ` Khem Raj
2019-08-13  4:50 ` Adrian Bunk [this message]
2019-08-13 17:00   ` Slater, Joseph
2019-08-14  4:43     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813045003.GA5396@localhost \
    --to=bunk@stusta.de \
    --cc=joe.slater@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.