From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>,
linux-kernel@vger.kernel.org, "Kristo, Tero" <t-kristo@ti.com>
Subject: Re: [PATCH] bus: ti-sysc: Remove if-block in sysc_check_children()
Date: Mon, 12 Aug 2019 23:28:31 -0700 [thread overview]
Message-ID: <20190813062831.GF52127@atomide.com> (raw)
In-Reply-To: <b1f8756e-4b15-7f1a-8562-5b80063733de@ti.com>
* Roger Quadros <rogerq@ti.com> [190813 06:26]:
> None of those functions return anything.
> Maybe you can fix sysc_check_one_child() to return void?
> I think you can retain your patch but get rid of error variable.
Makes sense to me.
Regards,
Tony
next prev parent reply other threads:[~2019-08-13 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:40 [PATCH] bus: ti-sysc: Remove if-block in sysc_check_children() Nishka Dasgupta
2019-08-08 13:55 ` Roger Quadros
2019-08-13 4:35 ` Nishka Dasgupta
2019-08-13 6:25 ` Roger Quadros
2019-08-13 6:28 ` Tony Lindgren [this message]
2019-08-13 7:12 ` Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813062831.GF52127@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.